Python.LORIS.helper

Complexity

Total Complexity

6

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Importance

Changes

0

3 Functions

Rating	Name	Duplication	Size	Complexity
A	number_extraction()	0	8	1
A	check_json()	0	13	3
A	is_response_success()	0	10	2

import sys

This module should have a docstring.

import json
import logging


logging.basicConfig(stream=sys.stdout, level=logging.INFO)
#logger = logging.getLogger('LORISQuery')


def number_extraction(string):
    """
    Return
    :param string:
    :return: a LIST of strings of number!
    """
    import re
    return re.findall(r'\d+', string)

if __name__ == '__main__':
    print(number_extraction("T4"))


def is_response_success(status_code, expected_code):
    """
    A simple function to determine the success of the status code
    :param status_code:
    :return: boolean value
    """
    if status_code == expected_code:

The if statement can be replaced with 'return bool(test)'

Unnecessary "else" after "return"

        return True
    else:
        return False


def check_json(data):
    """
    Check if the data input is JSON format compatible.
    :param data:
    :return:
    """
    try:
        JSON = json.loads(data)

The name JSON does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

        return True, JSON
    except ValueError:
        return False, None
    except Exception as e:

Catching very general exceptions such as Exception is usually not recommended.

The name e does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

The variable e seems to be unused.

        return False, None