Python.Integration.Intermediate_LORIS_LocalDB

Complexity

Total Complexity

7

Size/Duplication

Total Lines	68
Duplicated Lines	0 %

Importance

Changes

0

1 Function

Rating	Name	Duplication	Size	Complexity
B	findTimePointUpdateDatabase()	0	54	7

import logging

The name Intermediate_LORIS_LocalDB does not conform to the module naming conventions ((([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$).

This module should have a docstring.

from LocalDB.query import validateLocalTableAndSchema, check_value, update_entry, check_header_index

The name query does not seem to exist in module LocalDB.

Unable to import 'LocalDB.query'

from LORIS.timepoint import findLatestTimePoint

Unable to import 'LORIS.timepoint'

from LocalDB.schema import CNBP_schema_keyfield

The name schema does not seem to exist in module LocalDB.

Unable to import 'LocalDB.schema'

Imports from package LocalDB are not grouped

def findTimePointUpdateDatabase(token, DCCID, database_path, table_name):

The name findTimePointUpdateDatabase does not conform to the function naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

The name DCCID does not conform to the argument naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    """
    Find the timepoint of the subject, IF they exist, then update the given database by finding its relevant MRN.

This line is too long as per the coding-style (113/100).

    :param token:
    :param DCCID:
    :param database_path:
    :param table_name:
    :param ColumnName:
    :param ColumnValue:
    :return:
    """

    logger = logging.getLogger('Intermediate_findTimePointUpdateDatabase')

    MRN = -1

The name MRN does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    # todo: permission must be checked to ensure we are not geting 401 error! which is an access issue.

This line is too long as per the coding-style (103/100).

    # todo: 2018-07-24 continue debug this code about entry creation.
    time_point = findLatestTimePoint(token, DCCID)

    # Timepoint Check
    if time_point is None:
        return False, "No timepoint found"
    else:
        logger.info("Timepoint retrieved okay:" + time_point)

    # Validate table and schema congruency
    success, reason = validateLocalTableAndSchema(database_path, table_name, "DCCID")
    if not success:
        return False, reason

    # Check local database for the rows with matching DCCID.
    success, subject_rows = check_value(database_path, table_name, "DCCID", DCCID)
    if not success:
        return False, "No entries with this DCCID!"

    # Recall each row WILL conform to schema.
    for row in subject_rows:

        # Get MRN:
        DCCID_table_index = check_header_index(database_path, table_name, "DCCID")

The name DCCID_table_index does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

        assert (str(DCCID) == str(row[DCCID_table_index]))

There is an unnecessary parenthesis after assert.

        # Need to update these rows with the new value.
        MRN = row[0] # the identifier of the record.

The name MRN does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

        try:
            update_entry(database_path, table_name, CNBP_schema_keyfield, MRN, "Timepoint", time_point)

This line is too long as per the coding-style (103/100).

        except IOError:
            return False, "Check the database is not read only. "

    return True, "Timepoint successfully updated in the local SQLite database."


if __name__ == '__main__':

    # Unit test
    from Integration.test_Integration import test_updateLocalTimepoint

Unable to import 'Integration.test_Integration'

    test_updateLocalTimepoint()