Python.DICOM.test_DICOM

Complexity

Total Complexity

33

Size/Duplication

Total Lines	113
Duplicated Lines	0 %

Importance

Changes

0

8 Functions

Rating	Name	Duplication	Size	Complexity
A	test_DICOM_retrieveMRN()	0	5	3
A	test_DICOM_validator()	0	9	3
A	get_test_DICOM_path()	0	3	1
A	test_DICOM_computerScanAge()	0	6	2
B	test_DICOM_update()	0	10	6
B	test_DICOM_anonymizer()	0	9	6
B	test_DICOM_RequireDecompression()	0	6	6
B	test_DICOM_decompress()	0	31	5

import os

The name test_DICOM does not conform to the module naming conventions ((([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$).

This module should have a docstring.

import sys
import logging
import unittest

from DICOM.validate import DICOM_validator

Unable to import 'DICOM.validate'

from DICOM.decompress import DICOM_RequireDecompression, DICOM_decompress

Unable to import 'DICOM.decompress'

from DICOM.anonymize import DICOM_anonymizer

Unable to import 'DICOM.anonymize'

from DICOM.elements import DICOM_retrieveElements, DICOM_updateElement, DICOM_retrieveMRN, DICOM_computeScanAge

This line is too long as per the coding-style (111/100).

Unable to import 'DICOM.elements'

from pydicom.data import get_testdata_files


logging.basicConfig(stream=sys.stdout, level=logging.INFO)

def get_test_DICOM_path():

The name get_test_DICOM_path does not conform to the function naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

This function should have a docstring.

    filename = get_testdata_files("rtplan.dcm")[0]
    return filename

def test_DICOM_decompress():

The name test_DICOM_decompress does not conform to the function naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

This function should have a docstring.

    logger = logging.getLogger(__name__)

    # Get all test files with "JPEG" in them.
    file_names = get_testdata_files("[Jj][Pp][Ee][Gg]")

    logger.info("List of files to try to decompress:")
    logger.info(file_names)

    success_counter = 0
    fail_counter = 0

    for file in file_names:
        logger.info("Processing: " + file)

        decompressed_file = file+"DECOM"

        success, reason = DICOM_decompress(file, decompressed_file)

        logger.info(reason)

        if success:
            success_counter += 1
            os.remove(decompressed_file) # restore the test environment to its former state.
            logger.info("Successful.")
        else:
            fail_counter += 1
            logger.info("Failed. Reason:" + reason)
    assert success_counter == 7 # within the test data folder, there should be SEVEN files with JPEG in their name that CAN be successfully loaded.

This line is too long as per the coding-style (147/100).

    assert fail_counter == 4 # within the test data folder, there should be FOUR files with JPEG in their name that CANNOT be successfully loaded.

This line is too long as per the coding-style (146/100).

def test_DICOM_validator():

The name test_DICOM_validator does not conform to the function naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

This function should have a docstring.

    file_name = get_test_DICOM_path()
    success, data = DICOM_validator(file_name)

The variable data seems to be unused.

    assert success

    file_name = get_testdata_files("README.txt")[0]
    success, data = DICOM_validator(file_name)
    assert not success

def test_DICOM_RequireDecompression():

The name test_DICOM_RequireDecompression does not conform to the function naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

This function should have a docstring.

    assert not (DICOM_RequireDecompression('1.2.840.10008.1.2'))

There is an unnecessary parenthesis after not.

    assert not (DICOM_RequireDecompression('1.2.840.10008.1.2.1'))

There is an unnecessary parenthesis after not.

    assert not (DICOM_RequireDecompression('1.2.840.10008.1.2.2'))

There is an unnecessary parenthesis after not.

    assert (DICOM_RequireDecompression('1.2.840.10008.1.2.4'))

There is an unnecessary parenthesis after assert.

    assert (DICOM_RequireDecompression('1.2.840.10008.1.2.4.57'))

There is an unnecessary parenthesis after assert.

class MyTestCase(unittest.TestCase):

This class should have a docstring.

The variable __class__ seems to be unused.

    def test_wrong_syntax(self):

This method should have a docstring.

        self.assertRaises(ValueError, DICOM_RequireDecompression, 'FakeTest')


def test_DICOM_anonymizer():

The name test_DICOM_anonymizer does not conform to the function naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

This function should have a docstring.

    file_names = get_testdata_files("emri")
    for file_name in file_names:
        success = DICOM_anonymizer(file_name, "CNBP0010001")
        assert success
    for file_name in file_names:
        success, value = DICOM_retrieveElements(file_name, "PatientID")
        assert success
        assert (value == "CNBP0010001")

There is an unnecessary parenthesis after assert.

def test_DICOM_retrieveMRN():

The name test_DICOM_retrieveMRN does not conform to the function naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

This function should have a docstring.

    path = get_testdata_files("emri_small_big_endian")[0]
    success, MRN = DICOM_retrieveMRN(path)

The name MRN does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    assert success
    assert (MRN == 'CNBP0010001')

There is an unnecessary parenthesis after assert.

def test_DICOM_update():

The name test_DICOM_update does not conform to the function naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

This function should have a docstring.

    path = get_testdata_files("emri")
    for file in path:
        success, _ = DICOM_updateElement(file, "PatientBirthDate", "19950101", file)
        assert success

    for file in path:
        success, value = DICOM_retrieveElements(file, "PatientBirthDate")
        assert success
        assert(value == "19950101")

There is an unnecessary parenthesis after assert.

def test_DICOM_computerScanAge():

The name test_DICOM_computerScanAge does not conform to the function naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

This function should have a docstring.

    logger = logging.getLogger("DICOM compute age")
    path = get_testdata_files("emri_small_RLE")[0]
    success, Age = DICOM_computeScanAge(path)

The name Age does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    assert success
    logger.info(Age.day)


if __name__ == '__main__':
    test_DICOM_decompress()

Final newline missing