View GitHub Repository DICOMTransit

Schedule Inspection
Subscribe
Passed
Pull Request — master (#2)
by Yang
02:09
created

test_visit_number_extraction()   A

↳ Parent: Python.LORIS.test_LORIS_timepoint

Complexity

Conditions 4

Size

Total Lines 14
Code Lines 10

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
eloc 10
dl 0
loc 14
rs 9.9
c 0
b 0
f 0
cc 4
nop 0
1 
from LORIS.timepoint import visit_number_extraction
0 ignored issues
– show
Coding Style Naming introduced by
The name test_LORIS_timepoint does not conform to the module naming conventions ((([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$).

This check looks for invalid names for a range of different identifiers.

You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements.

If your project includes a Pylint configuration file, the settings contained in that file take precedence.

To find out more about Pylint, please refer to their site.

Loading history...
Coding Style introduced by
This module should have a docstring.

The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods:

class SomeClass:
    def some_method(self):
        """Do x and return foo."""

If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions.

Loading history...
introduced by
Unable to import 'LORIS.timepoint'
Loading history...
2 

            


            
                                                        
            
                                    
            
            

                
                    3
                

                                    
                                                    
                
                
                
def test_visit_number_extraction():

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Coding Style
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
This function should have a docstring.
                                                                                                

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
The coding style of this project requires that you add a docstring to this
code element. Below, you find an example for methods:


class SomeClass:
    def some_method(self):
        """Do x and return foo."""





If you would like to know more about docstrings, we recommend to
read PEP-257: Docstring Conventions.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                
    Prefix = "V"

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Coding Style
            Naming
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
The name Prefix does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).
                                                                                                                                                                                                        

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
This check looks for invalid names for a range of different identifiers.


You can set regular expressions to which the identifiers must conform if the
defaults do not match your requirements.


If your project includes a Pylint configuration file, the settings contained in
that file take precedence.


To find out more about Pylint, please refer to their site.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    5
                

                                    
                                                    
                
                
                
    numbers = [1, 2, 3, 9]

            


            
                                                        
            
                                    
            
            

                
                    6
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    7
                

                                    
                                                    
                
                
                
    global timepoints

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                                                                        
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                        

                                        
Global variable 'timepoints' undefined at the module level
                                                                                                

                    
                                                    

                     Loading history...
                

                    


    




                                                                                            




    

        
            Coding Style
            Naming
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
The name timepoints does not conform to the constant naming conventions ((([A-Z_][A-Z0-9_]*)|(__.*__))$).
                                                                                                                                                                                                        

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
This check looks for invalid names for a range of different identifiers.


You can set regular expressions to which the identifiers must conform if the
defaults do not match your requirements.


If your project includes a Pylint configuration file, the settings contained in
that file take precedence.


To find out more about Pylint, please refer to their site.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
    timepoints = []

            


            
                                                        
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                
    for number in numbers:

            


            
                                                        
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                
        timepoints.append(Prefix + str(number))

            


            
                                                        
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                
    DualList = zip(numbers, timepoints)

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Coding Style
            Naming
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
The name DualList does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).
                                                                                                                                                                                                        

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
This check looks for invalid names for a range of different identifiers.


You can set regular expressions to which the identifiers must conform if the
defaults do not match your requirements.


If your project includes a Pylint configuration file, the settings contained in
that file take precedence.


To find out more about Pylint, please refer to their site.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                
    for tuple in DualList:

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
            Best Practice
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
This seems to re-define the built-in tuple.
                                                                                                

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
It is generally discouraged to redefine built-ins as this makes code very hard to read.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                
        assert str(tuple[0]) == visit_number_extraction(tuple[1])[0]

            


            
                                                        
            
                                    
            
            

                
                    17
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    18
                

                                    
                                                    
                
                
                
    # todo: 10+ visit number WILL FAIL!

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Coding Style
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                        

                                        
Final newline missing
                                            

                    
                                                    

                     Loading history...