MessageHandler::handleMessage() - Code Metrics - Inspection of "Added Cmp\Queues namespace" - CMProductions/queues - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5fca0d...2a987b )

by Quim

created 2017-02-21 12:27 UTC

MessageHandler::handleMessage() A

↳ Parent: MessageHandler

Complexity

Conditions	2
Paths	4

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	4
nop	1

<?php
/**
 * Created by PhpStorm.
 * User: quimmanrique
 * Date: 13/02/17
 * Time: 19:13
 */

namespace Cmp\Queues\Infrastructure\AmqpLib\v26\RabbitMQ\Queue;

use Cmp\Queues\Domain\Queue\JSONMessageFactory;
use PhpAmqpLib\Message\AMQPMessage;
use Psr\Log\LoggerInterface;

class MessageHandler
{
    /**
     * @var JSONMessageFactory
     */
    private $jsonMessageFactory;

    /**
     * @var callable
     */
    private $callback;

    /**
     * MessageHandler constructor.
     * @param JSONMessageFactory $jsonMessageFactory
     */
    public function __construct(JSONMessageFactory $jsonMessageFactory)
    {
        $this->jsonMessageFactory = $jsonMessageFactory;
    }

    /**
     * @param AMQPMessage $message
     * @throws \Exception
     */
    public function handleMessage(AMQPMessage $message)
    {
        try {
            $task = $this->jsonMessageFactory->create($message->body);
            call_user_func_array($this->callback, [$task]);
            $message->delivery_info['channel']->basic_ack($message->delivery_info['delivery_tag']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        } catch (\Exception $e) {
            throw $e;
        }
    }

    public function setCallback(callable $callback)
    {
        $this->callback = $callback;
    }
}

1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: quimmanrique
5			* Date: 13/02/17
6			* Time: 19:13
7			*/
8
9			namespace Cmp\Queues\Infrastructure\AmqpLib\v26\RabbitMQ\Queue;
10
11			use Cmp\Queues\Domain\Queue\JSONMessageFactory;
12			use PhpAmqpLib\Message\AMQPMessage;
13			use Psr\Log\LoggerInterface;
14
15			class MessageHandler
16			{
17			/**
18			* @var JSONMessageFactory
19			*/
20			private $jsonMessageFactory;
21
22			/**
23			* @var callable
24			*/
25			private $callback;
26
27			/**
28			* MessageHandler constructor.
29			* @param JSONMessageFactory $jsonMessageFactory
30			*/
31			public function __construct(JSONMessageFactory $jsonMessageFactory)
32			{
33			$this->jsonMessageFactory = $jsonMessageFactory;
34			}
35
36			/**
37			* @param AMQPMessage $message
38			* @throws \Exception
39			*/
40			public function handleMessage(AMQPMessage $message)
41			{
42			try {
43			$task = $this->jsonMessageFactory->create($message->body);
44			call_user_func_array($this->callback, [$task]);
45			$message->delivery_info['channel']->basic_ack($message->delivery_info['delivery_tag']);
			0 ignored issues – show Documentation introduced 2017-02-21 12:29 UTC by Report Bug Copy Issue Report `$message->delivery_info['delivery_tag']` is of type `object<PhpAmqpLib\Channel\AMQPChannel>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
46			} catch (\Exception $e) {
47			throw $e;
48			}
49			}
50
51			public function setCallback(callable $callback)
52			{
53			$this->callback = $callback;
54			}
55			}

CMProductions / queues

Push — master ( 5fca0d...2a987b )

MessageHandler::handleMessage() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like