Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
6 | View Code Duplication | class FeatureContext implements SnippetAcceptingContext |
|
|
|||
7 | { |
||
8 | /** |
||
9 | * @var \Redis |
||
10 | */ |
||
11 | private $redis; |
||
12 | |||
13 | /** |
||
14 | * @var RedisCache |
||
15 | */ |
||
16 | private $backend; |
||
17 | |||
18 | /** |
||
19 | * @var string |
||
20 | */ |
||
21 | private $result; |
||
22 | |||
23 | /** |
||
24 | * FeatureContext constructor. |
||
25 | */ |
||
26 | public function __construct() |
||
32 | |||
33 | /** |
||
34 | * @BeforeScenario |
||
35 | */ |
||
36 | public function reset() |
||
40 | |||
41 | /** |
||
42 | * @Given The cache is empty |
||
43 | */ |
||
44 | public function theCacheIsEmpty() |
||
48 | |||
49 | /** |
||
50 | * @Given I store a an item in the cache |
||
51 | */ |
||
52 | public function iStoreAAnItemInTheCache() |
||
56 | |||
57 | /** |
||
58 | * @When I retrieve it |
||
59 | */ |
||
60 | public function whenIRetrieved() |
||
64 | |||
65 | /** |
||
66 | * @Then I should get the same item |
||
67 | */ |
||
68 | public function iShouldGetTheSameItem() |
||
74 | |||
75 | /** |
||
76 | * @param $timeToLive |
||
77 | * |
||
78 | * @Given I store a an item in the cache for :timeToLive second |
||
79 | */ |
||
80 | public function iStoreAAnItemInTheCacheForSecond($timeToLive) |
||
84 | |||
85 | /** |
||
86 | * @param $seconds |
||
87 | * |
||
88 | * @When I wait :seconds seconds |
||
89 | */ |
||
90 | public function iWaitSeconds($seconds) |
||
94 | |||
95 | /** |
||
96 | * @Then I should not be able to retrieve it |
||
97 | */ |
||
98 | public function iShouldNotBeAbleToRetrieveIt() |
||
104 | |||
105 | /** |
||
106 | * @When I delete the item from the cache |
||
107 | */ |
||
108 | public function iDeleteTheItemFromTheCache() |
||
112 | |||
113 | /** |
||
114 | * @When I flush all the items item from the cache |
||
115 | */ |
||
116 | public function iFlushAllTheItemsItemFromTheCache() |
||
120 | |||
121 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.