Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php namespace RayEmitter\Example\BankAccount; |
||
5 | View Code Duplication | final class DepositMoney extends Command |
|
|
|||
6 | { |
||
7 | /** |
||
8 | * Constructor |
||
9 | * |
||
10 | * @param string $account_id Account identifier. |
||
11 | * @param array $data Payload data. |
||
12 | * @param int $sequence Expected version sequence. |
||
13 | */ |
||
14 | public function __construct($account_id, array $data, $sequence = 0) |
||
21 | |||
22 | /** |
||
23 | * Run |
||
24 | * |
||
25 | * Push the command into the Aggregate. |
||
26 | * @return void |
||
27 | */ |
||
28 | public function run() |
||
32 | } |
||
33 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.