C4tech\RayEmitter\Example\BankAccount\Aggregate

Complexity

Total Complexity

10

Size/Duplication

Total Lines	119
Duplicated Lines	11.76 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	applyAccountWasCreated()	0	8	1
A	applyMoneyDeposited()	7	7	1
A	applyMoneyWithdrawn()	7	7	1
A	handleCreateAccount()	0	14	2
A	handleDepositMoney()	0	13	2
A	handleWithdrawMoney()	0	17	3

<?php namespace C4tech\RayEmitter\Example\BankAccount;

use C4tech\RayEmitter\Domain\Aggregate as AbstractAggregate;

final class Aggregate extends AbstractAggregate
{
    /**
     * Minimum needed to open an account.
     * @var int|float
     */
    const MINIMUM_TO_OPEN = 50;

    /**
     * Account Was Created Event Handle
     *
     * @param  AccountWasCreated $event Event Object
     * @return void
     */
    protected function applyAccountWasCreated(AccountWasCreated $event)
    {
        $data = $event->getPayload();
        $identifier = new AccountId($event->getId());
        $this->root = new AggregateRoot($identifier);

It seems like new \C4tech\RayEmitter\Example\BankAccount\AggregateRoot($identifier) of type object<C4tech\RayEmitter\Example\BankAccount\AggregateRoot> is incompatible with the declared type object<C4tech\RayEmitter\Domain\AggregateRootInterface> of property $root.

        $this->root->owner = $data->owner;

The property $owner is declared private in C4tech\RayEmitter\Example\BankAccount\AggregateRoot. Since you implemented __set(), maybe consider adding a @property or @property-write annotation. This makes it easier for IDEs to provide auto-completion.

        $this->root->balance = $data->deposit;

The property $balance is declared private in C4tech\RayEmitter\Example\BankAccount\AggregateRoot. Since you implemented __set(), maybe consider adding a @property or @property-write annotation. This makes it easier for IDEs to provide auto-completion.

    }

    /**
     * Money Deposited Event Handle
     *
     * @param  MoneyDeposited $event Event Object
     * @return void
     */
    protected function applyMoneyDeposited(MoneyDeposited $event)

This method seems to be duplicated in your project.

    {
        $data = $event->getPayload();
        $balance = $this->root->balance->getValue();
        $balance += $data->deposit->getValue();
        $this->root->balance = new UsDollar($balance);
    }

    /**
     * Money Withdrawn Event Handle
     *
     * @param  MoneyWithdrawn $event Event Object
     * @return void
     */
    protected function applyMoneyWithdrawn(MoneyWithdrawn $event)

This method seems to be duplicated in your project.

    {
        $data = $event->getPayload();
        $balance = $this->root->balance->getValue();
        $balance -= $data->withdrawal->getValue();
        $this->root->balance = new UsDollar($balance);
    }

    /**
     * Create Account Command Handle
     *
     * Processes business logic for the account creation command.
     * @param  CreateAccount $command Command object.
     * @return AccountWasCreated      Event object.
     */
    protected function handleCreateAccount(CreateAccount $command)
    {
        $data = $command->getPayload();

        $account_id = new AccountId(generateUuid());
        $owner = new OwnerName($data->owner);
        $initial_deposit = new UsDollar($data->deposit);

        if ($initial_deposit->getValue() < self::MINIMUM_TO_OPEN) {
            throw new MinimumDepositException($initial_deposit->getValue(), self::MINIMUM_TO_OPEN);
        }

        return new AccountWasCreated($account_id, compact('owner', 'initial_deposit'));
    }

    /**
     * Deposit Money Command Handle
     *
     * Processes business logic for the deposit money command.
     * @param  DepositMoney $command Command object.
     * @return MoneyDeposited        Event object.
     */
    protected function handleDepositMoney(DepositMoney $command)
    {
        $data = $command->getPayload();

        $account_id = new AccountId($data->account_id);
        $deposit = new UsDollar($data->deposit);

        if ($deposit->getValue() < 0) {
            throw new MinimumDepositException($deposit->getValue());
        }

        return new MoneyDeposited($account_id, compact('deposit'));
    }

    /**
     * Withdraw Money Command Handle
     *
     * Processes business logic for the withdraw money command.
     * @param  WithdrawMoney $command Command object.
     * @return MoneyWithdrawn         Event object.
     */
    protected function handleWithdrawMoney(WithdrawMoney $command)
    {
        $data = $command->getPayload();

        $account_id = new AccountId($data->account_id);
        $withdrawal = new UsDollar($data->withdrawal);

        if ($withdrawal->getValue() < 0) {
            throw new MinimumWithdrawalException($withdrawal->getValue());
        }

        if ($withdrawal->getValue() > $this->root->balance->getValue()) {
            throw new InsufficientFundsException($withdrawal->getValue(), $this->balance->getValue());

The property balance does not exist on object<C4tech\RayEmitter\Example\BankAccount\Aggregate>. Since you implemented __get, maybe consider adding a @property annotation.

        }

        return new MoneyWithdrawn($account_id, compact('withdrawal'));
    }
}