ClicknLoadController::addcrypted2Action() - Code Metrics - Inspection of "Add click'n load support" - C-Sparrow/Tartana - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 32a2ee...06a7c6 )

by C

created 2017-08-07 15:38 UTC

ClicknLoadController::addcrypted2Action() B

↳ Parent: ClicknLoadController

Complexity

Conditions	6
Paths	4

Size

Total Lines	53
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	53
rs	8.7155
c	0
b	0
f	0
cc	6
eloc	30
nc	4
nop	1

How to fix Long Method

<?php
namespace Tartana\Controller;

use League\Flysystem\Adapter\Local;
use League\Flysystem\Config;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Tartana\Util;

class ClicknLoadController extends Controller
{

	/**
	 * @Route("/flash/addcrypted2", name="clicknload")
	 */
	public function addcrypted2Action(Request $request)
	{
		$data = array(
			'success' => false,
			'message' => $this->get('Translator')->trans('TARTANA_CLICKNLOAD_ERROR_ADDING_TO_QUEUE')
		);

		preg_match('/\'(.*?)\'/', $request->get('jk'), $matches);

		if (count($matches) < 1) {
			return;
		}

		$key = hex2bin($matches[1]);

		$cp = mcrypt_module_open(MCRYPT_RIJNDAEL_128, '', 'cbc', '');
		@mcrypt_generic_init($cp, $key, $key);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
		$dec = mdecrypt_generic($cp, base64_decode($request->get('crypted')));
		mcrypt_generic_deinit($cp);
		mcrypt_module_close($cp);

		$folder = $this->container->getParameter('tartana.config')['links']['folder'];
		$folder = Util::realPath($folder);

		if (!empty($folder)) {
			$fs = new Local($folder);

			$name = $request->get('package', rand(0, 1000)) . '.txt';

			// Sanitize content
			$content = '';
			foreach (preg_split('/\r\n|\r|\n/', $dec) as $file) {
				if (strpos($file, 'http://') !== 0) {
					continue;
				}

				$content .= $file . PHP_EOL;
			}

			$content = trim($content);

			if ($content) {
				$fs->write($name, $content, new Config());

				$data = array(
					'success' => true,
					'message' => $this->get('Translator')->trans('TARTANA_CLICKNLOAD_CONTENT_ADDED_TO_QUEUE')
				);
			}
		}

		return new JsonResponse($data);
	}
}


1			<?php
2			namespace Tartana\Controller;
3
4			use League\Flysystem\Adapter\Local;
5			use League\Flysystem\Config;
6			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
7			use Symfony\Bundle\FrameworkBundle\Controller\Controller;
8			use Symfony\Component\HttpFoundation\JsonResponse;
9			use Symfony\Component\HttpFoundation\Request;
10			use Tartana\Util;
11
12			class ClicknLoadController extends Controller
13			{
14
15			/**
16			* @Route("/flash/addcrypted2", name="clicknload")
17			*/
18			public function addcrypted2Action(Request $request)
19			{
20			$data = array(
21			'success' => false,
22			'message' => $this->get('Translator')->trans('TARTANA_CLICKNLOAD_ERROR_ADDING_TO_QUEUE')
23			);
24
25			preg_match('/\'(.*?)\'/', $request->get('jk'), $matches);
26
27			if (count($matches) < 1) {
28			return;
29			}
30
31			$key = hex2bin($matches[1]);
32
33			$cp = mcrypt_module_open(MCRYPT_RIJNDAEL_128, '', 'cbc', '');
34			@mcrypt_generic_init($cp, $key, $key);
			0 ignored issues – show Security Best Practice introduced 2017-08-07 15:52 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
35			$dec = mdecrypt_generic($cp, base64_decode($request->get('crypted')));
36			mcrypt_generic_deinit($cp);
37			mcrypt_module_close($cp);
38
39			$folder = $this->container->getParameter('tartana.config')['links']['folder'];
40			$folder = Util::realPath($folder);
41
42			if (!empty($folder)) {
43			$fs = new Local($folder);
44
45			$name = $request->get('package', rand(0, 1000)) . '.txt';
46
47			// Sanitize content
48			$content = '';
49			foreach (preg_split('/\r\n\|\r\|\n/', $dec) as $file) {
50			if (strpos($file, 'http://') !== 0) {
51			continue;
52			}
53
54			$content .= $file . PHP_EOL;
55			}
56
57			$content = trim($content);
58
59			if ($content) {
60			$fs->write($name, $content, new Config());
61
62			$data = array(
63			'success' => true,
64			'message' => $this->get('Translator')->trans('TARTANA_CLICKNLOAD_CONTENT_ADDED_TO_QUEUE')
65			);
66			}
67			}
68
69			return new JsonResponse($data);
70			}
71			}
72

C-Sparrow / Tartana

Push — master ( 32a2ee...06a7c6 )

ClicknLoadController::addcrypted2Action() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like