ByTIC / payments

src/Models/PurchaseSessions/PurchaseSessionsTrait.php

<?php

namespace ByTIC\Payments\Models\PurchaseSessions;

use ByTIC\Payments\Actions\GatewayNotifications\CreateSessionFromResponse;
use ByTIC\Payments\Gateways\Providers\AbstractGateway\Message\Traits\CompletePurchaseResponseTrait;
use ByTIC\Payments\Models\Purchase\Traits\IsPurchasableModelTrait;
use ByTIC\Payments\Models\PurchaseSessions\Traits\Cleanup\RecordsTrait as CleanupRecordsTrait;
use ByTIC\Payments\Utility\PaymentsModels;
use Omnipay\Common\Message\ResponseInterface;

/**
 * Trait PurchaseSessionsTrait
 * @package ByTIC\Payments\Models\PurchaseSessions
 *
 * @method PurchaseSessionTrait getNew
 */
trait PurchaseSessionsTrait
{
    use CleanupRecordsTrait;

    /**
     * @param string $type
     * @param CompletePurchaseResponseTrait|ResponseInterface $response
     * @return PurchaseSessionTrait
     */
    public function createFromResponse($response, $type)
    {
        return CreateSessionFromResponse::handle($response, $response->getModel(), $type);

The expression return ByTIC\Payments\Actions\GatewayNotifications\CreateSessionFromResponse::handle($response, $response->getModel(), $type) also could return the type Nip\Records\AbstractModels\RecordManager|Nip\Records\Collections\Collection|true which is incompatible with the documented return type ByTIC\Payments\Models\PurchaseSessions\PurchaseSessionTrait.

The method getModel() does not exist on Omnipay\Common\Message\ResponseInterface. Did you maybe mean getCode()?

The call to ByTIC\Payments\Actions\GatewayNotifications\CreateSessionFromResponse::handle() has too many arguments starting with $response->getModel().

$response of type ByTIC\Payments\Gateways\Providers\AbstractGateway\Message\Traits\CompletePurchaseResponseTrait|Omnipay\Common\Message\ResponseInterface is incompatible with the type ByTIC\Payments\Actions\GatewayNotifications\NotificationData expected by parameter $notification of ByTIC\Payments\Actions\GatewayNotifications\CreateSessionFromResponse::handle().

    }

    /**
     * @param string $type
     * @param IsPurchasableModelTrait $payment
     * @return PurchaseSessionTrait
     */
    public function createFromPurchase($payment, $type)
    {
        $session = $this->generateFromPurchaseType($payment, $type);
        $session->insert();

It seems like insert() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $session;
    }

    /**
     * @param $params
     * @return mixed
     */
    public static function decodeParams($params)
    {
        if (empty($params)) {
            return $params;
        }
        return unserialize(gzuncompress(base64_decode($params)));
    }

    public static function encodeParams($params)
    {
        return base64_encode(gzcompress(serialize($params)));
    }

    protected function initRelations()
    {
        parent::initRelations();
    }

    protected function initRelationsCommon()
    {
        $this->initRelationsPurchase();
    }

    protected function initRelationsPurchase()
    {
        $this->belongsTo('Purchase', ['class' => get_class(PaymentsModels::purchases())]);

It seems like belongsTo() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param array $params
     */
    protected function injectParams(&$params = [])
    {
        $params['order'][] = ['created', 'desc'];

        parent::injectParams($params);
    }

    /**
     * @param IsPurchasableModelTrait $payment
     * @param string $type
     * @return PurchaseSessionTrait
     */
    public function generateFromPurchaseType($payment, $type)
    {
        $session = $this->generateFromPurchase($payment);
        $session->type = $type;
        return $session;
    }

    /**
     * @param IsPurchasableModelTrait $payment
     * @return PurchaseSessionTrait
     */
    protected function generateFromPurchase($payment)
    {
        $session = $this->getNew();
        $session->populateFromPayment($payment);
        $session->populateFromGateway($payment->getPaymentMethod()->getType()->getGateway());
        $session->populateFromRequest();

        return $session;
    }

    /**
     * @return mixed|\Nip\Config\Config
     * @throws \Exception
     */
    protected function generateTable()
    {
        return config('payments.tables.purchases_sessions', 'purchases_sessions');
    }
}