ByTIC / payments

src/Controllers/Traits/AdminPaymentMethodsTrait.php

<?php

namespace ByTIC\Payments\Controllers\Traits;

use ByTIC\Payments\Models\Methods\Traits\RecordsTrait;
use ByTIC\Payments\Models\Methods\Traits\RecordTrait;
use Nip\Records\AbstractModels\Record;
use Nip\Records\AbstractModels\RecordManager;
use Symfony\Component\HttpFoundation\Request;

/**
 * Class AdminPaymentMethodsTrait
 * @package ByTIC\Payments\Payments\Controllers\Traits
 */
trait AdminPaymentMethodsTrait
{
    public function deleteFile()
    {
        $item = $this->getModelFromRequest();
        $fileName = $this->getRequest()->get('file');

        $type = 'error';
        $message = $this->getModelManager()->getMessage('deleteFile.error');

The assignment to $message is dead and can be removed.

        if ($fileName) {
            $files = $item->getFiles();
            if ($files[$fileName]) {
                $files[$fileName]->delete();
                $type = 'success';
                $message = $this->getModelManager()->getMessage('deleteFile.success');
            } else {
                $message = $this->getModelManager()->getMessage('deleteFile.no-file');
            }
        } else {
            $message = $this->getModelManager()->getMessage('deleteFile.no-filename');
        }
        $this->flashRedirect($message, $item->compileURL('view'), $type);

It seems like compileURL() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param bool $key
     * @return Record|RecordTrait
     */
    abstract protected function getModelFromRequest($key = false);

    /**
     * @return Request
     */
    abstract protected function getRequest();

    /**
     * @return RecordManager|RecordsTrait
     */
    abstract protected function getModelManager();

    /**
     * @param $message
     * @param $url
     * @param string $type
     * @param bool $name
     * @return mixed
     */
    abstract protected function flashRedirect($message, $url, $type = 'success', $name = false);

    public function delete()
    {
        $item = $this->getModelFromRequest();

        $deleteMessage = $item->canDelete();
        if ($deleteMessage !== true) {
            $url = $item->getURL();

It seems like getURL() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $this->_flashName = $this->getModelManager()->getController();

The property _flashName does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            $this->flashRedirect($deleteMessage, $url, 'error', $this->_flashName);

$this->_flashName of type string is incompatible with the type boolean expected by parameter $name of ByTIC\Payments\Controllers\Traits\AdminPaymentMethodsTrait::flashRedirect().

        }

        parent::delete();
    }
}