ByTIC / payments

src/Actions/GatewayNotifications/CreateOrUpdateTokenFromResponse.php

<?php

namespace ByTIC\Payments\Actions\GatewayNotifications;

use ByTIC\Payments\Models\Transactions\TransactionTrait;
use ByTIC\Payments\Utility\PaymentsModels;
use Nip\Records\AbstractModels\Record;
use Paytic\Omnipay\Common\Models\TokenInterface;

/**
 * Class CreateOrUpdateTokenFromResponse
 * @package ByTIC\Payments\Actions\GatewayNotifications
 * @internal
 */
class CreateOrUpdateTokenFromResponse
{
    /**
     * @param NotificationData $notification
     * @return TransactionTrait|Record
     */
    public static function handle(NotificationData $notification)
    {
        if (!method_exists($notification->response, 'getToken')) {
            return null;
        }

        $token = $notification->response->getToken();
        if (!($token instanceof TokenInterface)) {
            return null;
        }

        if (empty($token->getId())) {
            return null;
        }

        $notification->token = PaymentsModels::tokens()
            ->findOrCreateForMethod($notification->purchase->getPaymentMethod(), $token);
        $notification->token->populateFromCustomer($notification->purchase->getPurchaseBillingRecord());

Are you sure the usage of $notification->purchase->getPurchaseBillingRecord() targeting ByTIC\Payments\Models\Purchase\Traits\IsPurchasableModelTrait::getPurchaseBillingRecord() seems to always return null.

        $notification->token->update();

The method update() does not exist on ByTIC\Payments\Models\Tokens\TokenTrait. Did you maybe mean updatedTimestamps()?

        return $notification->token;

The expression return $notification->token also could return the type ByTIC\Payments\Models\Tokens\TokenTrait which is incompatible with the documented return type ByTIC\Payments\Models\Transactions\TransactionTrait|Nip\Records\AbstractModels\Record.

    }
}