ByTIC\Payments\Actions\GatewayNotifications\CreateOrUpdateTransactionFromResponse

Complexity

Total Complexity

4

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	handle()	0	5	1
A	updateTransaction()	0	13	3

<?php

namespace ByTIC\Payments\Actions\GatewayNotifications;

use ByTIC\Omnipay\Librapay\Message\ServerCompletePurchaseResponse;
use ByTIC\Payments\Utility\PaymentsModels;
use Omnipay\Common\Message\AbstractResponse;

/**
 * Class CreateOrUpdateTransactionFromResponse
 * @package ByTIC\Payments\Actions\GatewayNotifications
 */
class CreateOrUpdateTransactionFromResponse
{
    /**
     * @param $response
     * @param $model
     * @param $type
     * @return \ByTIC\Payments\Models\Transactions\TransactionTrait|\Nip\Records\AbstractModels\Record
     */
    public static function handle($response, $model, $type)

The parameter $type is not used and could be removed.

    {
        $transaction = PaymentsModels::transactions()->findOrCreateForPurchase($model);
        static::updateTransaction($response, $transaction);
        return $transaction;
    }


    /**
     * @param AbstractResponse|ServerCompletePurchaseResponse $response
     * @param $transaction
     */
    protected static function updateTransaction(AbstractResponse $response, $transaction)
    {
        $code = $response->getCode();

Are you sure the assignment to $code is correct as $response->getCode() targeting Omnipay\Common\Message\AbstractResponse::getCode() seems to always return null.

        if ($code) {

$code is of type null, thus it always evaluated to false.

            $transaction->code = $code;
        }

        $reference = $response->getTransactionReference();

Are you sure the assignment to $reference is correct as $response->getTransactionReference() targeting Omnipay\Common\Message\AbstractResponse::getTransactionReference() seems to always return null.

        if ($reference) {

$reference is of type null, thus it always evaluated to false.

            $transaction->reference = $reference;
        }

        $transaction->update();
    }
}