ByTIC\Payments\Gateways\Providers\AbstractGateway\Traits\MagicMessagesTrait

Complexity

Total Complexity

11

Size/Duplication

Total Lines	80
Duplicated Lines	0 %

Test Coverage

Coverage

69.23%

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__call()	0	7	2
A	createRequestWithInternalCheck()	0	12	3
A	getRequestClass()	0	8	2
A	createNamespacedRequest()	0	12	3
A	createNamepacedRequest()	0	3	1

<?php

namespace ByTIC\Payments\Gateways\Providers\AbstractGateway\Traits;

use BadMethodCallException;
use Omnipay\Common\Message\RequestInterface;
use Omnipay\Common\Message\ResponseInterface as MessageResponseInterface;

/**
 * Trait MagicMessagesTrait
 * @package ByTIC\Payments\Gateways\Providers\AbstractGateway\Traits
 *
 * @method MessageResponseInterface authorize(array $options = [])
 * @method MessageResponseInterface completeAuthorize(array $options = [])
 * @method MessageResponseInterface capture(array $options = [])
 * @method MessageResponseInterface refund(array $options = [])
 * @method MessageResponseInterface void(array $options = [])
 * @method MessageResponseInterface createCard(array $options = [])
 * @method MessageResponseInterface updateCard(array $options = [])
 * @method MessageResponseInterface deleteCard(array $options = [])
 */
trait MagicMessagesTrait
{
    protected $requestsMethods = ['purchase', 'completePurchase', 'serverCompletePurchase'];

    /**
     * @param $name
     * @param $arguments
     * @return RequestInterface
     */
    public function __call($name, $arguments)
    {
        if (in_array($name, $this->requestsMethods)) {
            $name = ucfirst($name) . 'Request';
            return $this->createNamespacedRequest($name, $arguments);
        }
        throw new BadMethodCallException("Invalid method $name");
    }

    // ------------ REQUESTS OVERLOADING ------------ //
    /**
     * @param $request
     * @param array $parameters
     * @return null|RequestInterface
     */
    protected function createRequestWithInternalCheck($request, array $parameters = [])
    {
        $return = $this->createNamespacedRequest($request, $parameters);
        if ($return) {
            return $return;
        }
        if (!method_exists($this, $request)) {
            return null;
        }
        /** @noinspection PhpUndefinedMethodInspection */
        /** @noinspection PhpUndefinedClassInspection */
        return parent::{$request}($parameters);
    }

    /**
     * @param $class
     * @param array $parameters
     * @return RequestInterface|null
     */
    protected function createNamespacedRequest($class, array $parameters)
    {
        if (strpos($class, 'Request') === false) {
            $class .= 'Request';
        }
        $class = $this->getRequestClass($class);

        if (class_exists($class)) {
            return $this->createRequest($class, $parameters);

The method createRequest() does not exist on ByTIC\Payments\Gateways\Providers\AbstractGateway\Traits\MagicMessagesTrait. Since you implemented __call, consider adding a @method annotation.

        }

        return null;
    }

    /**
     * @param $class
     * @param array $parameters
     * @return RequestInterface|null
     * @deprecated Bad name
     */
    protected function createNamepacedRequest($class, array $parameters)
    {
        return $this->createNamespacedRequest($class, $parameters);

Are you sure the usage of $this->createNamespacedRequest($class, $parameters) targeting ByTIC\Payments\Gateways\Providers\AbstractGateway\Traits\MagicMessagesTrait::createNamespacedRequest() seems to always return null.

    }

    /**
     * @param $class
     * @return string
     */
    protected function getRequestClass($class)
    {
        $class = $this->getNamespacePath() . '\Message\\' . ucfirst($class);

The method getNamespacePath() does not exist on ByTIC\Payments\Gateways\Providers\AbstractGateway\Traits\MagicMessagesTrait. Since you implemented __call, consider adding a @method annotation.

Are you sure $this->getNamespacePath() of type Omnipay\Common\Message\RequestInterface can be used in concatenation? Consider adding a __toString()-method.

        if (class_exists($class)) {
            return $class;
        }
        return str_replace('ByTIC\Payments', 'ByTIC\Common\Payments', $class);
    }
}