ByTIC\Payments\Tests\Actions\Subscriptions\Charges\CalculateNextChargeTest

Complexity

Total Complexity

2

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	test_for()	0	8	1
A	data_for()	0	37	1

<?php

namespace ByTIC\Payments\Tests\Actions\Subscriptions\Charges;

use ByTIC\Payments\Actions\Subscriptions\Charges\CalculateNextCharge;
use ByTIC\Payments\Models\Subscriptions\Subscription;
use ByTIC\Payments\Subscriptions\Billing\BillingPeriod;

/**
 * Class CalculateNextChargeTest
 * @package ByTIC\Payments\Tests\Actions\Subscriptions\Charges
 */
class CalculateNextChargeTest extends \ByTIC\Payments\Tests\AbstractTestCase
{
    /**
     * @dataProvider data_for
     */
    public function test_for($data, $result)
    {
        $subscription = new Subscription();
        $subscription->fill($data);

        CalculateNextCharge::for($subscription);

        self::assertEquals($result, substr($subscription->getPropertyRaw('charge_at'), 0, 10));

It seems like $subscription->getPropertyRaw('charge_at') can also be of type null; however, parameter $string of substr() does only seem to accept string, maybe add an additional type check?

    }

    public function data_for(): array
    {
        return [
            [
                [
                    'start_at' => '2020-01-01',
                    'charge_at' => '',
                    'billing_period' => BillingPeriod::DAILY,
                    'billing_interval' => 1
                ],
                '2020-01-02',
            ],
            [
                [
                    'start_at' => '2020-01-01',
                    'charge_at' => '2020-02-01',
                    'billing_period' => BillingPeriod::DAILY,
                    'billing_interval' => 1
                ],
                '2020-02-02',
            ],
            [
                [
                    'start_at' => '2020-01-01',
                    'billing_period' => BillingPeriod::MONTHLY,
                    'billing_interval' => 1
                ],
                '2020-02-01',
            ],
            [
                [
                    'start_at' => '2020-01-01',
                    'charge_at' => '',
                    'billing_period' => BillingPeriod::WEEKLY,
                    'billing_interval' => 1
                ],
                '2020-01-08',
            ]
        ];
    }
}