ByTIC\Payments\Actions\Subscriptions\Charges\CalculateNextCharge

Complexity

Total Complexity

9

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	for()	0	6	1
A	determineStartDate()	0	7	3
A	nextBillingDate()	0	17	5

<?php

namespace ByTIC\Payments\Actions\Subscriptions\Charges;

use ByTIC\Payments\Models\Subscriptions\Subscription;
use ByTIC\Payments\Subscriptions\Billing\BillingPeriod;
use Nip\Utility\Date;

/**
 * Class CalculateNextCharge
 * @package ByTIC\Payments\Actions\Subscriptions\Charges
 */
class CalculateNextCharge
{
    /**
     * @param Subscription $subscription
     */
    public static function for($subscription)
    {
        $subscription->charge_at = static::nextBillingDate(
            static::determineStartDate($subscription),
            $subscription->billing_period,
            $subscription->billing_interval
        );
    }

    /**
     * @param Subscription $subscription
     * @return \DateTime
     */
    protected static function determineStartDate(Subscription $subscription): \DateTime
    {
        $chargeAt = $subscription->charge_at;
        if ($chargeAt instanceof \DateTime && $chargeAt->year > 0) {
            return $chargeAt;
        }
        return $subscription->start_at;

The expression return $subscription->start_at could return the type string which is incompatible with the type-hinted return DateTime. Consider adding an additional type-check to rule them out.

    }

    /**
     * @param \DateTime $startDate
     * @param $period
     * @param $interval
     */
    protected static function nextBillingDate(\DateTime $startDate, $period, $interval)
    {
        $startDate = Date::instance($startDate);
        switch ($period) {
            case BillingPeriod::DAILY:
                return $startDate->addDays($interval);

            case BillingPeriod::WEEKLY:
                return $startDate->addWeeks($interval);

            case BillingPeriod::MONTHLY:
                return $startDate->addMonths($interval);

            case BillingPeriod::YEARLY:
                return $startDate->addYears($interval);
        }
        throw new \InvalidArgumentException("Invalid period [{$period}] provided.");
    }
}