ByTIC\Payments\Gateways\Providers\AbstractGateway\Message\Traits\HasModelProcessedResponse

Complexity

Total Complexity

19

Size/Duplication

Total Lines	92
Duplicated Lines	0 %

Test Coverage

Coverage

28.21%

Importance

Changes	1
Bugs	0	Features	1

8 Methods

Rating	Name	Duplication	Size	Complexity
A	processModelStatus()	0	13	6
A	canProcessModel()	0	3	1
A	getModel()	0	3	1
A	processModel()	0	8	2
A	hasModel()	0	3	1
A	processModelData()	0	2	1
A	getTransactionDate()	0	6	2
A	getModelResponseStatus()	0	16	5

<?php

namespace ByTIC\Payments\Gateways\Providers\AbstractGateway\Message\Traits;

use ByTIC\Common\Payments\Models\Purchase\Traits\IsPurchasableModelTrait;
use ByTIC\Common\Records\Traits\HasStatus\RecordTrait;
use Nip\Records\Record;

/**
 * Class HasView
 * @package ByTIC\Payments\Gateways\Providers\AbstractGateway\Message\Traits
 *
 */
trait HasModelProcessedResponse
{
    protected $modelResponseStatus = null;

    /**
     * @return $this
     */
    public function processModel()
    {
        if ($this->canProcessModel()) {
            $this->processModelStatus();
            $this->processModelData();
        }

        return $this;
    }

    /**
     * @return bool
     */
    protected function canProcessModel()
    {
        return false;
    }

    protected function processModelStatus()
    {
        $model = $this->getModel();
        $modelStatus = $this->getModel()->getStatus()->getName();

It seems like getStatus() must be provided by classes using this trait. How about adding it as abstract method to this trait?

The method getName() does not exist on Nip\Records\Collections\Collection.

        $newModelStatus = $this->getModelResponseStatus();
        if ($newModelStatus && $modelStatus !== $newModelStatus) {
            if ($newModelStatus == 'active') {
                $model->received = $this->getTransactionDate();

It seems like $this->getTransactionDate() can also be of type false. However, the property $received is declared as type string. Maybe add an additional type check?

                $model->updateStatus($newModelStatus);

It seems like updateStatus() must be provided by classes using this trait. How about adding it as abstract method to this trait?

$newModelStatus of type string is incompatible with the type boolean expected by parameter $status of ByTIC\Common\Records\Traits\HasStatus\RecordTrait::updateStatus().

            } elseif ($modelStatus == 'active' && $newModelStatus = 'error') {
                // ignore error status after active received
            } else {
                $model->updateStatus($newModelStatus);
            }
        }
    }

    /**
     * @return Record|RecordTrait|IsPurchasableModelTrait
     */
    public function getModel()
    {
        return $this->getDataProperty('model');

It seems like getDataProperty() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @return null|string
     */
    public function getModelResponseStatus()
    {
        if ($this->modelResponseStatus === null) {
            if ($this->isSuccessful()) {

It seems like isSuccessful() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                $status = 'active';
            } elseif ($this->isCancelled()) {

It seems like isCancelled() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                $status = 'canceled';
            } elseif ($this->isPending()) {

It seems like isPending() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                $status = 'pending';
            } else {
                $status = 'error';
            }
            $this->modelResponseStatus = $status;
        }

        return $this->modelResponseStatus;
    }

    /**
     * @return false|string
     */
    public function getTransactionDate()
    {
        if (is_callable('parent::getTransactionDate')) {
            return parent::getTransactionDate();
        }
        return date('Y-m-d H:i:s');
    }

    public function processModelData()
    {
    }

    /**
     * @return bool
     */
    public function hasModel()
    {
        return is_object($this->getModel());
    }
}