ByTIC\Payments\Gateways\Providers\AbstractGateway\Message\Traits\HasGatewayRequestTrait

Complexity

Total Complexity

2

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	updateParametersFromPurchase()	0	7	2

<?php

namespace ByTIC\Payments\Gateways\Providers\AbstractGateway\Message\Traits;

use Omnipay\Common\AbstractGateway;
use ByTIC\Payments\Models\Purchase\Traits\IsPurchasableModelTrait;

/**
 * Trait HasGatewayParamsRequestTrait
 * @package ByTIC\Payments\Gateways\Providers\AbstractGateway\Message\Traits
 */
trait HasGatewayRequestTrait
{
    /**
     * @param IsPurchasableModelTrait $model
     */
    protected function updateParametersFromPurchase($model)
    {
        /** @var AbstractGateway $gateway */
        $gateway = $model->getPaymentMethod()->getType()->getGateway();

The method getGateway() does not exist on ByTIC\Payments\Models\Methods\Types\AbstractType. It seems like you code against a sub-type of ByTIC\Payments\Models\Methods\Types\AbstractType such as ByTIC\Payments\Models\Methods\Types\CreditCards.

        if ($gateway) {

$gateway is of type Omnipay\Common\AbstractGateway, thus it always evaluated to true.

            $this->updateParametersFromGateway($gateway);
        }
    }

    /**
     * @param AbstractGateway $gateway
     * @return void
     */
    abstract protected function updateParametersFromGateway($gateway);
}