ByTIC\Payments\Gateways\Providers\PlatiOnline\Message\Traits\CompletePurchaseTrait

Complexity

Total Complexity

5

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	parseNotification()	0	8	2
A	updateParametersFromModel()	0	6	1
A	getData()	0	9	2

<?php

namespace ByTIC\Payments\Gateways\Providers\PlatiOnline\Message\Traits;

use ByTIC\Payments\Gateways\Providers\Librapay\Gateway;
use ByTIC\Payments\Models\Purchase\Traits\IsPurchasableModelTrait;

/**
 * Trait CompletePurchaseTrait
 * @package ByTIC\Payments\Gateways\Providers\PlatiOnline\Message\Traits
 */
trait CompletePurchaseTrait
{

    /**
     * @inheritdoc
     */
    public function getData()
    {
        $return = parent::getData();
        // Add model only if has data
        if (count($return)) {
            $return['model'] = $this->getModel();

It seems like getModel() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        return $return;
    }

    /**
     * @return bool|mixed
     * @throws \Exception
     */
    protected function parseNotification()
    {
        if ($this->validateModel()) {

It seems like validateModel() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $model = $this->getModel();
            $this->updateParametersFromModel($model);
        }

        return parent::parseNotification();
    }

    /**
     * @param IsPurchasableModelTrait $model
     *
     * @throws \Exception
     */
    protected function updateParametersFromModel($model)
    {
        /** @var \ByTIC\Payments\Gateways\Providers\PlatiOnline\Gateway $modelGateway */
        $modelGateway = $model->getPaymentMethod()->getType()->getGateway();

The method getGateway() does not exist on ByTIC\Payments\Models\Methods\Types\AbstractType. It seems like you code against a sub-type of ByTIC\Payments\Models\Methods\Types\AbstractType such as ByTIC\Payments\Models\Methods\Types\CreditCards.

        $this->setPrivateKey($modelGateway->getPrivateKey());

It seems like setPrivateKey() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->setInitialVectorItsn($modelGateway->getInitialVectorItsn());

It seems like setInitialVectorItsn() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }
}