ByTIC\Payments\Models\Methods\Types\CreditCards

Complexity

Total Complexity

7

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Test Coverage

Coverage

40%

Importance

Changes	3
Bugs	1	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getEntryDescription()	0	12	3
A	getGatewayOptions()	0	8	1
A	checkConfirmRedirect()	0	6	2
A	getGatewayName()	0	3	1

<?php

namespace ByTIC\Payments\Models\Methods\Types;

use ByTIC\Payments\Gateways\Traits\HasGatewaysTrait;
use ByTIC\Payments\Models\Methods\PaymentMethod;
use Nip\Helpers\View\Messages as MessagesHelper;

/**
 * Class Payment_Method_Type_Credit_Cards
 * @method PaymentMethod getItem()
 */
class CreditCards extends AbstractType
{
    protected $aliases = ['credit-cards','credit_cards'];

    use HasGatewaysTrait;

    /**
     * @return bool|string
     */
    public function getEntryDescription()
    {
        if (!$this->getGateway()) {
            return MessagesHelper::error(
                $this->getGatewaysManager()->getMessage('entry-payment.invalid')
            );
        } elseif (!$this->getGateway()->isActive()) {

The method isActive() does not exist on Omnipay\Common\GatewayInterface. It seems like you code against a sub-type of Omnipay\Common\GatewayInterface such as Paytic\Omnipay\Euplatesc\Gateway or ByTIC\Payments\Gateways\Providers\Paylike\Gateway or Paytic\Payments\Librapay\Gateway or Paytic\Payments\Payu\Gateway or Paytic\Payments\Stripe\Gateway or Paytic\Payments\Twispay\Gateway or ByTIC\Payments\Gateways\Providers\Romcard\Gateway or Paytic\Payments\Mobilpay\Gateway or Paytic\Payments\Simplify\Gateway or Paytic\Payments\PlatiOnline\Gateway.

            return MessagesHelper::error(
                $this->getGatewaysManager()->getMessage('entry-payment.inactive')
            );
        }
        return false;
    }

    /**
     * @return bool
     */
    public function checkConfirmRedirect()
    {
        if ($this->getGateway()) {
            return $this->getGateway()->isActive();
        }
        return false;
    }

    /**
     * @return mixed
     */
    public function getGatewayOptions()
    {
        $name = $this->getGatewayName();
        $methodOptions = $this->getItem()->getOption($name, []);
        $options['PaymentMethod'] = $this->getItem();

$options was never initialized. Although not strictly required by PHP, it is generally a good practice to add $options = array(); before regardless.

        $options = $options + $methodOptions;

        return $options;
    }

    /**
     * @return string
     */
    public function getGatewayName()
    {
        return $this->getItem()->getOption('payment_gateway');
    }
}