ByTIC\Payments\Controllers\Traits\PurchaseController\PurchaseRedirectActionsTrait

Complexity

Total Complexity

5

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	1	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	redirectToPayment()	0	14	3
A	redirectToPaymentPrepareResponse()	0	10	2

<?php

namespace ByTIC\Payments\Controllers\Traits\PurchaseController;

use ByTIC\FacebookPixel\FacebookPixel;
use Paytic\Omnipay\Common\Message\Traits\RedirectHtmlTrait;
use ByTIC\Payments\Models\Purchase\Traits\IsPurchasableModelTrait;
use Omnipay\Common\Message\RedirectResponseInterface;

/**
 * Trait PurchaseRedirectActionsTrait
 * @package ByTIC\Payments\Controllers\Traits\PurchaseController
 */
trait PurchaseRedirectActionsTrait
{
    public function redirectToPayment()
    {
        $model = $this->getModelFromRequest();

It seems like getModelFromRequest() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $request = $model->getPurchaseRequest();
        /** @var RedirectHtmlTrait $response */
        $response = $request->send();
        $this->redirectToPaymentPrepareResponse($response, $model);

        if ($response instanceof RedirectResponseInterface  && $response->isRedirect()) {
            $response->getRedirectResponse()->send();
        } else {
            $response->send();
        }
        die();

Using exit here is not recommended.

    }

    /**
     * @param RedirectHtmlTrait $response
     * @param Record|IsPurchasableModelTrait $model

The type ByTIC\Payments\Controllers\Traits\PurchaseController\Record was not found. Maybe you did not declare it correctly or list all dependencies?

     */
    protected function redirectToPaymentPrepareResponse($response, $model)
    {
        $response->getView()->set('subtitle', $model->getPurchaseName());
        $response->getView()->set('item', $model);
        $response->getView()->set('response', $model);

        if (method_exists($this, 'getFacebookPixelToPaymentResponse')) {
            /** @var FacebookPixel $facebookPixel */
            $facebookPixel = $this->getFacebookPixelToPaymentResponse($model);
            $response->getView()->append('footer_body', $facebookPixel->render());
        }
    }
}