ByTIC\Payments\Actions\Subscriptions\Charges\CalculateNextAttempt

Complexity

Total Complexity

7

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	nextAttempt()	0	16	5
A	for()	0	6	2

<?php

namespace ByTIC\Payments\Actions\Subscriptions\Charges;

use ByTIC\Payments\Models\Subscriptions\Subscription;

/**
 * Class CalculateNextAttempt
 * @package ByTIC\Payments\Actions\Subscriptions\Charges
 */
class CalculateNextAttempt
{
    /**
     * @param Subscription $subscription
     */
    public static function for($subscription)
    {
        $count = $subscription->charge_attempts > 0 ? $subscription->charge_attempts : 1;
        $subscription->charge_at = static::nextAttempt(
            $subscription->charge_at,

It seems like $subscription->charge_at can also be of type string; however, parameter $lastAttempt of ByTIC\Payments\Actions\Subscriptions\Charges\CalculateNextAttempt::nextAttempt() does only seem to accept DateTime, maybe add an additional type check?

            $count
        );
    }

    /**
     * @param \DateTime $startDate
     * @param $period
     * @param $interval
     */
    protected static function nextAttempt(\DateTime $lastAttempt, $tries)
    {
        switch ($tries) {
            case 1:
                return $lastAttempt->addHours(3);

The method addHours() does not exist on DateTime. It seems like you code against a sub-type of DateTime such as Carbon\Carbon.

            case 2:
                return $lastAttempt->addHours(12);

            case 3:
                return $lastAttempt->addDays(1);

The method addDays() does not exist on DateTime. It seems like you code against a sub-type of DateTime such as Carbon\Carbon.

            case 4:
                return $lastAttempt->addDays(2);
        }
        return $lastAttempt->addDays($tries - 2);
    }
}