ByTIC\Omnipay\Twispay\Message\Traits\CompletePurchaseRequestTrait

Complexity

Total Complexity

5

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	parseNotification()	0	9	2
A	isValidNotification()	0	3	3

<?php

namespace ByTIC\Omnipay\Twispay\Message\Traits;

use ByTIC\Omnipay\Common\Message\Traits\GatewayNotificationRequestTrait;
use ByTIC\Omnipay\Twispay\Helper;

/**
 * Trait CompletePurchaseRequestTrait
 * @package ByTIC\Omnipay\Twispay\Message\Traits
 */
trait CompletePurchaseRequestTrait
{
    use GatewayNotificationRequestTrait;

    /**
     * @return bool|mixed
     */
    protected function parseNotification()
    {
        $dataResult = $this->hasPOST('opensslResult')
            ? $this->httpRequest->request->get('opensslResult')
            : $this->httpRequest->request->get('result');

        $json = Helper::decrypt($dataResult, $this->getApiKey());

It seems like getApiKey() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $data = json_decode($json, true);
        return $data;
    }

    /**
     * @return mixed
     */
    protected function isValidNotification()
    {
        return $this->hasGet('id') && ($this->hasPOST('opensslResult') || $this->hasPOST('result'));
    }
}