ByTIC / mfinante

src/Parsers/AbstractParser.php

<?php

namespace ByTIC\MFinante\Parsers;

use ByTIC\MFinante\Models\AbstractModel;
use ByTIC\MFinante\Scrapers\AbstractScraper;
use Symfony\Component\DomCrawler\Crawler;

/**
 * Class AbstractParser
 * @package ByTIC\MFinante\Parsers
 */
abstract class AbstractParser
{

    /**
     * @var AbstractScraper
     */
    protected $scraper;

    /**
     * @var Crawler
     */
    protected $crawler;

    /**
     * @var null|boolean
     */
    protected $isValidContent = null;

    /**
     * @var null|array
     */
    protected $contents = null;

    /**
     * @return mixed
     */
    public function getContent()
    {
        if ($this->contents === null) {
            if ($this->isValidContent()) {
                $this->contents = $this->generateContent();
            } else {
                $this->contents = false;

It seems like false of type false is incompatible with the declared type null|array of property $contents.

            }
        }

        return $this->contents;
    }

    abstract protected function generateContent();

    /**
     * @return bool|null
     */
    public function isValidContent()
    {
        if ($this->isValidContent == null) {
            $this->doValidation();
            $this->isValidContent = true;
        }

        return $this->isValidContent;
    }

    /**
     * @return void
     */
    protected function doValidation()
    {
    }

    /**
     * @return AbstractScraper
     */
    public function getScraper()
    {
        return $this->scraper;
    }

    /**
     * @param AbstractScraper $scraper
     */
    public function setScraper($scraper)
    {
        $this->scraper = $scraper;
    }

    /**
     * @return Crawler
     */
    public function getCrawler(): Crawler
    {
        return $this->crawler;
    }

    /**
     * @param Crawler $crawler
     */
    public function setCrawler(Crawler $crawler)
    {
        $this->crawler = $crawler;
    }

    /**
     * @return array
     */
    public function getArray()
    {
        return $this->getContent();

The expression return $this->getContent() could also return false which is incompatible with the documented return type array. Did you maybe forget to handle an error condition?

    }

    public function getModel()
    {
        $model = $this->getNewModel();
        $parameters = $this->getContent();

The assignment to $parameters is dead and can be removed.

        $model->setParameters($model);

$model of type ByTIC\MFinante\Models\AbstractModel is incompatible with the type array expected by parameter $parameters of ByTIC\MFinante\Models\AbstractModel::setParameters().

    }

    /**
     * @return AbstractModel
     */
    public function getNewModel()
    {
        $className = $this->getModelClassName();
        $model = new $className();
        return $model;
    }

    abstract public function getModelClassName();
}