BalanceSheetPage::generateCrawler() - Code Metrics - Inspection of "update to travis CI" - ByTIC/mfinante - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7c13fc...e13714 )

by Gabriel

created 2017-07-30 18:10 UTC

BalanceSheetPage::generateCrawler() A

↳ Parent: BalanceSheetPage

Complexity

Conditions	4
Paths	1

Size

Total Lines	20
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	20
c	0
b	0
f	0
rs	9.2
cc	4
eloc	14
nc	1
nop	0

<?php

namespace ByTIC\MFinante\Scrapers;

use ByTIC\MFinante\Exception\InvalidArgumentException;
use ByTIC\MFinante\Exception\InvalidCifException;
use ByTIC\MFinante\Helper;
use ByTIC\MFinante\Parsers\BalanceSheetPage as Parser;

/**
 * Class BalanceSheetPage
 * @package ByTIC\MFinante\Scrapers
 *
 * @method Parser execute()
 */
class BalanceSheetPage extends AbstractScraper
{
    /**
     * @var int
     */
    protected $cif;

    /**
     * @var int
     */
    protected $year;

    /**
     * CompanyPage constructor.
     * @param int $cif
     * @param int $year
     */
    public function __construct($cif, $year)
    {
        $this->setCif($cif);
        $this->setYear($year);
    }

    /**
     * @inheritdoc
     */
    protected function generateCrawler()
    {
        if (!Helper::validateCif($this->getCif())) {
            throw new InvalidCifException();
        }
        $year = intval($this->getYear());
        if ($year < 2000 or $year > date('Y')) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
            throw new InvalidArgumentException(
                'Year [' . $this->getYear() . '] is invalid'
            );
        }
        $crawler = $this->getClient()->request(
            'GET',
            'http://www.mfinante.gov.ro/infocodfiscal.html?' .
            'an=WEB_ONG_AN' . $year
            . '&cod=' . $this->getCif()
            . '&captcha=null'
            . '&method.bilant=VIZUALIZARE'
        );
        return $crawler;
    }

    /**
     * @return int
     */
    public function getCif()
    {
        return $this->cif;
    }

    /**
     * @param int $cif
     */
    public function setCif($cif)
    {
        $this->cif = $cif;
    }

    /**
     * @return int
     */
    public function getYear(): int
    {
        return $this->year;
    }

    /**
     * @param int $year
     */
    public function setYear(int $year)
    {
        $this->year = $year;
    }
}


ByTIC / mfinante

Push — master ( 7c13fc...e13714 )

BalanceSheetPage::generateCrawler() A

Complexity

Size

Duplication

Importance

Logical Operators are used for Control-Flow

Duplication Side-by-Side

Filter issues like