ImgPicker

Complexity

Total Complexity

158

Size/Duplication

Total Lines	911
Duplicated Lines	0 %

Importance

Changes	2
Bugs	1	Features	1

27 Methods

Rating	Name	Duplication	Size	Complexity
A	upload()	0	12	3
C	resizeImage()	0	52	14
A	getErrorMessage()	0	4	2
C	generateVersions()	0	52	17
A	getFilename()	0	3	1
A	generateResponse()	0	3	1
A	getUploadPath()	0	12	3
A	getFileExtension()	0	3	1
B	rotateImage()	0	34	9
B	initialize()	0	32	8
B	orientImage()	0	22	7
B	load()	0	56	8
B	handleFileUpload()	0	49	7
A	getRandFilename()	0	3	1
A	getUploadUrl()	0	12	3
A	getVersionFilename()	0	8	2
A	delete()	0	15	5
A	upcountNameCallback()	0	6	3
A	upcountName()	0	7	1
A	getUniqueFilename()	0	10	3
C	crop()	0	81	14
B	getFullUrl()	0	11	8
A	fixIntOverflow()	0	7	2
A	getConfigBytes()	0	16	4
B	preview()	0	33	6
A	__construct()	0	56	1
D	validate()	0	76	24

<?php

/**
 * ImgPicker
 */
class ImgPicker
{
    protected $options;

    protected $error_messages = [
        // File upload errors codes
        // http://www.php.net/manual/en/features.file-upload.errors.php
        1 => 'The uploaded file exceeds the upload_max_filesize directive in php.ini',
        2 => 'The uploaded file exceeds the MAX_FILE_SIZE directive that was specified in the HTML form',
        3 => 'The uploaded file was only partially uploaded',
        4 => 'No file was uploaded',
        6 => 'Missing a temporary folder',
        7 => 'Failed to write file to disk',
        8 => 'A PHP extension stopped the file upload',
        'gd' => 'PHP GD library is NOT installed on your web server',
        'post_max_size' => 'The uploaded file exceeds the post_max_size directive in php.ini',
        'max_file_size' => 'File is too big',
        'min_file_size' => 'File is too small',
        'accept_file_types' => 'Filetype not allowed',
        'max_width' => 'Image exceeds maximum width of ',
        'min_width' => 'Image requires a minimum width of ',
        'max_height' => 'Image exceeds maximum height of ',
        'min_height' => 'Image requires a minimum height of ',
        'upload_failed' => 'Failed to upload the file',
        'move_failed' => 'Failed to upload the file',
        'invalid_image' => 'Invalid image',
        'image_resize' => 'Failed to resize image',
        'not_exists' => 'Failed to load the image',
    ];

    /**
     *    Constructor
     *
     * @param array $options
     * @param array $error_messages
     * @return void
     */
    public function __construct($options = array(), $error_messages = array())
    {
        $this->options = array(
            // Upload directory path:
            'upload_dir' => dirname(__FILE__) . '/files/',

            // Upload directory url:
            'upload_url' => $this->getFullUrl() . '/files/',

            // Accepted file types:
            'accept_file_types' => 'png|jpg|jpeg|gif',

            // Directory mode:
            'mkdir_mode' => 0755,

            // File size restrictions (in bytes):
            'max_file_size' => null,
            'min_file_size' => 1,

            // Image resolution restrictions (in px):
            'max_width' => null,
            'max_height' => null,
            'min_width' => 1,
            'min_height' => 1,

            // Auto orient image based on EXIF data:
            'auto_orient' => true,

            // Image versions
            'versions' => array(
                //'' => array(
                //'upload_dir' => '',
                //'upload_url' => '',
                // Create square images
                //    'crop' => true,
                //	'max_width' => 200,
                //     'max_height' => 200,
                //),

                // 'avatar' => array(
                // 	'crop' => true,
                // 	'max_width' => 200,
                // 	'max_height' => 200
                // ),

                // 'small' => array(
                // 	'crop' => true,
                // 	'max_width' => 100
                // )
            ),
        );

        $this->options = $options + $this->options;
        $this->error_messages = $error_messages + $this->error_messages;

        $this->initialize();
    }

    /**
     *    Initialize upload and crop actions
     *
     * @return void
     */
    protected function initialize()
    {
        // GD extension check
        // http://www.php.net/manual/en/book.image.php
        if (!extension_loaded('gd') || !function_exists('gd_info')) {
            $this->error = $this->getErrorMessage('gd');

The property error does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            return false;

The expression return false returns the type false which is incompatible with the documented return type void.

        }

        switch (@$_POST['action']) {
            case 'upload':
                $this->upload();
                break;

            case 'crop':
                $this->crop();
                break;

            case 'delete':
                $this->delete();
                break;
        }

        switch (@$_GET['action']) {
            case 'preview':
                $this->preview();
                break;

            case 'load':
                $this->load();
                break;
        }
    }

    /**
     *    Load action
     *
     * @return void
     */
    protected function load()
    {
        if (!isset($this->options['load'])) {
            return;
        }

        $files = call_user_func($this->options['load'], $this);

        if (!$files) {
            return;
        }

        if (!is_array($files)) {
            $files = array($files);
            $single = true;
        }

        $images = array();

        foreach ($files as $file) {
            $image = new stdClass();
            $image->path = $this->getUploadPath($file);

            if (!file_exists($image->path)) {
                continue;
            }

            $image->name = $file;
            $image->type = $this->getFileExtension($image->name);
            $image->url = $this->getUploadUrl($image->name);

            list($image->width, $image->height) = @getimagesize($image->path);

            foreach ($this->options['versions'] as $version => $options) {
                $filename = $this->getVersionFilename($image->name, $version);
                $filepath = $this->getUploadPath($filename, $version);

                list($width, $height) = @getimagesize($filepath);

                $image->versions[$version] = array(
                    'url' => $this->getUploadUrl($filename, $version),
                    'width' => $width,
                    'height' => $height,
                );
            }

            unset($image->path);

            if (isset($single)) {
                $images = $image;
            } else {
                $images[] = $image;
            }
        }

        $this->generateResponse($images);

It seems like $images can also be of type stdClass; however, parameter $response of ImgPicker::generateResponse() does only seem to accept array, maybe add an additional type check?

    }

    /**
     *    Preview action
     *
     * @return void
     */
    protected function preview()
    {
        $filename = basename(@$_GET['file']);
        $width = @$_GET['width'];
        $rotate = @$_GET['rotate'];

        $filepath = $this->getUploadPath($filename);
        $filetype = $this->getFileExtension($filename);

        if (file_exists($filepath)) {
            list($src_w, $src_h) = @getimagesize($filepath);

            $dst_w = $src_w;
            $dst_h = $src_h;

            if (is_numeric($width) && $width > 0) {
                $dst_w = $width;
                $dst_h = $src_h / $src_w * $width;
            }

            $dst_path = $this->getUploadPath(md5($filename) . '.' . $filetype);

            $this->resizeImage($filepath, $dst_path, 0, 0, $dst_w, $dst_h, $src_w, $src_h);

            if (in_array(abs($rotate), array(90, 180, 270))) {
                $angle = ($rotate < 0) ? abs($rotate) : 360 - $rotate;
                $this->rotateImage($dst_path, $angle);

It seems like $angle can also be of type double; however, parameter $angle of ImgPicker::rotateImage() does only seem to accept integer, maybe add an additional type check?

            }

            header('Content-Type: image/jpeg');
            header('Content-Length: ' . filesize($dst_path));
            readfile($dst_path);
            @unlink($dst_path);

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

        }
    }

    /**
     *    Delete action
     *
     * @return void
     */
    protected function delete()
    {
        if (!isset($this->options['delete'])) {
            return;
        }

        $filename = basename(@$_POST['file']);
        $filepath = $this->getUploadPath($filename);

        if (file_exists($filepath) && call_user_func($this->options['delete'], $filename, $this)) {
            foreach ($this->options['versions'] as $version => $options) {
                $name = $this->getVersionFilename($filename, $version);
                $path = $this->getUploadPath($name, $version);

The assignment to $path is dead and can be removed.

            }
            @unlink($filepath);

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

        }
    }

    /**
     *    Upload action
     *
     * @return void
     */
    protected function upload()
    {
        $upload = isset($_FILES['file']) ? $_FILES['file'] : null;

        $file = $this->handleFileUpload(
            @$upload['tmp_name'],
            @$upload['name'] == 'blob' ? $this->getRandFilename() . '.jpg' : @$upload['name'],
            @$upload['size'],
            @$upload['error']
        );

        $this->generateResponse($file);

$file of type stdClass is incompatible with the type array expected by parameter $response of ImgPicker::generateResponse().

    }

    /**
     *    Handle file upload
     *
     * @param string $uploaded_file
     * @param string $name
     * @param integer $size
     * @param integer $error
     * @return stdClass
     */
    protected function handleFileUpload($uploaded_file, $name, $size, $error)
    {
        $image = new stdClass();
        $image->name = $this->getFilename($name);
        $image->type = $this->getFileExtension($name);
        $image->size = $this->fixIntOverflow(intval($size));
        $image->path = $this->getUploadPath($image->name);
        $image->url = $this->getUploadUrl($image->name);
        list($image->width, $image->height) = @getimagesize($uploaded_file);

        if (!$this->validate($uploaded_file, $image, $error)) {
            return $image;
        }

        $upload_dir = $this->getUploadPath();
        if (!is_dir($upload_dir)) {
            mkdir($upload_dir, $this->options['mkdir_mode'], true);
        }

        //Upload start callback
        if (isset($this->options['upload_start'])) {
            call_user_func($this->options['upload_start'], $image, $this);
        }

        $image->path = $this->getUploadPath($image->name);
        $image->url = $this->getUploadUrl($image->name);

        if (!move_uploaded_file($uploaded_file, $image->path)) {
            $image->error = $this->getErrorMessage('move_failed');

            return $image;
        }

        // Orient the image
        if (!empty($this->options['auto_orient'])) {
            $this->orientImage($image->path);
        }

        // Generate image versions
        $image->versions = $this->generateVersions($image, true);

        // Upload complete callback
        if (isset($this->options['upload_complete'])) {
            call_user_func($this->options['upload_complete'], $image, $this);
        }

        unset($image->path);

        return $image;
    }

    /**
     *    Crop action
     *
     * @return void
     */
    protected function crop()
    {
        $filename = basename(@$_POST['image']);
        $rotate = @$_POST['rotate'];

        $image = new stdClass();
        $image->name = $filename;
        $image->type = $this->getFileExtension($image->name);
        $image->path = $this->getUploadPath($image->name);
        $image->url = $this->getUploadUrl($image->name);

        if (!file_exists($image->path)) {
            return $this->generateResponse(array('error' => $this->getErrorMessage('not_exists')));

The expression return $this->generateResponse(array('error' => $this->getErrorMessage('not_exists'))) returns the type string which is incompatible with the documented return type void.

        }

        if (!preg_match('/.(' . $this->options['accept_file_types'] . ')+$/i', $image->name)) {
            return;
        }

        list($image->width, $image->height) = @getimagesize($image->path);

        @list($src_x, $src_y, $x2, $y2, $src_w, $src_h) = @array_values(@$_POST['coords']);

        if (isset($this->options['crop_start'])) {
            call_user_func($this->options['crop_start'], $image, $this);
        }

        $image->url = $this->getUploadUrl($image->name);

        if (empty($src_w) || empty($src_h)) {
            $src_w = $image->width;
            $src_h = $image->height;
        }

        if (empty($src_x) && empty($src_y)) {
            $src_x = $src_y = 0;
        }

        $dst_w = $src_w;
        $dst_h = $src_h;

        $tmp = clone $image;
        $tmp->path = $this->getUploadPath(md5($tmp->name) . '.' . $tmp->type);

        @copy($image->path, $tmp->path);

It seems like you do not handle an error condition for copy(). This can introduce security issues, and is generally not recommended.

        if (in_array(abs($rotate), array(90, 180, 270))) {
            $angle = ($rotate < 0) ? abs($rotate) : 360 - $rotate;
            $this->rotateImage($tmp->path, $angle);

It seems like $angle can also be of type double; however, parameter $angle of ImgPicker::rotateImage() does only seem to accept integer, maybe add an additional type check?

        }

        $this->resizeImage($tmp->path, null, $src_x, $src_y, $dst_w, $dst_h, $src_w, $src_h);

        list($tmp->width, $tmp->height) = @getimagesize($tmp->path);

        $image->versions = $this->generateVersions($tmp);

        @unlink($tmp->path);

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

        if (!isset($this->options['versions'][''])) {
            @rename($image->path, $this->getUploadPath($image->name));

It seems like you do not handle an error condition for rename(). This can introduce security issues, and is generally not recommended.

        }

        list($image->width, $image->height) = @getimagesize($this->getUploadPath($image->name));

        if ($image->path != $this->getUploadPath($image->name)) {
            foreach ($this->options['versions'] as $version => $options) {
                $filename = $this->getVersionFilename(basename($image->path), $version);
                @unlink($this->getUploadPath($filename, $version));
            }
        }

        // Crop complete callback
        if (isset($this->options['crop_complete'])) {
            call_user_func($this->options['crop_complete'], $image, $this);
        }

        unset($image->path);

        // Generate json response
        $this->generateResponse($image);

$image of type stdClass is incompatible with the type array expected by parameter $response of ImgPicker::generateResponse().

    }

    /**
     *    Generate image versions
     *
     * @param stdClass $image
     * @param bool $is_upload
     * @return array
     */
    protected function generateVersions($image, $is_upload = false)
    {
        $versions = array();
        foreach ($this->options['versions'] as $version => $options) {
            $dst_w = $src_w = $image->width;
            $dst_h = $src_h = $image->height;
            $src_x = $src_y = 0;

            $max_width = @$options['max_width'];
            $max_height = @$options['max_height'];
            $crop = isset($options['crop']) && $options['crop'] === true;

            if ($crop) {
                $min = min($src_w, $src_h);
                $src_x = ($src_w - $min) / 2;
                $src_y = ($src_h - $min) / 2;
                $dst_w = $dst_h = $src_w = $src_h = $min;
            }

            if (!empty($max_width) && $src_w > $max_width || ($src_w < $max_width && $crop)) {

Consider adding parentheses for clarity. Current Interpretation: (! empty($max_width) && $src_w > $max_width) || $src_w < $max_width && $crop, Probably Intended Meaning: ! empty($max_width) && ($src_w > $max_width || $src_w < $max_width && $crop)

                $dst_w = $max_width;
                $dst_h = $src_h / $src_w * $max_width;
            } else {
                if (!empty($max_height) && $src_h > $max_height || ($src_h < $max_height && $crop)) {

Consider adding parentheses for clarity. Current Interpretation: (! empty($max_height) && $src_h > $max_height) || $src_h < $max_height && $crop, Probably Intended Meaning: ! empty($max_height) && ($src_h > $max_height || $src_h < $max_height && $crop)

                    $dst_h = $max_height;
                    $dst_w = $src_w / $src_h * $max_height;
                }
            }

            $filename = $this->getVersionFilename($image->name, $version);
            $filepath = $this->getUploadPath($filename, $version);
            $upload_dir = $this->getUploadPath('', $version);

            if (!is_dir($upload_dir)) {
                mkdir($upload_dir, $this->options['mkdir_mode'], true);
            }

            if (!$is_upload || ($is_upload && $version != '')) {
//                var_dump($image->path, $filepath, $src_x, $src_y, $dst_w, $dst_h, $src_w, $src_h);
                $success = $this->resizeImage($image->path, $filepath, $src_x, $src_y, $dst_w, $dst_h, $src_w, $src_h);
            }

            if (!empty($success)) {
                $versions[$version] = array(
                    'url' => $this->getUploadUrl($filename, $version),
                    'width' => $dst_w,
                    'height' => $dst_h,
                );
            }
        }

        return $versions;
    }

    /**
     *    Validate uploaded file
     *
     * @param string $uploaded_file
     * @param stdClass $name
     * @param string $error
     * @return boolean
     */
    protected function validate($uploaded_file, $file, $error)
    {
        if (!$uploaded_file) {
            $file->error = $this->getErrorMessage(4);

            return false;
        }

        if ($error) {
            $file->error = $this->getErrorMessage($error);

            return false;
        }

        $content_length = $this->fixIntOverflow(intval($_SERVER['CONTENT_LENGTH']));
        $post_max_size = $this->getConfigBytes(ini_get('post_max_size'));

        if ($post_max_size && $content_length > $post_max_size) {
            $file->error = $this->getErrorMessage('post_max_size');

            return false;
        }

        if ($this->options['max_file_size'] && $file->size > $this->options['max_file_size']) {
            $file->error = $this->getErrorMessage('max_file_size');

            return false;
        }

        if ($this->options['min_file_size'] && $file->size < $this->options['min_file_size']) {
            $file->error = $this->getErrorMessage('min_file_size');

            return false;
        }

        if (!preg_match('/.(' . $this->options['accept_file_types'] . ')+$/i', $file->name)) {
            $file->error = $this->getErrorMessage('accept_file_types');

            return false;
        }

        if (empty($file->width) || empty($file->height)) {
            $file->error = $this->getErrorMessage('invalid_image');

            return false;
        }

        $max_width = @$this->options['max_width'];
        $max_height = @$this->options['max_height'];
        $min_width = @$this->options['min_width'];
        $min_height = @$this->options['min_height'];

        if ($max_width || $max_height || $min_width || $min_height) {
            if ($max_width && $file->width > $max_width) {
                $file->error = $this->getErrorMessage('max_width') . $max_width . 'px';

                return false;
            }
            if ($max_height && $file->height > $max_height) {
                $file->error = $this->getErrorMessage('max_height') . $max_height . 'px';

                return false;
            }
            if ($min_width && $file->width < $min_width) {
                $file->error = $this->getErrorMessage('min_width') . $min_width . 'px';

                return false;
            }
            if ($min_height && $file->height < $min_height) {
                $file->error = $this->getErrorMessage('min_height') . $min_height . 'px';

                return false;
            }
        }

        return true;
    }

    /**
     *    Get upload directory path
     *
     * @param string $filename
     * @param string $version
     * @return string
     */
    public function getUploadPath($filename = '', $version = '')
    {
        $upload_dir = $this->options['upload_dir'];

        if ($version != '') {
            $dir = @$this->options['versions'][$version]['upload_dir'];
            if (!empty($dir)) {
                $upload_dir = $dir;
            }
        }

        return $upload_dir . $filename;
    }

    /**
     *    Get upload directory url
     *
     * @param string $filename
     * @param string $version
     * @return string
     */
    public function getUploadUrl($filename = '', $version = '')
    {
        $upload_url = $this->options['upload_url'];

        if ($version != '') {
            $url = @$this->options['versions'][$version]['upload_url'];
            if (!empty($url)) {
                $upload_url = $url;
            }
        }

        return $upload_url . $filename;
    }

    /**
     *    Get full url
     *
     * @return string
     */
    protected function getFullUrl()
    {
        $https = !empty($_SERVER['HTTPS']) && strcasecmp($_SERVER['HTTPS'], 'on') === 0;

        return
            ($https ? 'https://' : 'http://') .
            (!empty($_SERVER['REMOTE_USER']) ? $_SERVER['REMOTE_USER'] . '@' : '') .
            (isset($_SERVER['HTTP_HOST']) ? $_SERVER['HTTP_HOST'] : ($_SERVER['SERVER_NAME'] .
                ($https && $_SERVER['SERVER_PORT'] === 443 ||
                $_SERVER['SERVER_PORT'] === 80 ? '' : ':' . $_SERVER['SERVER_PORT']))) .
            substr($_SERVER['SCRIPT_NAME'], 0, strrpos($_SERVER['SCRIPT_NAME'], '/'));
    }

    /**
     *    Get file name
     *
     * @param string
     * @return string
     */
    public function getFilename($name)
    {
        return $this->getUniqueFilename($name);
    }

    /**
     *    Get version name
     *
     * @param string
     * @return string
     */
    public function getVersionFilename($filename, $version)
    {
        $ext = $this->getFileExtension($filename);
        if ($version == '') {
            return $filename;
        }

        return str_replace('.' . $ext, "-$version.$ext", $filename);
    }

    /**
     *    Get unique file name
     *
     * @param string
     * @return string
     */
    public function getUniqueFilename($name)
    {
        while (is_dir($this->getUploadPath($name))) {
            $name = $this->upcountName($name);
        }
        while (is_file($this->getUploadPath($name))) {
            $name = $this->upcountName($name);
        }

        return $name;
    }

    /**
     *    Generate random file name
     *
     * @return string
     */
    public function getRandFilename()
    {
        return md5(time() . rand());
    }

    /**
     *    Get file extension
     *
     * @param string $filename
     * @return string
     */
    public function getFileExtension($filename)
    {
        return pathinfo(strtolower($filename), PATHINFO_EXTENSION);

The expression return pathinfo(strtolower($filename), PATHINFO_EXTENSION) also could return the type array which is incompatible with the documented return type string.

    }

    /**
     *    Generate json response
     *
     * @param array $response
     * @return string
     */
    public function generateResponse($response)
    {
        echo json_encode($response);
    }

    /**
     *    Get error message
     *
     * @param string $error
     * @return string
     */
    public function getErrorMessage($error)
    {
        return array_key_exists($error, $this->error_messages) ?
            $this->error_messages[$error] : $error;
    }

    /**
     *    Resize image
     *
     * @param string $src_path Source image path
     * @param string|null $dst_path Destination image path
     * @param integer $src_x x-coordinate of source point
     * @param integer $src_y y-coordinate of source point
     * @param integer $dst_w Destination width
     * @param integer $dst_h Destination height
     * @param integer $src_w Source width
     * @param integer $src_h Source height
     * @return bool
     */
    public function resizeImage($src_path, $dst_path = null, $src_x, $src_y, $dst_w, $dst_h, $src_w, $src_h)
    {
        $src_x = ceil($src_x);
        $src_y = ceil($src_y);
        $dst_w = ceil($dst_w);
        $dst_h = ceil($dst_h);
        $src_w = ceil($src_w);
        $src_h = ceil($src_h);

        $dst_path = ($dst_path) ? $dst_path : $src_path;
        $dst_image = imagecreatetruecolor($dst_w, $dst_h);

$dst_h of type double is incompatible with the type integer expected by parameter $height of imagecreatetruecolor().

$dst_w of type double is incompatible with the type integer expected by parameter $width of imagecreatetruecolor().

        $extension = $this->getFileExtension($src_path);

        if (!$dst_image) {
            return false;
        }

        switch ($extension) {
            case 'gif':
                $src_image = imagecreatefromgif($src_path);
                break;
            case 'jpeg':
            case 'jpg':
                $src_image = imagecreatefromjpeg($src_path);
                break;
            case 'png':
                imagealphablending($dst_image, false);
                imagesavealpha($dst_image, true);
                $src_image = imagecreatefrompng($src_path);
                @imagealphablending($src_image, true);

It seems like you do not handle an error condition for imagealphablending(). This can introduce security issues, and is generally not recommended.

                break;
        }

        if (isset($src_image) && !$src_image) {
            return false;
        }

        if (!imagecopyresampled($dst_image, $src_image, 0, 0, $src_x, $src_y, $dst_w, $dst_h, $src_w, $src_h)) {

The variable $src_image does not seem to be defined for all execution paths leading up to this point.

$src_h of type double is incompatible with the type integer expected by parameter $src_h of imagecopyresampled().

$src_x of type double is incompatible with the type integer expected by parameter $src_x of imagecopyresampled().

$src_w of type double is incompatible with the type integer expected by parameter $src_w of imagecopyresampled().

$dst_h of type double is incompatible with the type integer expected by parameter $dst_h of imagecopyresampled().

$dst_w of type double is incompatible with the type integer expected by parameter $dst_w of imagecopyresampled().

$src_y of type double is incompatible with the type integer expected by parameter $src_y of imagecopyresampled().

            return false;
        }

        switch ($extension) {
            case 'gif':
                return imagegif($dst_image, $dst_path);
                break;

break is not strictly necessary here and could be removed.

            case 'jpeg':
            case 'jpg':
                return imagejpeg($dst_image, $dst_path);
                break;
            case 'png':
                return imagepng($dst_image, $dst_path);
                break;
        }
    }

    /**
     *    Rotate image
     *
     * @param string $src_path
     * @param integer $angle
     * @return void
     */
    public function rotateImage($src_path, $angle)
    {
        $type = $this->getFileExtension($src_path);

        switch ($type) {
            case 'gif':
                $source = imagecreatefromgif($src_path);
                break;
            case 'jpeg':
            case 'jpg':
                $source = imagecreatefromjpeg($src_path);
                break;
            case 'png':
                $source = imagecreatefrompng($src_path);
                break;
        }

        $image = imagerotate($source, $angle, 0);

The variable $source does not seem to be defined for all execution paths leading up to this point.

        switch ($type) {
            case 'gif':
                imagegif($image, $src_path);
                break;
            case 'jpeg':
            case 'jpg':
                imagejpeg($image, $src_path);
                break;
            case 'png':
                imagepng($image, $src_path);
                break;
        }

        imagedestroy($source);
        imagedestroy($image);
    }

    /**
     *    Orient image based on EXIF orientation data
     *
     * @param string $filepath
     * @return void
     */
    protected function orientImage($filepath)
    {
        if (!preg_match('/\.(jpe?g)$/i', $filepath)) {
            return;
        }

        $exif = @exif_read_data($filepath);
        if (!empty($exif['Orientation'])) {
            switch ($exif['Orientation']) {
                case 3:
                    $angle = 180;
                    break;
                case 6:
                    $angle = -90;
                    break;
                case 8:
                    $angle = 90;
                    break;
            }

            if (isset($angle)) {
                $this->rotateImage($filepath, $angle);
            }
        }
    }

    protected function upcountName($name)
    {
        return preg_replace_callback(
            '/(?:(?: \(([\d]+)\))?(\.[^.]+))?$/',
            array($this, 'upcountNameCallback'),
            $name,
            1
        );
    }

    protected function upcountNameCallback($matches)
    {
        $index = isset($matches[1]) ? intval($matches[1]) + 1 : 1;
        $ext = isset($matches[2]) ? $matches[2] : '';

        return ' (' . $index . ')' . $ext;
    }

    protected function getConfigBytes($val)
    {
        $val = trim($val);
        $last = strtolower($val[strlen($val) - 1]);
        switch ($last) {
            case 'g':
                $val *= 1024;
                // no break
            case 'm':
                $val *= 1024;
                // no break
            case 'k':
                $val *= 1024;
        }

        return $this->fixIntOverflow($val);
    }

    protected function fixIntOverflow($size)
    {
        if ($size < 0) {
            $size += 2.0 * (PHP_INT_MAX + 1);
        }

        return $size;
    }
}