ByTIC\MediaLibraryModule\Application\Modules\AbstractModule\Controllers\Traits\HasMediaAsyncTrait

Complexity

Total Complexity

14

Size/Duplication

Total Lines	79
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	3
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	uploadGallery()	0	33	6
A	setDefaultMediaItem()	0	16	4
A	removeMediaItem()	0	17	4

<?php

namespace ByTIC\MediaLibraryModule\Application\Modules\AbstractModule\Controllers\Traits;

use ByTIC\MediaLibrary\Exceptions\FileCannotBeAdded;
use ByTIC\MediaLibrary\Exceptions\FileCannotBeAdded\FileUnacceptableForCollection;
use ByTIC\MediaLibrary\FileAdder\FileAdderFactory;
use ByTIC\MediaLibrary\HasMedia\HasMediaTrait;
use ByTIC\MediaLibraryModule\Controllers\Traits\Async\Covers;
use ByTIC\MediaLibraryModule\Controllers\Traits\Async\Files;
use ByTIC\MediaLibraryModule\Controllers\Traits\Async\Gallery;
use ByTIC\MediaLibraryModule\Controllers\Traits\Async\Images;
use ByTIC\MediaLibraryModule\Controllers\Traits\Async\Logos;
use Nip\Http\Request;

/**
 * Class HasMediaAsyncTrait
 * @package ByTIC\MediaLibraryModule\Application\Modules\AbstractModule\Controllers\Traits
 *
 * @method HasMediaTrait getModelFromRequest
 * @method Request getRequest
 */
trait HasMediaAsyncTrait
{
    use Covers;
    use Files;
    use Gallery;
    use Images;
    use Logos;

    public function uploadGallery()
    {
        if (!$this->getRequest()->files->has('file') || $this->getRequest()->request->has('action')) {
            $this->uploadGalleryImgPicker();

            return;
        }

        /** @var HasMediaTrait $item */
        $item = $this->getModelFromRequest();
        $mediaType = $this->getRequest()->get('media_type', 'images');

        /** @var \ByTIC\MediaLibrary\Validation\Constraints\ImageConstraint $constraint */
//        $constraint = $item->getMediaRepository()->getCollection('images')->getConstraint();

        try {
            $adder = FileAdderFactory::create($item, $this->getRequest()->files->get('file'));

            if ($this->getRequest()->request->has('cropper')) {
                parse_str($this->getRequest()->request->get('cropper'), $copperData);
                $adder->getMedia()->cropperData = $copperData;

The property cropperData does not seem to exist on ByTIC\MediaLibrary\Media\Media.

            }
            $adder->toMediaCollection($mediaType);
        } catch (FileCannotBeAdded $exception) {
            http_response_code(415);
            header('Content-Type: application/json; charset=utf-8');
            $output = ['error' => $exception->getMessage()];
            if ($exception instanceof FileUnacceptableForCollection) {
                $output['error'] .= ': ' . $exception->violations->getMessageString();
            }
            echo json_encode($output);
        }
        die();

Using exit here is not recommended.

    }

    public function setDefaultMediaItem()
    {
        $item = $this->getModelFromRequest();
        $type = $this->getRequest()->get('media_type');
        switch ($type) {
            case 'images':
            case 'covers':
            case 'logos':
                $item->getMedia($type)->persistDefaultMediaFromName(
                    $this->getRequest()->get('media_filename')
                );
                $this->sendSuccess("Imaginea a fost stabilita ca principala");

It seems like sendSuccess() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                break;

            default:
                $this->sendError("Imaginea nu a putut fi stabilita ca principala");

It seems like sendError() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }
    }

    public function removeMediaItem()
    {
        $item = $this->getModelFromRequest();
        $type = $this->getRequest()->get('media_type');

        switch ($this->getRequest()->get('media_type')) {
            case 'images':
            case 'covers':
            case 'logos':
                $item->getMedia($type)->deleteMediaByKey(

It seems like $type can also be of type null; however, parameter $collectionName of ByTIC\MediaLibrary\HasMedia\HasMediaTrait::getMedia() does only seem to accept string, maybe add an additional type check?

                    $this->getRequest()->get('media_filename')
                );

                $this->sendSuccess("Imaginea a fost stearsa");
                break;
            default:
                $this->sendError("Imaginea nu a putut fi stearsa");
        }
    }
}