Issues in Email.php (master) - Issues in master - ByTIC/framework - Measure and Improve Code Quality continuously with Scrutinizer

Issues (917)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/View/Email.php (1 issue)

Labels

Bug 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Nip\View;

use Nip\View;

/**
 * Class Email
 * @package Nip\View
 */
class Email extends View
{

    protected $_layout = "/layouts/email";

    /**
     * @var \Nip_Mailer|null
     */
    protected $_mail = null;

    public function __construct()
    {
        $this->initMailer();
    }

    public function initMailer()
    {
        $this->_mail = new \Nip_Mailer();
    }

    public function initBasePath()
    {
        $this->setBasePath(MODULES_PATH . request()->getModuleName() . '/views/');
    }

    /**
     * @param string $host
     * @param string $username
     * @param string $password
     * @return $this
     */
    public function authSMTP($host, $username, $password)
    {
        $this->_mail->authSMTP($host, $username, $password);
        return $this;
    }

    /**
     * Sets flag to show SMTP debugging information
     * @return $this
     */
    public function debugSMTP()
    {
        $this->_mail->debugSMTP();
        return $this;
    }

    /**
     * @param string $address
     * @param string|bool $name
     * @return $this
     */
    public function setFrom($address, $name = false)
    {
        $this->_mail->setFrom($address, $name);
        return $this;
    }

    /**
     * @param string $address
     * @param string|bool $name
     * @return $this
     */
    public function addTo($address, $name = false)
    {
        $this->_mail->addTo($address, $name);
        return $this;
    }

    /**
     * @param string $address
     * @param string $name
     * @return $this
     */
    public function addBCC($address, $name = '')
    {
        $this->_mail->addBCC($address, $name);
        return $this;
    }

    /**
     * @param string $address
     * @param string|bool $name
     * @return $this
     */
    public function addReplyTo($address, $name = false)
    {
        $this->_mail->addReplyTo($address, $name);

        return $this;
    }

    /**
     * @return $this
     */
    public function clearAllRecipients()
    {
        $this->_mail->clearAllRecipients();
        return $this;
    }

    /**
     * @param string $subject
     * @return $this
     */
    public function setSubject($subject)
    {
        $this->_mail->setSubject($subject);
        return $this;
    }

    /**
     * Adds attachment
     *
     * @param string $path
     * @param string $name
     * @return $this
     */
    public function addAttachment($path, $name = '')
    {
        $this->_mail->addAttachment($path, $name);
        return $this;
    }

    /**
     * @return mixed
     */
    public function send()
    {
        if (!$this->getBody()) {
            $this->setBody($this->load($this->_layout, [], true));
        }
        $this->_mail->setAltBody($this->getBody());

        return $this->_mail->send();
    }

    /**
     * @return mixed
     */
    public function getBody()
    {
        return $this->_mail->getBody();
    }

    /**
     * @param $body
     * @return $this
     */
    public function setBody($body)
    {
        $this->_mail->setBody($body);
        return $this;
    }

    /**
     * @param $layout
     */
    public function setLayout($layout)
    {
        $this->_layout = $layout;
    }
}


1			<?php
2
3			namespace Nip\View;
4
5			use Nip\View;
6
7			/**
8			* Class Email
9			* @package Nip\View
10			*/
11			class Email extends View
12			{
13
14			protected $_layout = "/layouts/email";
15
16			/**
17			* @var \Nip_Mailer\|null
18			*/
19			protected $_mail = null;
20
21			public function __construct()
22			{
23			$this->initMailer();
24			}
25
26			public function initMailer()
27			{
28			$this->_mail = new \Nip_Mailer();
29			}
30
31			public function initBasePath()
32			{
33			$this->setBasePath(MODULES_PATH . request()->getModuleName() . '/views/');
34			}
35
36			/**
37			* @param string $host
38			* @param string $username
39			* @param string $password
40			* @return $this
41			*/
42			public function authSMTP($host, $username, $password)
43			{
44			$this->_mail->authSMTP($host, $username, $password);
45			return $this;
46			}
47
48			/**
49			* Sets flag to show SMTP debugging information
50			* @return $this
51			*/
52			public function debugSMTP()
53			{
54			$this->_mail->debugSMTP();
55			return $this;
56			}
57
58			/**
59			* @param string $address
60			* @param string\|bool $name
61			* @return $this
62			*/
63			public function setFrom($address, $name = false)
64			{
65			$this->_mail->setFrom($address, $name);
66			return $this;
67			}
68
69			/**
70			* @param string $address
71			* @param string\|bool $name
72			* @return $this
73			*/
74			public function addTo($address, $name = false)
75			{
76			$this->_mail->addTo($address, $name);
77			return $this;
78			}
79
80			/**
81			* @param string $address
82			* @param string $name
83			* @return $this
84			*/
85			public function addBCC($address, $name = '')
86			{
87			$this->_mail->addBCC($address, $name);
88			return $this;
89			}
90
91			/**
92			* @param string $address
93			* @param string\|bool $name
94			* @return $this
95			*/
96			public function addReplyTo($address, $name = false)
97			{
98			$this->_mail->addReplyTo($address, $name);
			0 ignored issues – show Bug introduced 2017-03-05 14:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$name` defined by parameter `$name` on line 96 can also be of type `boolean`; however, `Nip_Mailer::addReplyTo()` does only seem to accept `false\|string`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
99			return $this;
100			}
101
102			/**
103			* @return $this
104			*/
105			public function clearAllRecipients()
106			{
107			$this->_mail->clearAllRecipients();
108			return $this;
109			}
110
111			/**
112			* @param string $subject
113			* @return $this
114			*/
115			public function setSubject($subject)
116			{
117			$this->_mail->setSubject($subject);
118			return $this;
119			}
120
121			/**
122			* Adds attachment
123			*
124			* @param string $path
125			* @param string $name
126			* @return $this
127			*/
128			public function addAttachment($path, $name = '')
129			{
130			$this->_mail->addAttachment($path, $name);
131			return $this;
132			}
133
134			/**
135			* @return mixed
136			*/
137			public function send()
138			{
139			if (!$this->getBody()) {
140			$this->setBody($this->load($this->_layout, [], true));
141			}
142			$this->_mail->setAltBody($this->getBody());
143
144			return $this->_mail->send();
145			}
146
147			/**
148			* @return mixed
149			*/
150			public function getBody()
151			{
152			return $this->_mail->getBody();
153			}
154
155			/**
156			* @param $body
157			* @return $this
158			*/
159			public function setBody($body)
160			{
161			$this->_mail->setBody($body);
162			return $this;
163			}
164
165			/**
166			* @param $layout
167			*/
168			public function setLayout($layout)
169			{
170			$this->_layout = $layout;
171			}
172			}
173

GitHub Access Token became invalid

Issues (917)

Security Analysis not enabled

src/View/Email.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

ByTIC / framework

GitHub Access Token became invalid

Issues (917)

Security Analysis not enabled

src/View/Email.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like