ByTIC / framework

src/Request.php

<?php

namespace Nip;

use ByTIC\RequestDetective\RequestDetective;
use Nip\Http\Request\Http;
use Nip\Http\Request\Traits\ArrayAccessTrait;
use Nip\Http\Request\Traits\InteractsWithMca;
use Nip\Http\Request\Traits\InteractsWithUri;
use Nip\Http\Request\Traits\PsrBridgeTrait;
use Psr\Http\Message\ServerRequestInterface;

/**
 * Class Request
 * @package Nip
 */
class Request extends \Symfony\Component\HttpFoundation\Request implements \ArrayAccess, ServerRequestInterface
{
    use PsrBridgeTrait;
    use InteractsWithUri;
    use InteractsWithMca;
    use ArrayAccessTrait;

    /**
     * @var Http
     */
    protected $http;


    /**
     * Singleton
     *
     * @param null $newInstance
     * @return static
     */
    public static function instance($newInstance = null)
    {
        static $instance;

        if ($newInstance instanceof self) {
            $instance = $newInstance;
        }

        if (!($instance instanceof self)) {
            $instance = new self();
        }

        return $instance;
    }

    /**
     * @param $name
     * @return mixed
     */
    public function __get($name)
    {
        return $this->get($name);
    }

    /**
     * Set an action parameter
     *
     * A $value of null will unset the $key if it exists
     *
     * @param string $key
     * @param mixed $value
     * @return self
     */
    public function setAttribute($key, $value)
    {
        $this->attributes->set($key, $value);

        return $this;
    }

    /**
     * @param array $params
     * @return $this
     */
    public function setParams(array $params)
    {
        foreach ($params as $param => $value) {
            $this->{$param} = $value;
        }

        return $this;
    }

    /**
     * Returns Http object
     * @return Http
     */
    public function getHttp()
    {
        if (!$this->http) {
            $this->http = new Http();
            $this->http->setRequest($this);
        }

        return $this->http;
    }

    /**
     * @return bool
     */
    public function isCLI()

isCLI uses the super-global variable $_ENV which is generally not recommended.

isCLI uses the super-global variable $_SERVER which is generally not recommended.

    {
        if (defined('STDIN')) {
            return true;
        }

        if (php_sapi_name() === 'cli') {
            return true;
        }

        if (array_key_exists('SHELL', $_ENV)) {
            return true;
        }

        if (empty($_SERVER['REMOTE_ADDR']) and !isset($_SERVER['HTTP_USER_AGENT']) and count($_SERVER['argv']) > 0) {

Using logical operators such as and instead of && is generally not recommended.

            return true;
        }

        if (!array_key_exists('REQUEST_METHOD', $_SERVER)) {
            return true;
        }

        return false;
    }

    /**
     * Checks if requested URI matches $url parameter,
     * and redirects to $url if not
     *
     * @param string $url
     * @param int $code
     */
    public function checkURL($url, $code = 302)

checkURL uses the super-global variable $_SERVER which is generally not recommended.

    {
        $components = parse_url($url);
        $request = parse_url($_SERVER['REQUEST_URI']);

        if ($components['path'] != $request['path']) {
            $redirect = $url . ($request['query'] ? '?' . $request['query'] : '');

            header("Location: " . $redirect, true, $code);
            exit();

The method checkURL() contains an exit expression.

        }
    }

    /**
     * @param $url
     */
    public function redirect($url)
    {
        header("Location: " . $url);
        exit();

The method redirect() contains an exit expression.

    }

    /**
     * @param bool $action
     * @param bool $controller
     * @param bool $module
     * @param array $params
     * @return $this
     */
    public function duplicateWithParams($action = false, $controller = false, $module = false, $params = [])
    {
        /** @var self $newRequest */
        $newRequest = $this->duplicate();
        $newRequest->setActionName($action);

$action is of type boolean, but the function expects a string.

        $newRequest->setControllerName($controller);

$controller is of type boolean, but the function expects a string.

        $newRequest->setModuleName($module);

$module is of type boolean, but the function expects a string.

        $newRequest->attributes->add($params);

        return $newRequest;
    }

    /**
     * @return bool
     */
    public function isMalicious()
    {
        return RequestDetective::isMalicious($this);
    }

    /**
     * Get the current encoded path info for the request.
     *
     * @return string
     */
    public function decodedPath()
    {
        return rawurldecode($this->path());
    }

    /**
     * Get the current path info for the request.
     *
     * @return string
     */
    public function path()
    {
        $pattern = trim($this->getPathInfo(), '/');
        return $pattern == '' ? '/' : '/' . $pattern;
    }
}