Issues in Mailer.php (master) - Issues in master - ByTIC/framework - Measure and Improve Code Quality continuously with Scrutinizer

Issues (917)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Mailer.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

class Nip_Mailer
namespace YourVendor;

class YourClass { }
{

    protected $_mail;

    public function __construct()
    {
        $this->_mail = new PHPMailer();
        $this->_mail->CharSet = "UTF-8";
//		$this->_mail->SMTPDebug = true;


        $config = Nip_Config::instance()->parse(CONFIG_PATH.'smtp.ini');
        if ($config->SMTP->host) {
            $this->_mail->IsSMTP();
            if ($config->SMTP->username) {
                $this->authSMTP($config->SMTP->host, $config->SMTP->username, $config->SMTP->password);
            } else {
                $this->_mail->Host = $config->SMTP->host;
            }
        }

        $this->setFrom($config->EMAIL->from, $config->EMAIL->from_name);
    }

    /**
     * @param string $host
     * @param string $username
     * @param string $password
     * @return $this
     */
    public function authSMTP($host, $username, $password)
    {
        $this->_mail->IsSMTP();

        $this->_mail->SMTPAuth = true;
        $this->_mail->Host = $host;
        $this->_mail->Username = $username;
        $this->_mail->Password = $password;

        return $this;
    }

    /**
     * @param string $address
     * @param string|bool $name
     * @return $this
     */
    public function setFrom($address, $name = false)
    {
        $this->_mail->From = $address;
        if ($name) {
            $this->_mail->FromName = $name;
        }

        return $this;
    }

    public function IsHTML($bool)
    {
        $this->_mail->IsHTML($bool);
    }

    /**
     * Sets flag to show SMTP debugging information
     * @return $this
     */
    public function debugSMTP()
    {
        $this->_mail->SMTPDebug = PHP_INT_MAX;

        return $this;
    }

    /**
     * @param string $address
     * @param string|bool $name
     * @return $this
     */
    public function addTo($address, $name = false)
    {
        $this->_mail->AddAddress($address, $name);

        return $this;
    }

    /**
     * @param string $address
     * @param string $name
     * @return $this
     */
    public function addBCC($address, $name = '')
    {
        $this->_mail->AddBCC($address, $name);

        return $this;
    }

    /**
     * @param string $address
     * @param string $name
     * @return $this
     */
    public function addReplyTo($address, $name = false)
    {
        $this->_mail->AddReplyTo($address, $name);

        return $this;
    }

    /**
     * @return $this
     */
    public function clearAllRecipients()
    {
        $this->_mail->ClearAllRecipients();

        return $this;
    }

    /**
     * @param string $subject
     * @return $this
     */
    public function setSubject($subject)
    {
        $this->_mail->Subject = $subject;

        return $this;
    }

    /**
     * Adds attachment
     *
     * @param string $path
     * @param string $name
     * @return $this
     */
    public function addAttachment($path, $name = '')
    {
        $this->_mail->AddAttachment($path, $name);

        return $this;
    }

    public function send()
    {
        $return = $this->_mail->Send();

        if (!$return) {
            $return = $this->_mail->ErrorInfo;
        }

        return $return;
    }


    public function setBody($body)
    {
        $this->_mail->Body = $body;

        return $this;
    }

    public function getBody()
    {
        return $this->_mail->Body;
    }

    public function setAltBody($body)
    {
        $this->_mail->AltBody = $body;

        return $this;
    }

}

1			<?php
2
3			class Nip_Mailer
			0 ignored issues – show Coding Style Compatibility introduced 2016-08-20 20:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
5
6			protected $_mail;
7
8			public function __construct()
9			{
10			$this->_mail = new PHPMailer();
11			$this->_mail->CharSet = "UTF-8";
12			// $this->_mail->SMTPDebug = true;
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-08-20 20:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this `46%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
13
14			$config = Nip_Config::instance()->parse(CONFIG_PATH.'smtp.ini');
15			if ($config->SMTP->host) {
16			$this->_mail->IsSMTP();
17			if ($config->SMTP->username) {
18			$this->authSMTP($config->SMTP->host, $config->SMTP->username, $config->SMTP->password);
19			} else {
20			$this->_mail->Host = $config->SMTP->host;
21			}
22			}
23
24			$this->setFrom($config->EMAIL->from, $config->EMAIL->from_name);
25			}
26
27			/**
28			* @param string $host
29			* @param string $username
30			* @param string $password
31			* @return $this
32			*/
33			public function authSMTP($host, $username, $password)
34			{
35			$this->_mail->IsSMTP();
36
37			$this->_mail->SMTPAuth = true;
38			$this->_mail->Host = $host;
39			$this->_mail->Username = $username;
40			$this->_mail->Password = $password;
41
42			return $this;
43			}
44
45			/**
46			* @param string $address
47			* @param string\|bool $name
48			* @return $this
49			*/
50			public function setFrom($address, $name = false)
51			{
52			$this->_mail->From = $address;
53			if ($name) {
54			$this->_mail->FromName = $name;
55			}
56
57			return $this;
58			}
59
60			public function IsHTML($bool)
61			{
62			$this->_mail->IsHTML($bool);
63			}
64
65			/**
66			* Sets flag to show SMTP debugging information
67			* @return $this
68			*/
69			public function debugSMTP()
70			{
71			$this->_mail->SMTPDebug = PHP_INT_MAX;
72
73			return $this;
74			}
75
76			/**
77			* @param string $address
78			* @param string\|bool $name
79			* @return $this
80			*/
81			public function addTo($address, $name = false)
82			{
83			$this->_mail->AddAddress($address, $name);
84
85			return $this;
86			}
87
88			/**
89			* @param string $address
90			* @param string $name
91			* @return $this
92			*/
93			public function addBCC($address, $name = '')
94			{
95			$this->_mail->AddBCC($address, $name);
96
97			return $this;
98			}
99
100			/**
101			* @param string $address
102			* @param string $name
103			* @return $this
104			*/
105			public function addReplyTo($address, $name = false)
106			{
107			$this->_mail->AddReplyTo($address, $name);
108
109			return $this;
110			}
111
112			/**
113			* @return $this
114			*/
115			public function clearAllRecipients()
116			{
117			$this->_mail->ClearAllRecipients();
118
119			return $this;
120			}
121
122			/**
123			* @param string $subject
124			* @return $this
125			*/
126			public function setSubject($subject)
127			{
128			$this->_mail->Subject = $subject;
129
130			return $this;
131			}
132
133			/**
134			* Adds attachment
135			*
136			* @param string $path
137			* @param string $name
138			* @return $this
139			*/
140			public function addAttachment($path, $name = '')
141			{
142			$this->_mail->AddAttachment($path, $name);
143
144			return $this;
145			}
146
147			public function send()
148			{
149			$return = $this->_mail->Send();
150
151			if (!$return) {
152			$return = $this->_mail->ErrorInfo;
153			}
154
155			return $return;
156			}
157
158
159			public function setBody($body)
160			{
161			$this->_mail->Body = $body;
162
163			return $this;
164			}
165
166			public function getBody()
167			{
168			return $this->_mail->Body;
169			}
170
171			public function setAltBody($body)
172			{
173			$this->_mail->AltBody = $body;
174
175			return $this;
176			}
177
178			}

GitHub Access Token became invalid

Issues (917)

Security Analysis not enabled

src/Mailer.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

ByTIC / framework

GitHub Access Token became invalid

Issues (917)

Security Analysis not enabled

src/Mailer.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like