Issues in Url.php (master) - Issues in master - ByTIC/framework - Measure and Improve Code Quality continuously with Scrutinizer

Issues (917)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Helpers/Url.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
use Nip\Dispatcher\Dispatcher;

/**
 * Class Nip_Helper_Url
 */
class Nip_Helper_Url extends Nip\Helpers\AbstractHelper
namespace YourVendor;

class YourClass { }
{
    use \Nip\Router\RouterAwareTrait;

    protected $pieces = [];

    /**
     * Singleton
     * @return Nip_Helper_URL
     */
    static public function instance()

    {
        static $instance;
        if (!($instance instanceof self)) {
            $instance = new self();
        }

        return $instance;
    }

    /**
     * @param $name
     * @param $arguments
     * @return $this|mixed
     */
    public function __call($name, $arguments)
    {
        if ($name == ucfirst($name)) {
            $this->pieces[] = Dispatcher::reverseControllerName($name);
            return $this;
        } else {
            $this->pieces[] = $name;
        }

        $name = $this->pieces ? implode(".", $this->pieces) : '';
        $this->pieces = [];
        return $this->assemble($name, isset($arguments[0]) ? $arguments[0] : null);
    }

    /**
     * @param $name
     * @param bool $params
     * @return mixed
     */
    public function assemble($name, $params = false)
    {
        return $this->getRouter()->assembleFull($name, $params);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @param $name
     * @param bool $params
     * @return mixed
     */
    public function get($name, $params = false)
    {
        return $this->assemble($name, $params);
    }

    /**
     * @param $name
     * @param bool $params
     * @return mixed|string
     */
    public function route($name, $params = false)
    {
        return $this->getRouter()->assemble($name, $params);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @param array $params
     * @return string
     */
    public function base($params = [])
    {
        $currentRoute = $this->getRouter()->getCurrent();
        $base = $currentRoute ? $currentRoute->getBase($params) : request()->root();

        return $base.($params ? "?".http_build_query($params) : '');
    }

    /**
     * Reverse of the PHP built-in function parse_url
     *
     * @see http://php.net/parse_url
     * @param array $params
     * @return string
     */
    public function build($params)
    {
        return ((isset($params['scheme'])) ? $params['scheme'] . '://' : '')
        . ((isset($params['user'])) ? $params['user'] . ((isset($params['pass'])) ? ':' . $params['pass'] : '') . '@' : '')
        . ((isset($params['host'])) ? $params['host'] : '')
        . ((isset($params['port'])) ? ':' . $params['port'] : '')
        . ((isset($params['path'])) ? $params['path'] : '')
        . ((isset($params['query'])) ? '?' . $params['query'] : '')
        . ((isset($params['fragment'])) ? '#' . $params['fragment'] : '');
    }

    /**
     * Replaces all non-alphanumeric characters and returns dash-separated string
     *
     * @param string $input
     * @return string
     */
    public function encode($input)
    {
        $chars = [
            '&#x102;' => 'a',
            '&#x103;' => 'a',
            '&#xC2;' => 'A',
            '&#xE2;' => 'a',
            '&#xCE;' => 'I',
            '&#xEE;' => 'i',
            '&#x218;' => 'S',
            '&#x219;' => 's',
            '&#x15E;' => 'S',
            '&#x15F;' => 's',
            '&#x21A;' => 'T',
            '&#x21B;' => 't',
            '&#354;' => 'T',
            '&#355;' => 't'
        ];

        $change = $with = [];
        foreach ($chars as $i => $v) {
            $change[] = html_entity_decode($i, ENT_QUOTES, 'UTF-8');
            $with[] = $v;
        }
        $input = str_replace($change, $with, $input);

        preg_match_all("/[a-z0-9]+/i", $input, $sections);
        return strtolower(implode("-", $sections[0]));
    }

    public function getRequest()
    {
    }
}


1			<?php
2			use Nip\Dispatcher\Dispatcher;
3
4			/**
5			* Class Nip_Helper_Url
6			*/
7			class Nip_Helper_Url extends Nip\Helpers\AbstractHelper
			0 ignored issues – show Coding Style Compatibility introduced 2016-08-20 20:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
8			{
9			use \Nip\Router\RouterAwareTrait;
10
11			protected $pieces = [];
12
13			/**
14			* Singleton
15			* @return Nip_Helper_URL
16			*/
17			static public function instance()
			0 ignored issues – show Coding Style introduced 2017-08-03 19:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this As per PSR2, the `static` declaration should come after the visibility declaration. Loading history...
18			{
19			static $instance;
20			if (!($instance instanceof self)) {
21			$instance = new self();
22			}
23
24			return $instance;
25			}
26
27			/**
28			* @param $name
29			* @param $arguments
30			* @return $this\|mixed
31			*/
32			public function __call($name, $arguments)
33			{
34			if ($name == ucfirst($name)) {
35			$this->pieces[] = Dispatcher::reverseControllerName($name);
36			return $this;
37			} else {
38			$this->pieces[] = $name;
39			}
40
41			$name = $this->pieces ? implode(".", $this->pieces) : '';
42			$this->pieces = [];
43			return $this->assemble($name, isset($arguments[0]) ? $arguments[0] : null);
44			}
45
46			/**
47			* @param $name
48			* @param bool $params
49			* @return mixed
50			*/
51			public function assemble($name, $params = false)
52			{
53			return $this->getRouter()->assembleFull($name, $params);
			0 ignored issues – show Documentation introduced 2017-03-05 14:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$params` is of type `boolean`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
54			}
55
56			/**
57			* @param $name
58			* @param bool $params
59			* @return mixed
60			*/
61			public function get($name, $params = false)
62			{
63			return $this->assemble($name, $params);
64			}
65
66			/**
67			* @param $name
68			* @param bool $params
69			* @return mixed\|string
70			*/
71			public function route($name, $params = false)
72			{
73			return $this->getRouter()->assemble($name, $params);
			0 ignored issues – show Documentation introduced 2017-03-05 14:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$params` is of type `boolean`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
74			}
75
76			/**
77			* @param array $params
78			* @return string
79			*/
80			public function base($params = [])
81			{
82			$currentRoute = $this->getRouter()->getCurrent();
83			$base = $currentRoute ? $currentRoute->getBase($params) : request()->root();
84
85			return $base.($params ? "?".http_build_query($params) : '');
86			}
87
88			/**
89			* Reverse of the PHP built-in function parse_url
90			*
91			* @see http://php.net/parse_url
92			* @param array $params
93			* @return string
94			*/
95			public function build($params)
96			{
97			return ((isset($params['scheme'])) ? $params['scheme'] . '://' : '')
98			. ((isset($params['user'])) ? $params['user'] . ((isset($params['pass'])) ? ':' . $params['pass'] : '') . '@' : '')
99			. ((isset($params['host'])) ? $params['host'] : '')
100			. ((isset($params['port'])) ? ':' . $params['port'] : '')
101			. ((isset($params['path'])) ? $params['path'] : '')
102			. ((isset($params['query'])) ? '?' . $params['query'] : '')
103			. ((isset($params['fragment'])) ? '#' . $params['fragment'] : '');
104			}
105
106			/**
107			* Replaces all non-alphanumeric characters and returns dash-separated string
108			*
109			* @param string $input
110			* @return string
111			*/
112			public function encode($input)
113			{
114			$chars = [
115			'Ă' => 'a',
116			'ă' => 'a',
117			'Â' => 'A',
118			'â' => 'a',
119			'Î' => 'I',
120			'î' => 'i',
121			'Ș' => 'S',
122			'ș' => 's',
123			'Ş' => 'S',
124			'ş' => 's',
125			'Ț' => 'T',
126			'ț' => 't',
127			'Ţ' => 'T',
128			'ţ' => 't'
129			];
130
131			$change = $with = [];
132			foreach ($chars as $i => $v) {
133			$change[] = html_entity_decode($i, ENT_QUOTES, 'UTF-8');
134			$with[] = $v;
135			}
136			$input = str_replace($change, $with, $input);
137
138			preg_match_all("/[a-z0-9]+/i", $input, $sections);
139			return strtolower(implode("-", $sections[0]));
140			}
141
142			public function getRequest()
143			{
144			}
145			}
146

GitHub Access Token became invalid

Issues (917)

Security Analysis not enabled

src/Helpers/Url.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

ByTIC / framework

GitHub Access Token became invalid

Issues (917)

Security Analysis not enabled

src/Helpers/Url.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like