Issues in File.php (master) - Issues in master - ByTIC/framework - Measure and Improve Code Quality continuously with Scrutinizer

Issues (917)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Filesystem/File.php (2 issues)

Labels

Bug 2

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Nip\Filesystem;

use League\Flysystem\FilesystemInterface;

/**
 * Class File
 * @package Nip\Filesystem
 *
 * @method FilesystemInterface|FileDisk getFilesystem
 */
class File extends \League\Flysystem\File
{

    /**
     * @var
     */
    protected $name;
    /**
     * @var
     */
    protected $url;

    /**
     * @inheritdoc
     */
    public function __construct(FilesystemInterface $filesystem = null, $path = null)
    {
        $this->parseNameFromPath($path);
        return parent::__construct($filesystem, $path);

    }

    /**
     * @param $path
     */
    protected function parseNameFromPath($path)
    {
        $name = pathinfo($path, PATHINFO_BASENAME);
        $this->setName($name);
    }

    /**
     * @param string $name
     * @return $this
     */
    public function setFileName($name)
    {
        $path_parts = pathinfo($this->getPath());
        $path_parts['filename'] = $name;
        $this->setPath(
            $path_parts['dirname']
            . '/' . $path_parts['filename'] . '.' . $path_parts['extension']
        );

        return $this;
    }

    /**
     * Get File path with init check
     *
     * @return string
     */
    public function getPath()
    {
        if (!$this->path) {
            $this->initPath();
        }
        return parent::getPath();
    }

    /**
     * @return void
     */
    protected function initPath()
    {
        $this->setPath($this->getPathFolder() . $this->getName());
    }

    /**
     * @inheritdoc
     */
    public function setPath($path)
    {
        $this->parseNameFromPath($path);
        return parent::setPath($path);
    }

    /**
     * @return string
     */
    public function getPathFolder()
    {
        return '/';
    }

    /**
     * @return mixed
     */
    public function getName()
    {
        if (!$this->name) {
            $this->initName();
        }
        return $this->name;
    }

    /**
     * @param string $name
     * @return $this
     */
    public function setName($name)
    {
        $this->name = $name;
        return $this;
    }

    protected function initName()
    {
        $this->name = $this->getDefaultName();
    }

    /**
     * @return string
     */
    public function getDefaultName()
    {
        return 'file';
    }

    /**
     * @return mixed
     */
    public function getUrl()
    {
        if (!$this->url) {
            $this->initUrl();
        }
        return $this->url;
    }

    protected function initUrl()
    {
        $this->url = $this->getFilesystem()->getUrl($this->getPath());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }
}


1			<?php
2
3			namespace Nip\Filesystem;
4
5			use League\Flysystem\FilesystemInterface;
6
7			/**
8			* Class File
9			* @package Nip\Filesystem
10			*
11			* @method FilesystemInterface\|FileDisk getFilesystem
12			*/
13			class File extends \League\Flysystem\File
14			{
15
16			/**
17			* @var
18			*/
19			protected $name;
20			/**
21			* @var
22			*/
23			protected $url;
24
25			/**
26			* @inheritdoc
27			*/
28			public function __construct(FilesystemInterface $filesystem = null, $path = null)
29			{
30			$this->parseNameFromPath($path);
31			return parent::__construct($filesystem, $path);
			0 ignored issues – show Bug introduced 2017-07-29 13:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this Constructors do not have meaningful return values, anything that is returned from here is discarded. Are you sure this is correct? Loading history...
32			}
33
34			/**
35			* @param $path
36			*/
37			protected function parseNameFromPath($path)
38			{
39			$name = pathinfo($path, PATHINFO_BASENAME);
40			$this->setName($name);
41			}
42
43			/**
44			* @param string $name
45			* @return $this
46			*/
47			public function setFileName($name)
48			{
49			$path_parts = pathinfo($this->getPath());
50			$path_parts['filename'] = $name;
51			$this->setPath(
52			$path_parts['dirname']
53			. '/' . $path_parts['filename'] . '.' . $path_parts['extension']
54			);
55
56			return $this;
57			}
58
59			/**
60			* Get File path with init check
61			*
62			* @return string
63			*/
64			public function getPath()
65			{
66			if (!$this->path) {
67			$this->initPath();
68			}
69			return parent::getPath();
70			}
71
72			/**
73			* @return void
74			*/
75			protected function initPath()
76			{
77			$this->setPath($this->getPathFolder() . $this->getName());
78			}
79
80			/**
81			* @inheritdoc
82			*/
83			public function setPath($path)
84			{
85			$this->parseNameFromPath($path);
86			return parent::setPath($path);
87			}
88
89			/**
90			* @return string
91			*/
92			public function getPathFolder()
93			{
94			return '/';
95			}
96
97			/**
98			* @return mixed
99			*/
100			public function getName()
101			{
102			if (!$this->name) {
103			$this->initName();
104			}
105			return $this->name;
106			}
107
108			/**
109			* @param string $name
110			* @return $this
111			*/
112			public function setName($name)
113			{
114			$this->name = $name;
115			return $this;
116			}
117
118			protected function initName()
119			{
120			$this->name = $this->getDefaultName();
121			}
122
123			/**
124			* @return string
125			*/
126			public function getDefaultName()
127			{
128			return 'file';
129			}
130
131			/**
132			* @return mixed
133			*/
134			public function getUrl()
135			{
136			if (!$this->url) {
137			$this->initUrl();
138			}
139			return $this->url;
140			}
141
142			protected function initUrl()
143			{
144			$this->url = $this->getFilesystem()->getUrl($this->getPath());
			0 ignored issues – show Bug introduced 2017-07-29 13:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you code against a concrete implementation and not the interface `League\Flysystem\FilesystemInterface` as the method `getUrl()` does only exist in the following implementations of said interface: `Nip\Filesystem\FileDisk`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
145			}
146			}
147

GitHub Access Token became invalid

Issues (917)

Security Analysis not enabled

src/Filesystem/File.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

ByTIC / framework

GitHub Access Token became invalid

Issues (917)

Security Analysis not enabled

src/Filesystem/File.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like