Issues in Controller.php (master) - Issues in master - ByTIC/framework - Measure and Improve Code Quality continuously with Scrutinizer

Issues (917)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Controller.php (8 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Nip;

use Nip\Config\ConfigAwareTrait;
use Nip\Dispatcher\Dispatcher;
use Nip\Dispatcher\DispatcherAwareTrait;
use Nip\Http\Response\Response;
use Nip\Http\Response\ResponseAwareTrait;
use Nip\Utility\Traits\NameWorksTrait;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

/**
 * Class Controller
 * @package Nip
 *
 * @method \Nip_Helper_Url Url()
 * @method \Nip_Helper_Arrays Arrays()
 * @method \Nip_Helper_Async Async()
 */
class Controller
{
    use NameWorksTrait;
    use ConfigAwareTrait;
    use DispatcherAwareTrait;
    use ResponseAwareTrait;

    protected $fullName = null;

    protected $name = null;

    protected $action = null;

    /**
     * @var Request
     */
    protected $request;

    /**
     * @var Helpers\AbstractHelper[]
     */
    protected $helpers = [];

    /**
     * Controller constructor.
     */
    public function __construct()
    {
        $name = str_replace("Controller", "", get_class($this));
        $this->name = inflector()->unclassify($name);
    }

    /**
     * @param $name
     * @param $arguments
     * @return bool|mixed
     */
    public function __call($name, $arguments)

    {
        if ($name === ucfirst($name)) {
            return $this->getHelper($name);
        }

        return trigger_error("Call to undefined method [$name] in controller [{$this->getClassName()}]", E_USER_ERROR);
    }

    /**
     * @param $name
     * @return Helpers\AbstractHelper
     */
    public function getHelper($name)
    {
        return HelperBroker::get($name);
    }

    /**
     * @return string
     */
    public function getClassName()
    {
        return str_replace("Controller", "", get_class($this));
    }

    /**
     * @param null|Request $request
     * @return Response
     */
    public function dispatch($request = null)
    {
        $request = $request ? $request : $this->getRequest();
        $this->populateFromRequest($request);

        return $this->dispatchAction($request->getActionName());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Returns the request Object
     * @return Request
     */
    public function getRequest()
    {
        if (!$this->request instanceof Request) {
            $this->request = new Request();
        }

        return $this->request;
    }

    /**
     * @param Request $request
     * @return self
     */
    public function setRequest(Request $request)

    {
        $this->request = $request;

        return $this;
    }

    /**
     * @param Request $request
     */
    public function populateFromRequest(Request $request)
    {
        $this->name = $request->getControllerName();
        $this->action = $request->getActionName();
    }

    /**
     * @param bool $action
     * @return Response
     */
    public function dispatchAction($action = false)
    {
        $action = Dispatcher::formatActionName($action);

        if ($action) {
            if ($this->validAction($action)) {
                $this->setAction($action);

                $this->parseRequest();
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
                $this->beforeAction();
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
                $this->{$action}();
                $this->afterAction();
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}

                return $this->getResponse();
            } else {
                throw new NotFoundHttpException(
                    'Controller method [' . $action . '] not found for ' . get_class($this)
                );
            }
        }

        throw new NotFoundHttpException('No action specified for ' . get_class($this));
    }

    /**
     * @param $action
     * @return bool
     */
    protected function validAction($action)
    {
        return in_array($action, get_class_methods(get_class($this)));
    }

    /**
     * Called before action
     */
    protected function parseRequest()
    {
        return true;
    }

    /**
     * Called before $this->action
     */
    protected function beforeAction()
    {
        return true;
    }

    /**
     * Called after $this->action
     */
    protected function afterAction()
    {
        return true;
    }

    /**
     * @param bool $action
     * @param bool $controller
     * @param bool $module
     * @param array $params
     * @return mixed
     */
    public function call($action = false, $controller = false, $module = false, $params = [])
    {
        $newRequest = $this->getRequest()->duplicateWithParams($action, $controller, $module, $params);

        $controller = $this->getDispatcher()->generateController($newRequest);
        $controller = $this->prepareCallController($controller, $newRequest);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

        return call_user_func_array([$controller, $action], $params);
    }

    /**
     * @param self $controller
     * @param Request $newRequest
     * @return Controller
     */
    protected function prepareCallController($controller, $newRequest)
    {
        $controller->setRequest($newRequest);
        $controller->populateFromRequest($newRequest);

        return $controller;
    }

    /**
     * @return string
     */
    public function getAction()
    {
        return $this->action;
    }

    /**
     * @param string $action
     * @return self
     */
    public function setAction($action)
    {
        $this->action = $action;

        return $this;
    }

    /**
     * @return string
     */
    public function getRootNamespace()
    {
        return $this->getApplication()->getRootNamespace();
    }

    /**
     * @return Application
     */
    public function getApplication()
    {
        return app('app');
    }

    /**
     * @param bool $action
     * @param bool $controller
     * @param bool $module
     * @param array $params
     */
    protected function forward($action = false, $controller = false, $module = false, $params = [])
    {
        $this->getDispatcher()->forward($action, $controller, $module, $params);
    }

    /**
     * @param $message
     * @param $url
     * @param string $type
     * @param bool $name
     */
    protected function flashRedirect($message, $url, $type = 'success', $name = false)
    {
        $name = $name ? $name : $this->getName();
        app('flash.messages')->add($name, $type, $message);
        $this->redirect($url);
    }

    /**
     * @return string
     */
    public function getName()
    {
        if ($this->name === null) {
            $this->initName();
        }

        return $this->name;
    }

    /**
     * @param string $name
     */
    public function setName($name)
    {
        $this->name = $name;
    }

    public function initName()
    {
        $this->setName($this->getFullName());
    }

    /**
     * @return string
     */
    public function getFullName()
    {
        if ($this->fullName === null) {
            $this->fullName = inflector()->unclassify($this->getClassName());
        }

        return $this->fullName;
    }

    /**
     * @param $url
     * @param null $code
     */
    protected function redirect($url, $code = null)
    {
        switch ($code) {
            case '301':
                header("HTTP/1.1 301 Moved Permanently");
                break;
        }
        header("Location: " . $url);
        exit();

    }
}


GitHub Access Token became invalid

Issues (917)

Security Analysis not enabled

src/Controller.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1			<?php
2
3			namespace Nip;
4
5			use Nip\Config\ConfigAwareTrait;
6			use Nip\Dispatcher\Dispatcher;
7			use Nip\Dispatcher\DispatcherAwareTrait;
8			use Nip\Http\Response\Response;
9			use Nip\Http\Response\ResponseAwareTrait;
10			use Nip\Utility\Traits\NameWorksTrait;
11			use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
12
13			/**
14			* Class Controller
15			* @package Nip
16			*
17			* @method \Nip_Helper_Url Url()
18			* @method \Nip_Helper_Arrays Arrays()
19			* @method \Nip_Helper_Async Async()
20			*/
21			class Controller
22			{
23			use NameWorksTrait;
24			use ConfigAwareTrait;
25			use DispatcherAwareTrait;
26			use ResponseAwareTrait;
27
28			protected $fullName = null;
29
30			protected $name = null;
31
32			protected $action = null;
33
34			/**
35			* @var Request
36			*/
37			protected $request;
38
39			/**
40			* @var Helpers\AbstractHelper[]
41			*/
42			protected $helpers = [];
43
44			/**
45			* Controller constructor.
46			*/
47	2		public function __construct()
48			{
49	2		$name = str_replace("Controller", "", get_class($this));
50	2		$this->name = inflector()->unclassify($name);
51	2		}
52
53			/**
54			* @param $name
55			* @param $arguments
56			* @return bool\|mixed
57			*/
58	1	View Code Duplication	public function __call($name, $arguments)
			0 ignored issues – show Duplication introduced 2017-08-03 19:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
59			{
60	1		if ($name === ucfirst($name)) {
61	1		return $this->getHelper($name);
62			}
63
64			return trigger_error("Call to undefined method [$name] in controller [{$this->getClassName()}]", E_USER_ERROR);
65			}
66
67			/**
68			* @param $name
69			* @return Helpers\AbstractHelper
70			*/
71	2		public function getHelper($name)
72			{
73	2		return HelperBroker::get($name);
74			}
75
76			/**
77			* @return string
78			*/
79			public function getClassName()
80			{
81			return str_replace("Controller", "", get_class($this));
82			}
83
84			/**
85			* @param null\|Request $request
86			* @return Response
87			*/
88			public function dispatch($request = null)
89			{
90			$request = $request ? $request : $this->getRequest();
91			$this->populateFromRequest($request);
92
93			return $this->dispatchAction($request->getActionName());
			0 ignored issues – show Documentation introduced 2017-03-05 14:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$request->getActionName()` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
94			}
95
96			/**
97			* Returns the request Object
98			* @return Request
99			*/
100			public function getRequest()
101			{
102			if (!$this->request instanceof Request) {
103			$this->request = new Request();
104			}
105
106			return $this->request;
107			}
108
109			/**
110			* @param Request $request
111			* @return self
112			*/
113			public function setRequest(Request $request)
			0 ignored issues – show Bug introduced 2017-08-03 19:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this You have injected the Request via parameter `$request`. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via `getCurrentRequest()`. Loading history...
114			{
115			$this->request = $request;
116
117			return $this;
118			}
119
120			/**
121			* @param Request $request
122			*/
123			public function populateFromRequest(Request $request)
124			{
125			$this->name = $request->getControllerName();
126			$this->action = $request->getActionName();
127			}
128
129			/**
130			* @param bool $action
131			* @return Response
132			*/
133			public function dispatchAction($action = false)
134			{
135			$action = Dispatcher::formatActionName($action);
136
137			if ($action) {
138			if ($this->validAction($action)) {
139			$this->setAction($action);
140
141			$this->parseRequest();
			0 ignored issues – show Unused Code introduced 2017-03-05 14:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to the method `Nip\Controller::parseRequest()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
142			$this->beforeAction();
			0 ignored issues – show Unused Code introduced 2016-08-20 20:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to the method `Nip\Controller::beforeAction()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
143			$this->{$action}();
144			$this->afterAction();
			0 ignored issues – show Unused Code introduced 2016-08-20 20:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to the method `Nip\Controller::afterAction()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
145
146			return $this->getResponse();
147			} else {
148			throw new NotFoundHttpException(
149			'Controller method [' . $action . '] not found for ' . get_class($this)
150			);
151			}
152			}
153
154			throw new NotFoundHttpException('No action specified for ' . get_class($this));
155			}
156
157			/**
158			* @param $action
159			* @return bool
160			*/
161			protected function validAction($action)
162			{
163			return in_array($action, get_class_methods(get_class($this)));
164			}
165
166			/**
167			* Called before action
168			*/
169			protected function parseRequest()
170			{
171			return true;
172			}
173
174			/**
175			* Called before $this->action
176			*/
177			protected function beforeAction()
178			{
179			return true;
180			}
181
182			/**
183			* Called after $this->action
184			*/
185			protected function afterAction()
186			{
187			return true;
188			}
189
190			/**
191			* @param bool $action
192			* @param bool $controller
193			* @param bool $module
194			* @param array $params
195			* @return mixed
196			*/
197			public function call($action = false, $controller = false, $module = false, $params = [])
198			{
199			$newRequest = $this->getRequest()->duplicateWithParams($action, $controller, $module, $params);
200
201			$controller = $this->getDispatcher()->generateController($newRequest);
202			$controller = $this->prepareCallController($controller, $newRequest);
			0 ignored issues – show Bug introduced 2017-03-05 14:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$controller` can be `null`; however, `prepareCallController()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
203
204			return call_user_func_array([$controller, $action], $params);
205			}
206
207			/**
208			* @param self $controller
209			* @param Request $newRequest
210			* @return Controller
211			*/
212			protected function prepareCallController($controller, $newRequest)
213			{
214			$controller->setRequest($newRequest);
215			$controller->populateFromRequest($newRequest);
216
217			return $controller;
218			}
219
220			/**
221			* @return string
222			*/
223			public function getAction()
224			{
225			return $this->action;
226			}
227
228			/**
229			* @param string $action
230			* @return self
231			*/
232			public function setAction($action)
233			{
234			$this->action = $action;
235
236			return $this;
237			}
238
239			/**
240			* @return string
241			*/
242			public function getRootNamespace()
243			{
244			return $this->getApplication()->getRootNamespace();
245			}
246
247			/**
248			* @return Application
249			*/
250			public function getApplication()
251			{
252			return app('app');
253			}
254
255			/**
256			* @param bool $action
257			* @param bool $controller
258			* @param bool $module
259			* @param array $params
260			*/
261			protected function forward($action = false, $controller = false, $module = false, $params = [])
262			{
263			$this->getDispatcher()->forward($action, $controller, $module, $params);
264			}
265
266			/**
267			* @param $message
268			* @param $url
269			* @param string $type
270			* @param bool $name
271			*/
272			protected function flashRedirect($message, $url, $type = 'success', $name = false)
273			{
274			$name = $name ? $name : $this->getName();
275			app('flash.messages')->add($name, $type, $message);
276			$this->redirect($url);
277			}
278
279			/**
280			* @return string
281			*/
282			public function getName()
283			{
284			if ($this->name === null) {
285			$this->initName();
286			}
287
288			return $this->name;
289			}
290
291			/**
292			* @param string $name
293			*/
294			public function setName($name)
295			{
296			$this->name = $name;
297			}
298
299			public function initName()
300			{
301			$this->setName($this->getFullName());
302			}
303
304			/**
305			* @return string
306			*/
307			public function getFullName()
308			{
309			if ($this->fullName === null) {
310			$this->fullName = inflector()->unclassify($this->getClassName());
311			}
312
313			return $this->fullName;
314			}
315
316			/**
317			* @param $url
318			* @param null $code
319			*/
320			protected function redirect($url, $code = null)
321			{
322			switch ($code) {
323			case '301':
324			header("HTTP/1.1 301 Moved Permanently");
325			break;
326			}
327			header("Location: " . $url);
328			exit();
			0 ignored issues – show Coding Style Compatibility introduced 2017-03-05 14:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `redirect()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
329			}
330			}
331

ByTIC / framework

GitHub Access Token became invalid

Issues (917)

Security Analysis not enabled

src/Controller.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like