ByTIC / framework

src/Application.php

<?php


namespace Nip;


use Nip\Application\ApplicationInterface;

use Nip\Application\Bootstrap\CoreBootstrapersTrait;

use Nip\Application\Traits\BindPathsTrait;

use Nip\Application\Traits\EnviromentConfiguration;

use Nip\AutoLoader\AutoLoaderAwareTrait;

use Nip\AutoLoader\AutoLoaderServiceProvider;

use Nip\Container\ContainerAliasBindingsTrait;

use Nip\Container\ServiceProviders\ServiceProviderAwareTrait;

use Nip\Database\DatabaseServiceProvider;

use Nip\Dispatcher\DispatcherAwareTrait;

use Nip\Dispatcher\DispatcherServiceProvider;

use Nip\Filesystem\FilesystemServiceProvider;

use Nip\FlashData\FlashServiceProvider;

use Nip\Http\Response\Response;

use Nip\I18n\TranslatorServiceProvider;

use Nip\Inflector\InflectorServiceProvider;

use Nip\Locale\LocaleServiceProvider;

use Nip\Logger\LoggerServiceProvider;

use Nip\Mail\MailServiceProvider;

use Nip\Mvc\MvcServiceProvider;

use Nip\Router\RouterAwareTrait;

use Nip\Router\RouterServiceProvider;

use Nip\Router\RoutesServiceProvider;

use Nip\Staging\StagingAwareTrait;

use Nip\Staging\StagingServiceProvider;

use Symfony\Component\HttpKernel\Exception\HttpException;

use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;


/**

 * Class Application

 * @package Nip

 */

class Application implements ApplicationInterface

{

    use ContainerAliasBindingsTrait;

    use CoreBootstrapersTrait;

    use ServiceProviderAwareTrait;

    use BindPathsTrait;

    use EnviromentConfiguration;

    use AutoLoaderAwareTrait;

    use RouterAwareTrait;

    use DispatcherAwareTrait;

    use StagingAwareTrait;


    /**

     * The ByTIC framework version.

     *

     * @var string

     */

    const VERSION = '1.0.1';


    /**

     * Indicates if the application has "booted".

     *

     * @var bool

     */

    protected $booted = false;


    /**

     * @var null|Request

     */

    protected $request = null;


    /**

     * Create a new Illuminate application instance.

     *

     * @param  string|null $basePath

     *

     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */

    public function __construct($basePath = null)

    {

        if ($basePath) {

The expression $basePath of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $this->setBasePath($basePath);

        }

    }


    public function setupAutoLoaderPaths()

    {

    }


    public function boot()

    {

        if ($this->isBooted()) {

            return;

        }


        $this->bootProviders();

        $this->booted = true;

    }


    /**

     * Determine if the application has booted.

     *

     * @return bool

     */

    public function isBooted()

    {

        return $this->booted;

    }


    /** @noinspection PhpUnusedParameterInspection

     *

     * @param Request $request

     * @param Response $response

     * @return Response

     */

    public function filterResponse(Response $response, Request $request)

The parameter $request is not used and could be removed.

    {

        return $response;

    }


    public function terminate()

    {

    }


    /**

     * @return array

     */

    public function getConfiguredProviders()

    {

        return [

            AutoLoaderServiceProvider::class,

            LoggerServiceProvider::class,

            InflectorServiceProvider::class,

            LocaleServiceProvider::class,

            MailServiceProvider::class,

            MvcServiceProvider::class,

            DispatcherServiceProvider::class,

            StagingServiceProvider::class,

            RouterServiceProvider::class,

            RoutesServiceProvider::class,

            DatabaseServiceProvider::class,

            TranslatorServiceProvider::class,

            FlashServiceProvider::class,

            FilesystemServiceProvider::class,

        ];

    }


    /**

     * Determine if the application configuration is cached.

     *

     * @return bool

     */

    public function configurationIsCached()

    {

        return false;

//        return file_exists($this->getCachedConfigPath());

67% of this comment could be valid code. Did you maybe forget this after debugging?

    }


    /**

     * Throw an HttpException with the given data.

     *

     * @param  int $code

     * @param  string $message

     * @param  array $headers

     * @return void

     *

     * @throws HttpException

     */

    public function abort($code, $message = '', array $headers = [])

    {

        if ($code == 404) {

            throw new NotFoundHttpException($message);

        }

        throw new HttpException($code, $message, null, $headers);

    }


    /**

     * @return string

     */

    public function getRootNamespace()

    {

        return 'App\\';

    }


    /**

     * @param Request $request

     * @return Response

     */

    protected function getResponseFromRequest($request)

    {

        if ($request->hasMCA()) {

            $response = $this->dispatchRequest($request);

            ob_get_clean();


            return $response;

        }


        throw new NotFoundHttpException('No MCA in Request');

    }

}