Scripts - Code Metrics - Inspection of "Merge branch 'develop'" - ByTIC/framework - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( c5ade0...e039e4 )

by Gabriel

created 2017-07-29 13:11 UTC

Scripts A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	158
Duplicated Lines	1.9 %

Coupling/Cohesion

Components	2
Dependencies	1

Importance

Changes

Metric	Value
dl	3
loc	158
rs	10
c	0
b	0
f	0
wmc	25
lcom	2
cbo	1

10 Methods

Rating	Name	Duplication	Size	Complexity
A	add()	0	4	1
B	addFile()	3	18	6
A	addRaw()	0	6	1
A	prepend()	0	4	1
A	__toString()	0	4	1
A	render()	0	11	4
C	renderHMTL()	0	29	7
A	buildTag()	0	4	1
A	buildURL()	0	4	1
A	renderRaw()	0	10	2

How to fix Duplicated Code

<?php

namespace Nip\Helpers\View;

/**
 * Class Scripts
 * @package Nip\Helpers\View
 */
class Scripts extends AbstractHelper
{

    /**
     * @var array
     */
    protected $files = [];

    protected $rawScripts = [];

    protected $defaultPlaceholder = "head";

    /**
     * @param $file
     * @param bool $placeholder
     * @return $this
     */
    public function add($file, $placeholder = false)
    {
        return $this->addFile($file, 'add', $placeholder);
    }

    /**
     * @param $file
     * @param string $direction
     * @param bool $placeholder
     * @return $this
     */
    public function addFile($file, $direction = 'add', $placeholder = false)
    {
        if ($placeholder === false || empty($placeholder)) {
            $placeholder = $this->defaultPlaceholder;
        }

        if (!isset($this->files[$placeholder]) || !is_array($this->files[$placeholder])) {

            $this->files[$placeholder] = [];
        }

        if ($direction == 'prepend') {
            array_unshift($this->files[$placeholder], $file);
        } else {
            $this->files[$placeholder][] = $file;
        }

        return $this;
    }

    /**
     * @param $content
     * @return $this
     */
    public function addRaw($content)
    {
        $this->rawScripts[] = $content;

        return $this;
    }

    /**
     * @param $file
     * @param bool $placeholder
     * @return Scripts
     */
    public function prepend($file, $placeholder = false)
    {
        return $this->addFile($file, 'prepend', $placeholder);
    }

    /**
     * @return string
     */
    public function __toString()
    {
        return $this->render($this->defaultPlaceholder);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @param bool $placeholder
     * @return string
     */
    public function render($placeholder = false)
    {
        if ($placeholder == false && empty($placeholder)) {

            $placeholder = $this->defaultPlaceholder;
        }

        if (isset($this->files[$placeholder])) {
            return $this->renderHMTL($this->files[$placeholder]);
        }
        return '';
    }

    /**
     * @param $files
     * @return string
     */
    public function renderHMTL($files)
    {
        $return = '';
        if (is_array($files)) {
            $internal = [];
            $external = [];

            foreach ($files as $file) {
                if (preg_match('/https?:\/\//', $file)) {
                    $external[] = $file;
                } else {
                    $internal[] = $file;
                }
            }


            if (count($external)) {
                foreach ($external as $file) {
                    $return .= $this->buildTag($file);
                }
            }

            foreach ($internal as $file) {
                $return .= $this->buildTag($this->buildURL($file));
            }
        }

        return $return;
    }

    /**
     * @param $path
     * @return string
     */
    public function buildTag($path)
    {
        return "<script type=\"text/javascript\" src=\"$path\"></script>\r\n";
    }

    /**
     * @param $source
     * @return string
     */
    public function buildURL($source)
    {
        return asset('/scripts/' . $source . '.js');
    }

    /**
     * @return string
     */
    public function renderRaw()
    {
        $return = '';
        if (count($this->rawScripts)) {
            $return .= '<script type="text/javascript">';
            $return .= implode("\r\n", $this->rawScripts);
            $return .= '</script>';
        }
        return $return;
    }
}


1		<?php
2
3		namespace Nip\Helpers\View;
4
5		/**
6		* Class Scripts
7		* @package Nip\Helpers\View
8		*/
9		class Scripts extends AbstractHelper
10		{
11
12		/**
13		* @var array
14		*/
15		protected $files = [];
16
17		protected $rawScripts = [];
18
19		protected $defaultPlaceholder = "head";
20
21		/**
22		* @param $file
23		* @param bool $placeholder
24		* @return $this
25		*/
26		public function add($file, $placeholder = false)
27		{
28		return $this->addFile($file, 'add', $placeholder);
29		}
30
31		/**
32		* @param $file
33		* @param string $direction
34		* @param bool $placeholder
35		* @return $this
36		*/
37		public function addFile($file, $direction = 'add', $placeholder = false)
38		{
39		if ($placeholder === false \|\| empty($placeholder)) {
40		$placeholder = $this->defaultPlaceholder;
41		}
42
43	View Code Duplication	if (!isset($this->files[$placeholder]) \|\| !is_array($this->files[$placeholder])) {
		0 ignored issues – show Duplication introduced 2017-07-29 13:16 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
44		$this->files[$placeholder] = [];
45		}
46
47		if ($direction == 'prepend') {
48		array_unshift($this->files[$placeholder], $file);
49		} else {
50		$this->files[$placeholder][] = $file;
51		}
52
53		return $this;
54		}
55
56		/**
57		* @param $content
58		* @return $this
59		*/
60		public function addRaw($content)
61		{
62		$this->rawScripts[] = $content;
63
64		return $this;
65		}
66
67		/**
68		* @param $file
69		* @param bool $placeholder
70		* @return Scripts
71		*/
72		public function prepend($file, $placeholder = false)
73		{
74		return $this->addFile($file, 'prepend', $placeholder);
75		}
76
77		/**
78		* @return string
79		*/
80		public function __toString()
81		{
82		return $this->render($this->defaultPlaceholder);
		0 ignored issues – show Documentation introduced 2017-07-29 13:16 UTC by Report Bug Copy Issue Report `$this->defaultPlaceholder` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
83		}
84
85		/**
86		* @param bool $placeholder
87		* @return string
88		*/
89		public function render($placeholder = false)
90		{
91		if ($placeholder == false && empty($placeholder)) {
		0 ignored issues – show Coding Style Best Practice introduced 2017-07-29 13:16 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
92		$placeholder = $this->defaultPlaceholder;
93		}
94
95		if (isset($this->files[$placeholder])) {
96		return $this->renderHMTL($this->files[$placeholder]);
97		}
98		return '';
99		}
100
101		/**
102		* @param $files
103		* @return string
104		*/
105		public function renderHMTL($files)
106		{
107		$return = '';
108		if (is_array($files)) {
109		$internal = [];
110		$external = [];
111
112		foreach ($files as $file) {
113		if (preg_match('/https?:\/\//', $file)) {
114		$external[] = $file;
115		} else {
116		$internal[] = $file;
117		}
118		}
119
120
121		if (count($external)) {
122		foreach ($external as $file) {
123		$return .= $this->buildTag($file);
124		}
125		}
126
127		foreach ($internal as $file) {
128		$return .= $this->buildTag($this->buildURL($file));
129		}
130		}
131
132		return $return;
133		}
134
135		/**
136		* @param $path
137		* @return string
138		*/
139		public function buildTag($path)
140		{
141		return "<script type=\"text/javascript\" src=\"$path\"></script>\r\n";
142		}
143
144		/**
145		* @param $source
146		* @return string
147		*/
148		public function buildURL($source)
149		{
150		return asset('/scripts/' . $source . '.js');
151		}
152
153		/**
154		* @return string
155		*/
156		public function renderRaw()
157		{
158		$return = '';
159		if (count($this->rawScripts)) {
160		$return .= '<script type="text/javascript">';
161		$return .= implode("\r\n", $this->rawScripts);
162		$return .= '</script>';
163		}
164		return $return;
165		}
166		}
167

ByTIC / framework

GitHub Access Token became invalid

Push — master ( c5ade0...e039e4 )

Scripts A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

10 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like