ContainerPersistenceTrait - Code Metrics - Inspection of "Merge branch 'develop'" - ByTIC/framework - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( c5ade0...e039e4 )

by Gabriel

created 2017-07-29 13:11 UTC

ContainerPersistenceTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
dl	0
loc	33
rs	10
c	0
b	0
f	0
wmc	3
lcom	1
cbo	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getInstance()	0	7	2
A	setInstance()	0	4	1

<?php

namespace Nip\Container\Traits;

/**
 * Class ContainerPersistenceTrait
 * @package Nip\Container
 */
trait ContainerPersistenceTrait
{
    /**
     * The current globally available container (if any).
     *
     * @var static
     */
    protected static $instance;

    /**
     * Set the globally available instance of the container.
     *
     * @return static
     */
    public static function getInstance()
    {
        if (is_null(static::$instance)) {
            static::$instance = new static;
        }
        return static::$instance;
    }

    /**
     * Set the shared instance of the container.
     *
     * @param  ContainerInterface|null $container
     * @return static
     */
    public static function setInstance(ContainerInterface $container = null)
    {
        return static::$instance = $container;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }
}

1			<?php
2
3			namespace Nip\Container\Traits;
4
5			/**
6			* Class ContainerPersistenceTrait
7			* @package Nip\Container
8			*/
9			trait ContainerPersistenceTrait
10			{
11			/**
12			* The current globally available container (if any).
13			*
14			* @var static
15			*/
16			protected static $instance;
17
18			/**
19			* Set the globally available instance of the container.
20			*
21			* @return static
22			*/
23			public static function getInstance()
24			{
25			if (is_null(static::$instance)) {
26			static::$instance = new static;
27			}
28			return static::$instance;
29			}
30
31			/**
32			* Set the shared instance of the container.
33			*
34			* @param ContainerInterface\|null $container
35			* @return static
36			*/
37			public static function setInstance(ContainerInterface $container = null)
38			{
39			return static::$instance = $container;
			0 ignored issues – show Documentation Bug introduced 2017-07-29 13:16 UTC by Report Bug Copy Issue Report It seems like `$container` can also be of type `object<Nip\Container\Traits\ContainerInterface>`. However, the property `$instance` is declared as type `object<Nip\Container\Tra...tainerPersistenceTrait>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
40			}
41			}

ByTIC / framework

GitHub Access Token became invalid

Push — master ( c5ade0...e039e4 )

ContainerPersistenceTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like