Nip_File_Upload::valid() - Code Metrics - ByTIC/framework - Measure and Improve Code Quality continuously with Scrutinizer

Nip_File_Upload::valid() C
last analyzed 2017-08-07 20:36 UTC

↳ Parent: Nip_File_Upload

Complexity

Conditions	12
Paths	48

Size

Total Lines	27
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	156

Importance

Changes

Metric	Value
cc	12
eloc	16
nc	48
nop	0
dl	0
loc	27
ccs	0
cts	16
cp	0
crap	156
rs	5.1612
c	0
b	0
f	0

How to fix Complexity

<?php

class Nip_File_Upload extends Nip_File
namespace YourVendor;

class YourClass { }
{

    protected $_error;
    protected $_tmp_name;

	public function  __construct($data = array())
	{
		if ($data) {

            $this->_name = $data['name'];
            $this->_tmp_name = $data['tmp_name'];

            parent::__construct(TMP_PATH . $this->_tmp_name);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		}
	}

	public function valid()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
	{
		$result = false;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $max_upload = ini_get("post_max_size");
		$unit = strtoupper(substr($max_upload, -1));
		$multiplier = ($unit == 'M') ? 1048576 : (($unit == 'K') ? 1024 : (($unit == 'G') ? 1073741824 : 1));

		if ($max_upload && ((int) $_SERVER['CONTENT_LENGTH'] > $multiplier * (int) $max_upload)) {
            return self::ERROR_MAX_POST_SIZE;
		}

		if (!$this->getPath()) {
            return false;

		} else if (isset($this->error) && $this->error != 0) {

            return false;

		} else if (!isset($this->_tmp_name) || !@is_uploaded_file($this->_tmp_name)) {
            return false;

		} else if (!isset($this->_name)) {
            return false;
		}

		return true;
	}

	public function upload($path)
	{
		return $this->move($path);
	}

}

GitHub Access Token became invalid

Nip_File_Upload::valid() C
last analyzed 2017-08-07 20:36 UTC

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

1			<?php
2
3			class Nip_File_Upload extends Nip_File
			0 ignored issues – show Coding Style Compatibility introduced 2016-08-20 20:47 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
5
6			protected $_error;
7			protected $_tmp_name;
8
9			public function __construct($data = array())
10			{
11			if ($data) {
			0 ignored issues – show Bug Best Practice introduced 2016-08-20 20:47 UTC by Report Bug Copy Issue Report The expression `$data` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
12			$this->_name = $data['name'];
13			$this->_tmp_name = $data['tmp_name'];
14
15			parent::__construct(TMP_PATH . $this->_tmp_name);
			0 ignored issues – show Documentation introduced 2016-08-20 20:47 UTC by Report Bug Copy Issue Report `TMP_PATH . $this->_tmp_name` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
16			}
17			}
18
19			public function valid()
			0 ignored issues – show Coding Style introduced 2017-08-03 19:41 UTC by Report Bug Copy Issue Report `valid` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
20			{
21			$result = false;
			0 ignored issues – show Unused Code introduced 2016-08-20 20:47 UTC by Report Bug Copy Issue Report `$result` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
22
23			$max_upload = ini_get("post_max_size");
24			$unit = strtoupper(substr($max_upload, -1));
25			$multiplier = ($unit == 'M') ? 1048576 : (($unit == 'K') ? 1024 : (($unit == 'G') ? 1073741824 : 1));
26
27			if ($max_upload && ((int) $_SERVER['CONTENT_LENGTH'] > $multiplier * (int) $max_upload)) {
28			return self::ERROR_MAX_POST_SIZE;
29			}
30
31			if (!$this->getPath()) {
32			return false;
33
34			} else if (isset($this->error) && $this->error != 0) {
			0 ignored issues – show Bug introduced 2016-08-20 20:47 UTC by Report Bug Copy Issue Report The property `error` does not seem to exist. Did you mean `_error`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
35			return false;
36
37			} else if (!isset($this->_tmp_name) \|\| !@is_uploaded_file($this->_tmp_name)) {
38			return false;
39
40			} else if (!isset($this->_name)) {
41			return false;
42			}
43
44			return true;
45			}
46
47			public function upload($path)
48			{
49			return $this->move($path);
50			}
51
52			}

ByTIC / framework

GitHub Access Token became invalid

Nip_File_Upload::valid() C last analyzed 2017-08-07 20:36 UTC

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like

Nip_File_Upload::valid() C
last analyzed 2017-08-07 20:36 UTC