Nip\Router\Router

Complexity

Total Complexity

25

Size/Duplication

Total Lines	193
Duplicated Lines	12.44 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes

0

14 Methods

Rating	Name	Duplication	Size	Complexity
A	connected()	0	4	1
A	getRoute()	0	4	1
A	getRoutes()	0	8	2
A	initRoutes()	0	4	1
A	newRoutesCollection()	0	4	1
B	route()	0	22	4
A	setCurrent()	0	6	1
A	assembleFull()	12	12	2
B	getDefaultRoute()	0	18	6
A	getRequest()	0	4	1
A	setRequest()	0	4	1
A	assemble()	12	12	2
A	getCurrent()	0	4	1
A	hasRoute()	0	4	1

<?php

namespace Nip\Router;

use Nip\Request;
use Nip\Router\Route\AbstractRoute as Route;
use Psr\Http\Message\ServerRequestInterface;

/**
 * Class Router
 * @package Nip\Router
 */
class Router
{

    /**
     * @var \Nip\Request
     */
    protected $request;


    /**
     * @var Route
     */
    protected $route;

    /**
     * @var RouteCollection|Route[]
     */
    protected $routes = null;

    /**
     * @param $name
     * @return bool
     */
    public function connected($name)
    {
        return ($this->getRoute($name) instanceof Route);
    }

    /**
     * @param $name
     * @return Route
     */
    public function getRoute($name)
    {
        return $this->getRoutes()->get($name);
    }

    /**
     * @return RouteCollection
     */
    public function getRoutes()
    {
        if ($this->routes === null) {
            $this->initRoutes();
        }

        return $this->routes;

The expression $this->routes; of type Nip\Router\RouteCollection|Nip\Router\Route\AbstractRoute[] adds the type Nip\Router\Route\AbstractRoute[] to the return on line 59 which is incompatible with the return type documented by Nip\Router\Router::getRoutes of type Nip\Router\RouteCollection.

    }

    protected function initRoutes()
    {
        $this->routes = $this->newRoutesCollection();
    }

    /**
     * @return RouteCollection
     */
    protected function newRoutesCollection()
    {
        return new RouteCollection();
    }

    /**
     * @param Request|ServerRequestInterface $request
     * @return array
     */
    public function route($request)
    {
        $current = false;
        $uri = $request->path();

        foreach ($this->routes as $name => $route) {
            $route->setRequest($request);
            if ($route->match($uri)) {
                $current = $route;
                break;
            }
        }

        if ($current instanceof Route) {
            $this->setCurrent($current);
            $current->populateRequest();

            return $current->getParams() + $current->getMatches();
        } else {
            return [];
        }
    }

    /**
     * @param Route $route
     * @return $this
     */
    public function setCurrent($route)
    {
        $this->route = $route;

        return $this;
    }

    /**
     * @param $name
     * @param array $params
     * @return string
     */
    public function assembleFull($name, $params = [])

This method seems to be duplicated in your project.

    {
        $route = $this->getDefaultRoute($name, $params);
        if ($route) {
            $route->setRequest($this->getRequest());
            return $route->assembleFull($params);
        }

        trigger_error("Route \"$name\" not connected", E_USER_ERROR);

        return null;
    }

    /**
     * @param $name
     * @param array $params
     * @return Route
     */
    public function getDefaultRoute($name, &$params = [])
    {
        $route = $this->getRoute($name);
        if (!$route) {
            $parts = explode(".", $name);
            $count = count($parts);
            if ($count <= 3) {
                if (in_array(reset($parts), app('mvc.modules')->getNames())) {
                    $module = array_shift($parts);
                    $params['controller'] = isset($parts[0]) ? $parts[0] : null;
                    $params['action'] = isset($parts[1]) ? $parts[1] : null;
                    $route = $this->getRoute($module.'.default');

Are you sure the assignment to $route is correct as $this->getRoute($module . '.default') (which targets Nip\Router\Router::getRoute()) seems to always return null.

                }
            }
        }

        return $route;
    }

    /**
     * @return mixed
     */
    public function getRequest()
    {
        return $this->request;
    }

    /**
     * @param mixed $request
     */
    public function setRequest($request)
    {
        $this->request = $request;
    }

    /**
     * @param $name
     * @param array $params
     * @return mixed|string
     */
    public function assemble($name, $params = [])

This method seems to be duplicated in your project.

    {
        $route = $this->getDefaultRoute($name, $params);

        if ($route) {
            $route->setRequest($this->getRequest());
            return $route->assemble($params);
        }

        trigger_error("Route \"$name\" not connected", E_USER_ERROR);
        return null;
    }

    /**
     * @return Route
     */
    public function getCurrent()
    {
        return $this->route;
    }

    /**
     * @param $name
     * @return bool
     */
    public function hasRoute($name)
    {
        return $this->getRoutes()->has($name);
    }
}