Jar - Code Metrics - ByTIC/framework - Measure and Improve Code Quality continuously with Scrutinizer

Jar A
last analyzed 2017-08-07 20:36 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	1

Test Coverage

Coverage

Importance

Changes

Metric	Value
dl	0
loc	58
ccs	0
cts	29
cp	0
rs	10
c	0
b	0
f	0
wmc	10
lcom	2
cbo	1

7 Methods

Rating	Name	Size	Complexity
A	__construct()	3	1
A	newCookie()	8	1
A	initDefaults()	7	1
A	setDefaults()	5	2
A	setDefault()	5	2
A	getDefaults()	3	1
A	instance()	6	2

<?php

namespace Nip\Cookie;

class Jar {

    protected $_defaults;

    public static $instance;

    public function  __construct() {
        $this->initDefaults();
    }

    /**
     * @return Cookie
    */
    public function newCookie() {
        $cookie = new Cookie();
        $defaults = $this->getDefaults();
        $cookie->setPath($defaults['path']);
        $cookie->setDomain($defaults['domain']);
        $cookie->setExpireTimer($defaults['expireTimer']);
        return $cookie;
    }

    public function initDefaults() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
        $this->_defaults = array(
            'path'   => '/',
            'domain' => $_SERVER['SERVER_NAME'],
            'expireTimer' => 6 * 60 *60,
        );
    }

    public function setDefaults($defaults) {
        foreach ($defaults as $name => $value) {
            $this->setDefault($name, $value);
        }
    }

    public function setDefault($name, $value = NULL) {
        if ($value !== NULL) {
            $this->_defaults[$name] = $value;
        }
    }

    public function getDefaults() {
        return $this->_defaults;
    }

	/**
	 * Singleton
	 *
	 * @return self
	 */
    public static function instance() {
        if (!self::$instance instanceof self) {
            self::$instance = new self;
        }
        return self::$instance;
    }
}

1			<?php
2
3			namespace Nip\Cookie;
4
5			class Jar {
6
7			protected $_defaults;
8
9			public static $instance;
10
11			public function __construct() {
12			$this->initDefaults();
13			}
14
15			/**
16			* @return Cookie
17			*/
18			public function newCookie() {
19			$cookie = new Cookie();
20			$defaults = $this->getDefaults();
21			$cookie->setPath($defaults['path']);
22			$cookie->setDomain($defaults['domain']);
23			$cookie->setExpireTimer($defaults['expireTimer']);
24			return $cookie;
25			}
26
27			public function initDefaults() {
			0 ignored issues – show Coding Style introduced 2017-08-03 19:41 UTC by Report Bug Copy Issue Report `initDefaults` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
28			$this->_defaults = array(
29			'path' => '/',
30			'domain' => $_SERVER['SERVER_NAME'],
31			'expireTimer' => 6 * 60 *60,
32			);
33			}
34
35			public function setDefaults($defaults) {
36			foreach ($defaults as $name => $value) {
37			$this->setDefault($name, $value);
38			}
39			}
40
41			public function setDefault($name, $value = NULL) {
42			if ($value !== NULL) {
43			$this->_defaults[$name] = $value;
44			}
45			}
46
47			public function getDefaults() {
48			return $this->_defaults;
49			}
50
51			/**
52			* Singleton
53			*
54			* @return self
55			*/
56			public static function instance() {
57			if (!self::$instance instanceof self) {
58			self::$instance = new self;
59			}
60			return self::$instance;
61			}
62			}

ByTIC / framework

GitHub Access Token became invalid

Jar A last analyzed 2017-08-07 20:36 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

7 Methods

Duplication Side-by-Side

Filter issues like

Jar A
last analyzed 2017-08-07 20:36 UTC