Nip_Helper_Hash

Complexity

Total Complexity

7

Size/Duplication

Total Lines	38
Duplicated Lines	5.26 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	uhash()	2	18	5
A	instance()	0	8	2

<?php

class Nip_Helper_Hash extends Nip\Helpers\AbstractHelper

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    function uhash($num, $len = 10, $base = 36)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $golden_primes = array(
            36 => array(1, 23, 809, 28837, 1038073, 37370257, 1345328833)
        );
        $gp = $golden_primes[$base];
        $maxlen = count($gp);
        $len = $len > ($maxlen - 1) ? ($maxlen - 1) : $len;
        while ($len < $maxlen && pow($base, $len) < $num)
            $len++;
        if ($len >= $maxlen)

This code seems to be duplicated across your project.

            throw new Exception($num." out of range (max ".pow($base, $maxlen - 1).")");
        $ceil = pow($base, $len);
        $prime = $gp[$len];
        $dechash = ($num * $prime) % $ceil;
        $hash = base_convert($dechash, 10, $base);
        return str_pad($hash, $len, "0", STR_PAD_LEFT);
    }

	/**
	 * Singleton
	 *
	 * @return Nip_Helper_Hash
	 */
	static public function instance()

As per PSR2, the static declaration should come after the visibility declaration.

	{
		static $instance;
		if (!($instance instanceof self)) {
			$instance = new self();
		}
		return $instance;
	}


}