ByTIC / Common

src/Payments/Gateways/Providers/Mobilpay/Api/Request/Notify.php

Doc Comments +1 added lines, -1 removed lines

@@ -337,7 +337,7 @@
     }
 
     /**
-     * @return null
+     * @return string
      */
     public function getCrc()
     {

Spacing +1 added lines, -1 removed lines

@@ -212,7 +212,7 @@
         $attr->nodeValue = date('YmdHis');
         $xmlNotifyElem->appendChild($attr);
 
-        $this->_crc = md5(rand().time());
+        $this->_crc = md5(rand() . time());
         $attr = $xmlDoc->createAttribute('crc');
         $attr->nodeValue = $this->_crc;
         $xmlNotifyElem->appendChild($attr);

src/Payments/Gateways/Providers/Mobilpay/Api/Request/Sms.php

Doc Comments +1 added lines, -1 removed lines

@@ -121,7 +121,7 @@
     }
 
     /**
-     * @return mixed
+     * @return Sms
      */
     protected function prepare()
     {

src/Payments/Gateways/Providers/Mobilpay/Form.php

Doc Comments +1 added lines, -1 removed lines

@@ -93,7 +93,7 @@
     }
 
     /**
-     * @param $type
+     * @param string $type
      * @return MobilpayFile
      */
     public function getFileModel($type)

src/Payments/Gateways/Providers/Mobilpay/Message/ServerCompletePurchaseRequest.php

Doc Comments +2 added lines, -2 removed lines

@@ -82,7 +82,7 @@ 
     }
 
     /**
-     * @return bool
+     * @return boolean|null
      */
     protected function decodeRequestData()
     {
@@ -159,7 +159,7 @@ 
     }
 
     /** @noinspection PhpMissingParentCallCommonInspection
-     * @return mixed
+     * @return boolean
      */
     protected function isProviderRequest()
     {

src/Payments/Gateways/Providers/Payu/Api/LiveUpdate.php

Doc Comments +4 added lines, -3 removed lines

@@ -798,7 +798,7 @@ 
      *
      * @access        public
      * @param        $pricesCurrency string[3]
-     * @return        true
+     * @return        boolean
      */
     function setCurrency($pricesCurrency = 'RON')
     {
@@ -839,7 +839,7 @@ 
      *
      * @access        public
      * @param        $pricesCurrency string[3]
-     * @return        true
+     * @return        boolean
      */
     function setPricesCurrency($pricesCurrency = 'RON')
     {
@@ -1326,7 +1326,7 @@ 
      * createHiddenField
      *
      * @access        private
-     * @param        $fieldName    string    name/id of the hidden field in html code
+     * @param        string $fieldName    string    name/id of the hidden field in html code
      * @param        $fieldValue    string    field/fields value/values
      * @param        $isArray    bool    specifies if it should generate an array or not
      * @return        string    output html code
@@ -1357,6 +1357,7 @@ 
      *
      * @param        $array string secret key
      * @param        @data string the source string that will be converted into hmac hash
+     * @param string $data
      * @return        string hmac hash
      */
     function hmac($data)

Spacing +3 added lines, -3 removed lines

@@ -1338,7 +1338,7 @@ 
         if ($isArray) {
             for ($i = 0; $i < count($fieldValue); $i++) {
                 $fieldValue[$i] = htmlspecialchars($fieldValue[$i]);
-                $retval .= "<input name=\"".$fieldName."[]\" type=\"hidden\" value=\"".$fieldValue[$i]."\" id=\"$fieldName\">\n";
+                $retval .= "<input name=\"" . $fieldName . "[]\" type=\"hidden\" value=\"" . $fieldValue[$i] . "\" id=\"$fieldName\">\n";
                 //$retval .= "<input name=\"".$fieldName."[]\" type=\"text\" value=\"".$fieldValue[$i]."\" id=\"$fieldName\">\n";
             }
         } else {
@@ -1373,7 +1373,7 @@ 
         $k_ipad = $key ^ $ipad;
         $k_opad = $key ^ $opad;
 
-        return md5($k_opad.pack("H*", md5($k_ipad.$data)));
+        return md5($k_opad . pack("H*", md5($k_ipad . $data)));
     }
 
     /**
@@ -1450,7 +1450,7 @@ 
         $retval = "";
         //$string = htmlspecialchars($string);
         $size = strlen($string);
-        $retval = $size.$string;
+        $retval = $size . $string;
 
         return $retval;
     }

src/Payments/Gateways/Providers/Payu/Message/ServerCompletePurchaseRequest.php

Doc Comments +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
     }
 
     /**
-     * @param $data
+     * @param string $data
      * @return string
      */
     protected function generateHmac($data)

src/Payments/Gateways/Providers/Romcard/Romcard.php

Doc Comments +4 added lines

@@ -175,6 +175,10 @@
         return $this->_hash($key, $str);
     }
 
+    /**
+     * @param string $key
+     * @param null|string $data
+     */
     private function _hash($key, $data)
     {
         $blocksize = 64;

Spacing +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
             'MERCH_GMT' => '',
             'TIMESTAMP' => gmdate("YmdHis"),
             'NONCE' => md5(microtime() . mt_rand()),
-            'BACKREF' => '',   // prenume
+            'BACKREF' => '', // prenume
         );
 
         $this->data['response'] = array(

src/Payments/Models/Purchase/Traits/IsPurchasableModelTrait.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use ByTIC\Common\Payments\Gateways\Providers\AbstractGateway\Message\PurchaseRequest;
 use ByTIC\Common\Payments\Gateways\Providers\AbstractGateway\Message\RedirectResponse\RedirectTrait;
-use ByTIC\Common\Payments\Models\BillingRecord\Traits\RecordTrait as BillingRecord;
 use ByTIC\Common\Payments\Models\BillingRecord\Traits\RecordTrait as BillingRecordTrait;
 use ByTIC\Common\Payments\Models\Methods\Traits\RecordTrait;
 use ByTIC\Common\Records\Records;

Spacing +1 added lines, -1 removed lines

@@ -97,7 +97,7 @@
      */
     public function getConfirmStatusTitle()
     {
-        return $this->getManager()->getMessage('confirm.'.$this->getStatus()->getName());
+        return $this->getManager()->getMessage('confirm.' . $this->getStatus()->getName());
     }
 
     /**

src/Records/Emails/Builder/AbstractBuilder.php

Doc Comments +4 added lines, -4 removed lines

@@ -110,7 +110,7 @@ 
     }
 
     /**
-     * @return EmailTrait
+     * @return Record
      */
     protected function newBlankEmail()
     {
@@ -124,7 +124,7 @@ 
 
     /**
      * @param EmailTrait $email
-     * @return mixed
+     * @return EmailTrait
      */
     protected function hydrateEmail($email)
     {
@@ -145,7 +145,7 @@ 
     }
 
     /**
-     * @return \Record
+     * @return Record
      */
     public function getItem()
     {
@@ -153,7 +153,7 @@ 
     }
 
     /**
-     * @param Record|BuilderAwareTrait $item
+     * @param BuilderAwareTrait $item
      * @return $this
      */
     public function setItem($item)