ByTIC\Common\Records\Traits\Media\Files\RecordTrait

Complexity

Total Complexity

23

Size/Duplication

Total Lines	176
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	1	Features	1

14 Methods

Rating	Name	Duplication	Size	Complexity
A	getFileURL()	0	4	1
A	uploadFile()	0	10	2
A	getNewFile()	0	9	1
A	getFileModelName()	0	6	2
A	getFileModelNamespaced()	0	6	2
A	getFileModelNameDefault()	0	8	2
A	removeFile()	0	10	2
A	checkFiles()	0	7	2
A	findFiles()	0	7	2
A	getFilesPath()	0	4	1
A	addNewFileFromArray()	0	6	1
A	appendFile()	0	4	1
A	getFiles()	0	5	1
A	setFiles()	0	11	3

<?php

namespace ByTIC\Common\Records\Traits\Media\Files;

use ByTIC\Common\Records\Media\Files\Model as ModelFile;

/**
 * Class RecordTrait
 * @package ByTIC\Common\Records\Traits\Media\Files
 */
trait RecordTrait
{
    use \ByTIC\Common\Records\Traits\AbstractTrait\RecordTrait;

    /**
     * @var ModelFile[]
     */
    public $files = null;

    /**
     * @param ModelFile $file
     * @return string
     */
    public function getFileURL($file)
    {
        return $this->getUploadURL() . $file->getName();

It seems like getUploadURL() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param $fileData
     * @return bool|ModelFile
     */
    public function uploadFile($fileData)
    {
        $file = $this->getNewFile();

        if ($file->upload($fileData)) {
            return $file;
        }

        return false;
    }

    /**
     * File factory
     *
     * @param null $type
     *
     * @return ModelFile
     */
    public function getNewFile($type = null)
    {
        $class = $this->getFileModelName($type);
        /** @var ModelFile $file */
        $file = new $class();
        $file->setModel($this);
        $file->setFilesystem($this->getFilesystemDisk());

The method getFilesystemDisk() does not exist on ByTIC\Common\Records\Traits\Media\Files\RecordTrait. Did you maybe mean getFiles()?

        return $file;
    }

    /**
     * @param null $type
     * @return string
     */
    public function getFileModelName($type = null)
    {
        $name = $this->isNamespaced() ? $this->getFileModelNamespaced($type) : $this->getFileModelNameDefault($type);

It seems like isNamespaced() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $name;
    }

    /**
     * @param null $type
     * @return string
     */
    public function getFileModelNamespaced($type = null)
    {
        $type = $type ? $type : 'Generic';

        return $this->getManager()->getModelNamespace() . 'Files\\' . ucfirst($type);
    }

    /**
     * @param null $type
     * @return string
     */
    public function getFileModelNameDefault($type = null)
    {
        if ($type) {
            return $this->getManager()->getModel() . "_File_" . ucfirst($type);
        }

        return $this->getManager()->getModel() . "_File";
    }

    /**
     * @param $request
     * @return bool
     */
    public function removeFile($request)
    {
        $this->checkFiles();

        if ($this->files[$request['file']]) {
            $this->files[$request['file']]->delete();
        }

        return true;
    }

    /**
     * Check if files have been inited
     *
     * @return ModelFile[]|null
     */
    public function checkFiles()
    {
        if ($this->files === null) {
            $this->findFiles();
        }
        return $this->files;
    }

    /**
     * Find files
     *
     * @return void
     */
    public function findFiles()
    {
        $files = $this->getFilesystemDisk()->listContents($this->getFilesPath());

The method getFilesystemDisk() does not exist on ByTIC\Common\Records\Traits\Media\Files\RecordTrait. Did you maybe mean getFiles()?

        foreach ($files as $fileData) {
            $this->addNewFileFromArray($fileData);
        }
    }

    /**
     * @return string
     */
    public function getFilesPath()
    {
        return '/files/' . $this->getManager()->getTable() . '/' . $this->id . '/';
    }

    /**
     * @param $data
     */
    public function addNewFileFromArray($data)
    {
        $file = $this->getNewFile();
        $file->setPath($data['path']);
        $this->appendFile($file);
    }

    /**
     * @param ModelFile $file
     */
    public function appendFile($file)
    {
        $this->files[$file->getName()] = $file;
    }

    /**
     * @return ModelFile[]
     */
    public function getFiles(): array
    {
        $this->checkFiles();
        return $this->files;
    }

    /**
     * @param array $files
     */
    public function setFiles($files = [])
    {
        if ($files) {

The expression $files of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($files as $name) {
                $file = $this->getNewFile();
                $file->setName($name);

                $this->files[$name] = $file;
            }
        }
    }
}