BurningFlipside / VolunteerSystem

app/class.VolunteerDepartment.php

<?php
class VolunteerDepartment extends VolunteerObject
{
    public function __construct($departmentID, $dbData = null)
    {
        parent::__construct($departmentID, $dbData, 'departments', 'departmentID');
    }

    public function getLeadEmails()
    {
        $leadTitle = $this->dbData['lead'];
        $auth = \AuthProvider::getInstance();
        $users = $auth->getUsersByFilter(new \Data\Filter('title eq '.$leadTitle), array('mail'));
        if(empty($users))
        {
            return null;
        }
        $count = count($users);
        for($i = 0; $i < $count; $i++)
        {
            $users[$i] = $users[$i]['mail'];
        }
        return $users;
    }

    public static function getPrivateDepartments()
    {
        $dataTable = DataSetFactory::getDataTableByNames('fvs', 'departments');
        $filter = new \Data\Filter('public eq false');
        $depts = $dataTable->read($filter);
        $res = array();
        if(empty($depts))
        {
            return $res;
        }
        $count = count($depts);

It seems like $depts can also be of type boolean; however, parameter $var of count() does only seem to accept Countable|array, maybe add an additional type check?

        for($i = 0; $i < $count; $i++)
        {
            array_push($res, $depts[$i]['departmentID']);
        }
        return $res;
    }
}