Issues in class.SimplePDF.php - New Issues - Inspection of "Reduce DepartmentAPI complexity" - BurningFlipside/VolunteerSystem - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — FVSv2 ( 1cad04...78f5f9 )

by Patrick

created 2019-06-20 19:29 UTC

app/Schedules/class.SimplePDF.php (1 issue)

Labels

Best Practice 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Schedules;

class SimplePDF extends \PDF\PDF
{
    use ShiftSchedule;

    protected $department;
    protected $shifts;

    function __construct($department, $shifts)

    {
        parent::__construct();
        $this->department = $department;
        $this->shifts = $shifts;
        $this->createPDFBody();
    }

    protected function createPDFBody()
    {
        $html = '<body>';
        $html .= '<style type="text/css">table {border-collapse: collapse;} table, th, td {border: 1px solid black;}</style>';
        $html .= '<h1 style="text-align: center;">'.$this->department['departmentName'].' Shift Schedule</h1>';
        //Group shifts by day...
        $days = array();
        $shifts = $this->shifts;
        $count = count($shifts);
        for($i = 0; $i < $count; $i++)
        {
            $start = new \DateTime($shifts[$i]['startTime']);
            $end = new \DateTime($shifts[$i]['endTime']);
            $shifts[$i]['startTime'] = $start;
            $shifts[$i]['endTime'] = $end;
            $dateStr = $start->format('l (n/j/Y)');
            $timeStr = $start->format('g:i A').' till '.$end->format('g:i A');
            if(strlen($shifts[$i]['name']) > 0)
            {
                $timeStr .=' - <i>'.$shifts[$i]['name'].'</i>';
            }
            if(!isset($days[$dateStr]))
            {
                $days[$dateStr] = array();
            }
            if(!isset($days[$dateStr][$timeStr]))
            {
                $days[$dateStr][$timeStr] = array();
            }
            array_push($days[$dateStr][$timeStr], $shifts[$i]);
        }
        ksort($days);
        foreach($days as $dateStr=>$day)
        {
            $html .='<h2>'.$dateStr.'</h2>';
            uksort($day, array($this, 'groupSort'));
            foreach($day as $shiftStr=>$shifts)
            {
                usort($shifts, array($this, 'shiftSort'));
                $html .='<h3>'.$shiftStr.'</h3>';
                $html .='<table width="100%"><tr><th style="width: 20%">Role</th><th>Volunteer Name</th><th>Volunteer Camp</th></tr>';
                foreach($shifts as $shift)
                {
                    //TODO Volunteer info for shift...
                    $html .='<tr><td>'.$this->getRoleNameFromID($shift['roleID']).'</td><td></td><td></td></tr>';
                }
                $html .='</table>';
            }
        }
        $html .='</body>';
        $this->setPDFFromHTML($html);
    }
} 


1			<?php
2			namespace Schedules;
3
4			class SimplePDF extends \PDF\PDF
5			{
6			use ShiftSchedule;
7
8			protected $department;
9			protected $shifts;
10
11			function __construct($department, $shifts)
			0 ignored issues – show Best Practice introduced 2019-06-20 19:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
12			{
13			parent::__construct();
14			$this->department = $department;
15			$this->shifts = $shifts;
16			$this->createPDFBody();
17			}
18
19			protected function createPDFBody()
20			{
21			$html = '<body>';
22			$html .= '<style type="text/css">table {border-collapse: collapse;} table, th, td {border: 1px solid black;}</style>';
23			$html .= '<h1 style="text-align: center;">'.$this->department['departmentName'].' Shift Schedule</h1>';
24			//Group shifts by day...
25			$days = array();
26			$shifts = $this->shifts;
27			$count = count($shifts);
28			for($i = 0; $i < $count; $i++)
29			{
30			$start = new \DateTime($shifts[$i]['startTime']);
31			$end = new \DateTime($shifts[$i]['endTime']);
32			$shifts[$i]['startTime'] = $start;
33			$shifts[$i]['endTime'] = $end;
34			$dateStr = $start->format('l (n/j/Y)');
35			$timeStr = $start->format('g:i A').' till '.$end->format('g:i A');
36			if(strlen($shifts[$i]['name']) > 0)
37			{
38			$timeStr .=' - <i>'.$shifts[$i]['name'].'</i>';
39			}
40			if(!isset($days[$dateStr]))
41			{
42			$days[$dateStr] = array();
43			}
44			if(!isset($days[$dateStr][$timeStr]))
45			{
46			$days[$dateStr][$timeStr] = array();
47			}
48			array_push($days[$dateStr][$timeStr], $shifts[$i]);
49			}
50			ksort($days);
51			foreach($days as $dateStr=>$day)
52			{
53			$html .='<h2>'.$dateStr.'</h2>';
54			uksort($day, array($this, 'groupSort'));
55			foreach($day as $shiftStr=>$shifts)
56			{
57			usort($shifts, array($this, 'shiftSort'));
58			$html .='<h3>'.$shiftStr.'</h3>';
59			$html .='<table width="100%"><tr><th style="width: 20%">Role</th><th>Volunteer Name</th><th>Volunteer Camp</th></tr>';
60			foreach($shifts as $shift)
61			{
62			//TODO Volunteer info for shift...
63			$html .='<tr><td>'.$this->getRoleNameFromID($shift['roleID']).'</td><td></td><td></td></tr>';
64			}
65			$html .='</table>';
66			}
67			}
68			$html .='</body>';
69			$this->setPDFFromHTML($html);
70			}
71			}
72

BurningFlipside / VolunteerSystem

Push — FVSv2 ( 1cad04...78f5f9 )

app/Schedules/class.SimplePDF.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like