VolunteerDepartment

Complexity

Total Complexity

6

Size/Duplication

Total Lines	37
Duplicated Lines	40.54 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	15	15	3
A	getLeadEmails()	0	16	3

<?php
class VolunteerDepartment
{
    protected $dbData;

    public function __construct($departmentID, $dbData = null)

This method seems to be duplicated in your project.

    {
        if($dbData === null)
        {
            $dataTable = DataSetFactory::getDataTableByNames('fvs', 'departments');
            $filter = new \Data\Filter('departmentID eq '.$departmentID);
            $depts = $dataTable->read($filter);
            if(empty($depts))
            {
                throw new Exception('Unable to locate department with ID '.$departmentID);
            }
            $dbData = $depts[0];
        }
        $this->dbData = $dbData;
    }

    public function getLeadEmails()
    {
        $leadTitle = $dbData['lead'];

The variable $dbData does not exist. Did you forget to declare it?

        $auth = \AuthProvider::getInstance();
        $users = $auth->getUsersByFilter(new \Data\Filter('title eq '.$leadTitle), array('mail'));
        if(empty($users))
        {
            return null;
        }
        $count = count($users);
        for($i = 0; $i < $count; $i++)
        {
            $users[$i] = $users[$i]['mail'];
        }
        return $users;
    }
}