shift_api.php ➔ shiftGroup() - Code Metrics - Inspection of "Add composer and codeclimate files" - BurningFlipside/VolunteerSystem - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — FVSv2 (bb4b20)

by Patrick

created 2016-06-15 14:34 UTC

shift_api.php ➔ shiftGroup() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	3
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	5
rs	9.4285

<?php

function shiftGroup()
{
    global $app;
function myFunction($a, $b) {
    // Do something
}
    $app->get('(/)', 'getCurrentShiftList');
}

function getCurrentShiftList()
{
    global $app;
function myFunction($a, $b) {
    // Do something
}
    if(!$app->user)
    {
        throw new Exception('Must be logged in', ACCESS_DENIED);
    }
    $dataSet = DataSetFactory::get_data_set('fvs');

    $dataTable = $dataSet['shifts'];
    $ret = false;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    if($app->user->isInGroupNamed('VolunteerAdmins'))
    {
        $ret = $dataTable->read($app->odata->filter, $app->odata->select, $app->odata->top, $app->odata->skip, $app->odata->orderby);
    }
    else
    {
        $myDept = false;
        if($app->user->isInGroupNamed('Lead'))
        {
            $myDept = \Volunteer\Shifts::getShiftsForLead($app->user, $app->odata->select);
        }
        $depts = \Volunteer\Shifts::getPublicShifts($app->odata->select);
        if($myDept)
        {
            $depts = array_merge($depts, $myDept);
        }
        $ret = $depts;
    }
    echo json_encode($ret);
}

?>



1			<?php
2
3			function shiftGroup()
4			{
5			global $app;
			0 ignored issues – show Compatibility Best Practice introduced 2016-06-15 14:31 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
6			$app->get('(/)', 'getCurrentShiftList');
7			}
8
9			function getCurrentShiftList()
10			{
11			global $app;
			0 ignored issues – show Compatibility Best Practice introduced 2016-06-15 14:31 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
12			if(!$app->user)
13			{
14			throw new Exception('Must be logged in', ACCESS_DENIED);
15			}
16			$dataSet = DataSetFactory::get_data_set('fvs');
			0 ignored issues – show Deprecated Code introduced 2016-06-15 14:37 UTC by Report Bug Copy Issue Report The method `DataSetFactory::get_data_set()` has been deprecated with message: 2.0.0 Utilize the getDataSetByName() instead This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
17			$dataTable = $dataSet['shifts'];
18			$ret = false;
			0 ignored issues – show Unused Code introduced 2016-06-15 14:31 UTC by Report Bug Copy Issue Report `$ret` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
19			if($app->user->isInGroupNamed('VolunteerAdmins'))
20			{
21			$ret = $dataTable->read($app->odata->filter, $app->odata->select, $app->odata->top, $app->odata->skip, $app->odata->orderby);
22			}
23			else
24			{
25			$myDept = false;
26			if($app->user->isInGroupNamed('Lead'))
27			{
28			$myDept = \Volunteer\Shifts::getShiftsForLead($app->user, $app->odata->select);
29			}
30			$depts = \Volunteer\Shifts::getPublicShifts($app->odata->select);
31			if($myDept)
32			{
33			$depts = array_merge($depts, $myDept);
34			}
35			$ret = $depts;
36			}
37			echo json_encode($ret);
38			}
39
40			?>
			0 ignored issues – show Best Practice introduced 2016-06-15 14:31 UTC by Report Bug Copy Issue Report It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
41

BurningFlipside / VolunteerSystem

Branch — FVSv2 (bb4b20)

shift_api.php ➔ shiftGroup() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like