RoleAPI::isVolunteerAdmin() - Code Metrics - Inspection of "Remove some common API code to parent class" - BurningFlipside/VolunteerSystem - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — FVSv2 ( 1ec6b9...63e0fa )

by Patrick

created 2019-06-20 20:14 UTC

RoleAPI::isVolunteerAdmin() A

↳ Parent: RoleAPI

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	1
dl	0
loc	5
rs	10
c	0
b	0
f	0

<?php
class RoleAPI extends VolunteerAPI
{
    use Processor;

    public function __construct()
    {
        parent::__construct('roles', 'short_name');
    }

    protected function canEditDept($request, $deptId)
    {
        if($this->isVolunteerAdmin($request))
        {
            return true;
        }
        return $this->isUserDepartmentLead($deptId, $this->user);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    protected function canUpdate($request, $entity)
    {
        return $this->canEditDept($request, $entity['departmentID']);
    }

    protected function canDelete($request, $entity)
    {
        return $this->canUpdate($request, $entity);
    }

    protected function processEntry($entry, $request)
    {
        return $this->processRole($entry, $request);
    }
}


1			<?php
2			class RoleAPI extends VolunteerAPI
3			{
4			use Processor;
5
6			public function __construct()
7			{
8			parent::__construct('roles', 'short_name');
9			}
10
11			protected function canEditDept($request, $deptId)
12			{
13			if($this->isVolunteerAdmin($request))
14			{
15			return true;
16			}
17			return $this->isUserDepartmentLead($deptId, $this->user);
			1 ignored issue – show Bug introduced 2019-06-20 20:15 UTC by Report Bug Copy Issue Report The property `user` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
18			}
19
20			protected function canUpdate($request, $entity)
21			{
22			return $this->canEditDept($request, $entity['departmentID']);
23			}
24
25			protected function canDelete($request, $entity)
26			{
27			return $this->canUpdate($request, $entity);
28			}
29
30			protected function processEntry($entry, $request)
31			{
32			return $this->processRole($entry, $request);
33			}
34			}
35

BurningFlipside / VolunteerSystem

Push — FVSv2 ( 1ec6b9...63e0fa )

RoleAPI::isVolunteerAdmin() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like