for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
class VolunteerAPI extends Http\Rest\DataTableAPI
{
protected $isAdmin = null;
protected $isLead = null;
public function __construct($dataTableName, $idField = '_id')
parent::__construct('fvs', $dataTableName, $idField);
$idField
string
boolean
It seems like the type of the argument is not accepted by the function/method which you are calling.
In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.
We suggest to add an explicit type cast like in the following example:
function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x);
}
protected function isVolunteerAdmin($request)
$this->validateLoggedIn($request);
if($this->isAdmin === null)
$this->isAdmin = $this->user->isInGroupNamed('VolunteerAdmins');
user
In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:
class MyClass { } $x = new MyClass(); $x->foo = true;
Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion:
class MyClass { public $foo; } $x = new MyClass(); $x->foo = true;
return $this->isAdmin;
protected function canCreate($request)
return $this->isVolunteerAdmin($request);
BurningFlipside /
VolunteerSystem
Loading history...
It seems like the type of the argument is not accepted by the function/method which you are calling.
In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.
We suggest to add an explicit type cast like in the following example: