VolunteerEvent::addToEEList() - Code Metrics - Inspection of "Initial add of ee pages" - BurningFlipside/VolunteerSystem - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ed6913...63632c )

by Patrick

created 2020-01-27 19:27 UTC

VolunteerEvent::addToEEList() A

↳ Parent: VolunteerEvent

Complexity

Conditions	4
Paths	8

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
nc	8
nop	2
dl	0
loc	20
rs	9.6
c	0
b	0
f	0

<?php
class VolunteerEvent extends VolunteerObject
{
    public function __construct($departmentID, $dbData = null)
    {
        parent::__construct($departmentID, $dbData, 'events', '_id');
    }

    public function hasVolOnEEList($uid, $eeListIndex)
    {
        if($eeListIndex === 1 || $eeListIndex === 0)
        {
            //Check earlier EE lists too
            $val = $this->hasVolOnEEList($uid, $eeListIndex+1);
            if($val === true)
            {
                return true;
            }
        }
        if(isset($this->dbData['eeLists']) && isset($this->dbData['eeLists'][$eeListIndex]))
        {
            $eeList = $this->dbData['eeLists'][$eeListIndex];
            if(isset($eeList[$uid]) && $eeList[$uid]['AAR'] === true && $eeList[$uid]['AF'] === true && $eeList[$uid]['Lead'] === true)
            {
                return true;
            }
        }
        return false;
    }

    public function addToEEList($uid, $eeListIndex)
    {
        if(!isset($this->dbData['eeLists']))
        {
            $this->dbData['eeLists'] = array();
        }
        if(!isset($this->dbData['eeLists'][$eeListIndex]))
        {
            $this->dbData['eeLists'][$eeListIndex] = array();
        }
        $eeList = $this->dbData['eeLists'][$eeListIndex];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if(!isset($this->dbData['eeLists'][$eeListIndex][$uid]))
        {
            $this->dbData['eeLists'][$eeListIndex][$uid] = array('AAR'=>false, 'AF'=>false, 'Lead'=>false);
            $dt = $this->getDataTable();
            $filter = $this->getDataFilter();
            return $dt->update($filter, $this->dbData);
        }
        return true;
    }
}


1			<?php
2			class VolunteerEvent extends VolunteerObject
3			{
4			public function __construct($departmentID, $dbData = null)
5			{
6			parent::__construct($departmentID, $dbData, 'events', '_id');
7			}
8
9			public function hasVolOnEEList($uid, $eeListIndex)
10			{
11			if($eeListIndex === 1 \|\| $eeListIndex === 0)
12			{
13			//Check earlier EE lists too
14			$val = $this->hasVolOnEEList($uid, $eeListIndex+1);
15			if($val === true)
16			{
17			return true;
18			}
19			}
20			if(isset($this->dbData['eeLists']) && isset($this->dbData['eeLists'][$eeListIndex]))
21			{
22			$eeList = $this->dbData['eeLists'][$eeListIndex];
23			if(isset($eeList[$uid]) && $eeList[$uid]['AAR'] === true && $eeList[$uid]['AF'] === true && $eeList[$uid]['Lead'] === true)
24			{
25			return true;
26			}
27			}
28			return false;
29			}
30
31			public function addToEEList($uid, $eeListIndex)
32			{
33			if(!isset($this->dbData['eeLists']))
34			{
35			$this->dbData['eeLists'] = array();
36			}
37			if(!isset($this->dbData['eeLists'][$eeListIndex]))
38			{
39			$this->dbData['eeLists'][$eeListIndex] = array();
40			}
41			$eeList = $this->dbData['eeLists'][$eeListIndex];
			0 ignored issues – show Unused Code introduced 2020-01-27 19:29 UTC by Report Bug Copy Issue Report `$eeList` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
42			if(!isset($this->dbData['eeLists'][$eeListIndex][$uid]))
43			{
44			$this->dbData['eeLists'][$eeListIndex][$uid] = array('AAR'=>false, 'AF'=>false, 'Lead'=>false);
45			$dt = $this->getDataTable();
46			$filter = $this->getDataFilter();
47			return $dt->update($filter, $this->dbData);
48			}
49			return true;
50			}
51			}
52

BurningFlipside / VolunteerSystem

Push — master ( ed6913...63632c )

VolunteerEvent::addToEEList() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like