BurningFlipside / VolunteerSystem

class.VolunteerPage.php

<?php
ini_set('display_errors', 1);
error_reporting(E_ALL);
require_once('class.SecurePage.php');
require_once('class.FlipSession.php');
require_once('app/VolunteerAutoload.php');
class VolunteerPage extends SecurePage
{
    public  $volunteerRoot;

    function __construct($title)

It is generally recommended to explicitly declare the visibility for methods.

    {
        parent::__construct($title);
        $root = $_SERVER['DOCUMENT_ROOT'];
        $script_dir = dirname(__FILE__);
        $this->volunteerRoot = substr($script_dir, strlen($root));
        $this->addJS($this->volunteerRoot.'/js/volunteer.js', false);

The call to VolunteerPage::addJS() has too many arguments starting with false.

        $this->addTemplateDir(dirname(__FILE__).'/templates', 'Volunteer');
        $this->setTemplateName('@Volunteer/main.html');
        $this->addCSS('https://cdnjs.cloudflare.com/ajax/libs/select2/4.0.7/css/select2.min.css');
        $this->addJS('https://cdnjs.cloudflare.com/ajax/libs/select2/4.0.7/js/select2.min.js');
        if($this->isAdmin() || $this->isLead())
        {
            $this->addLink('Admin', '_admin/');
        }
        if($this->user !== false && $this->user !== null)

The property user does not exist. Did you maybe forget to declare it?

        {
            $this->addLink('Settings', 'settings.php');
        }
    }

    function printPage($header = true)

It is generally recommended to explicitly declare the visibility for methods.

    {
        if($this->user === false || $this->user === null)
        {
            $this->body = '
<div id="content">
    <h1>You must <a href="https://profiles.burningflipside.com/login.php?return='.$this->currentURL().'">log in <span class="fa fa-sign-in-alt"></span></a> to access the Burning Flipside Volunteer system!</h1>
</div>';
        }
        parent::printPage($header);

The call to SecurePage::printPage() has too many arguments starting with $header.

    }

    function isAdmin()

It is generally recommended to explicitly declare the visibility for methods.

    {
        if($this->user === false || $this->user === null)
        {
            return false;
        }
        return $this->user->isInGroupNamed('VolunteerAdmins');
    }

    function isLead()

It is generally recommended to explicitly declare the visibility for methods.

    {
        if($this->user === false || $this->user === null)
        {
            return false;
        }
        return $this->user->isInGroupNamed('Leads');
    }
}